| # |
Aug 14th 2009, 16:16 |
markstory |
need another map var. |
| # |
Aug 14th 2009, 16:16 |
markstory |
poLK: that setup conflicts with passing params to helpers. |
| # |
Aug 14th 2009, 16:16 |
alkemann |
u tell cake to put a different class instance in $html variable, but intention is that this new helper extends the one one expects to be there? |
| # |
Aug 14th 2009, 16:16 |
poLK |
declared to use in controller by $helpers = array('Html' => 'Canonical', 'Form', ...); |
| # |
Aug 14th 2009, 16:15 |
poLK |
alkemann: no, to overwrite meta() method in CanonicalHelper extending HtmlHelper, and then use it from views like $html->meta('canonical') |
| # |
Aug 14th 2009, 16:13 |
alkemann |
to add one method to do one line of code? |
| # |
Aug 14th 2009, 16:13 |
poLK |
I still think this way for replacing core helpers would be sweet |
| # |
Aug 14th 2009, 16:13 |
alkemann |
i dont think that helper is a reasonable solution to this issue. poLK gave two much better using the existing html helper |
| # |
Aug 14th 2009, 16:12 |
poLK |
(time to chat about ... again' |
| # |
Aug 14th 2009, 16:12 |
poLK |
markstory: probably time to chat about var $helpers = array('Html' => 'Canonical'); (class CanonicalHelper extends HtmlHelper, and then $html->meta('canonical')) |
| # |
Aug 14th 2009, 16:10 |
markstory |
but making a helper is a reasonable solution. |
| # |
Aug 14th 2009, 16:09 |
poLK |
+1 |
| # |
Aug 14th 2009, 16:08 |
markstory |
well I think the article is fine as it, making a separate helper is a bit overkill, you can do it with HtmlHelper right now, just not as nice. |
| # |
Aug 14th 2009, 16:06 |
alkemann |
so get the patch in and tell the guy to rewrite the article as a tutorial? linking to the commit for people that cant wait |
| # |
Aug 14th 2009, 16:03 |
markstory |
right. |
| # |
Aug 14th 2009, 16:02 |
alkemann |
the words "just" and "to" makes a big difference in that sentence ;) |
| # |
Aug 14th 2009, 16:02 |
markstory |
which I've been doing as I find them. |
| # |
Aug 14th 2009, 16:02 |
markstory |
just have to document the options. |
| # |
Aug 14th 2009, 16:02 |
markstory |
nuh uh. |
| # |
Aug 14th 2009, 16:02 |
alkemann |
well yea, except this sort of api gets hidden in the Api |
| # |
Aug 14th 2009, 16:01 |
markstory |
yeah |
| # |
Aug 14th 2009, 16:00 |
poLK |
I would prefer extension of meta, it uses hardcoded array $types (rss/atom/icon/keywords/description) already |
| # |
Aug 14th 2009, 15:59 |
markstory |
but flexiblity is nice. |
| # |
Aug 14th 2009, 15:59 |
markstory |
me neither. |
| # |
Aug 14th 2009, 15:59 |
alkemann |
can think of a case where you would want to, but sure ;) |
| # |
Aug 14th 2009, 15:59 |
markstory |
$url can be used to override Router::url() or something. |
| # |
Aug 14th 2009, 15:58 |
markstory |
html->meta('canonical') |
| # |
Aug 14th 2009, 15:58 |
alkemann |
if u prefer |
| # |
Aug 14th 2009, 15:58 |
markstory |
or an extension of meta() |
| # |
Aug 14th 2009, 15:57 |
alkemann |
i dont see why it couldnt be a matter of echo $html->canon(); view and helper knows the current url and can ask router for the correct url |
| # |
Aug 14th 2009, 15:56 |
markstory |
alkemann: so some sort of method that makes canonical links for the current url> |
| # |
Aug 14th 2009, 15:55 |
alkemann |
because of /pages/home and / |
| # |
Aug 14th 2009, 15:55 |
alkemann |
i got this on my website's public layout : <link rel="canonical" href="http://illustrata.no<?php echo $html->url(); ?>"> |
| # |
Aug 14th 2009, 15:54 |
alkemann |
if for no other reason than stop critics that read an article about duplciate content ;) |
| # |
Aug 14th 2009, 15:53 |
poLK |
markstory: yes, it produces (1.2) <link href="http://example.com" rel="canonical" /> |
| # |
Aug 14th 2009, 15:53 |
alkemann |
since cakephp routes creates "problems" of duplicate content, I think it could be worth while to have a more direct support for it |
| # |
Aug 14th 2009, 15:52 |
markstory |
easiest enhancement ever. |
| # |
Aug 14th 2009, 15:52 |
markstory |
poLK: if that works my job is done then :) |
| # |
Aug 14th 2009, 15:52 |
alkemann |
markstory: google supports it. what else matters ;) |
| # |
Aug 14th 2009, 15:52 |
poLK |
(uses 'metalink' tag) |
| # |
Aug 14th 2009, 15:52 |
alkemann |
+t |