| # |
Aug 14th 2009, 15:00 |
poLK |
sky_l3ppard: now, this article needs just some spell/grammary check |
| # |
Aug 14th 2009, 14:58 |
sky_l3ppard |
i'm away for 15 min |
| # |
Aug 14th 2009, 14:58 |
poLK |
alkemann: with this behavior, one can keep default translations in original table, and let i18n table manage only non-default ones |
| # |
Aug 14th 2009, 14:57 |
poLK |
sky_l3ppard: again, 'source record' instead of db table |
| # |
Aug 14th 2009, 14:57 |
poLK |
In this case we tell Translate behavior to translate Post.title field and SmoothTranslate to create default translation records for all our app languages and do not modify title field in the source record then saved in different locale. |
| # |
Aug 14th 2009, 14:56 |
poLK |
sky_l3ppard: section 'Using the behavior': |
| # |
Aug 14th 2009, 14:56 |
sky_l3ppard |
in extensible case i unset those fields before saving if record is being modified |
| # |
Aug 14th 2009, 14:56 |
poLK |
'when', yes |
| # |
Aug 14th 2009, 14:55 |
sky_l3ppard |
core behavior also updates original record then adding new translation to the i18n table, as far as i understood |
| # |
Aug 14th 2009, 14:54 |
poLK |
ok |
| # |
Aug 14th 2009, 14:54 |
sky_l3ppard |
look it one more time please |
| # |
Aug 14th 2009, 14:54 |
poLK |
sky_l3ppard: one of reasons for your behavior is: keep default translation for 'title' in field posts.title - and core's behavior requires to remove posts.title field from db schema |
| # |
Aug 14th 2009, 14:54 |
sky_l3ppard |
) poLK now i've changed |
| # |
Aug 14th 2009, 14:53 |
alkemann |
ACTION didnt understand neither |
| # |
Aug 14th 2009, 14:53 |
poLK |
'source record translatable field untouched' speaks about record, but readers should notice that core's behavior needs to _remove_ fields from schema |
| # |
Aug 14th 2009, 14:52 |
poLK |
sky_l3ppard: my point is that your words 'source record translatable field untouched' sounds better like 'structure of original database table, used by some translated model' |
| # |
Aug 14th 2009, 14:49 |
sky_l3ppard |
the third notice, cant find there to fit it :) |
| # |
Aug 14th 2009, 14:47 |
poLK |
because it was touched by many hands from core team |
| # |
Aug 14th 2009, 14:46 |
poLK |
belongs |
| # |
Aug 14th 2009, 14:46 |
poLK |
also, your thanks to 'authors' belogs to 'core developers' ;) |
| # |
Aug 14th 2009, 14:45 |
poLK |
sky_l3ppard: if you'll find some native English speaker here to check it (I'm sorry I can't help you with that, I'm also slavonian), it is ready to be published |
| # |
Aug 14th 2009, 14:42 |
sky_l3ppard |
ok |
| # |
Aug 14th 2009, 14:42 |
poLK |
. |
| # |
Aug 14th 2009, 14:41 |
poLK |
- 3) no need to alter original table when adding translations later |
| # |
Aug 14th 2009, 14:41 |
poLK |
- 3 |
| # |
Aug 14th 2009, 14:40 |
poLK |
- 2) 'There are cases when', not 'Where are cases then' |
| # |
Aug 14th 2009, 14:40 |
poLK |
- 1) doesn't sound like English to me (and my English is bad too) |
| # |
Aug 14th 2009, 14:39 |
poLK |
sky_l3ppard: sure |
| # |
Aug 14th 2009, 14:34 |
sky_l3ppard |
poLK, can you look at it one more moment? |
| # |
Aug 14th 2009, 14:05 |
poLK |
I assume good feedback on your article :) |
| # |
Aug 14th 2009, 14:05 |
poLK |
it is not criticism (!), I just think 1st part of this article should do some short compare of core's and your's behavior features. |
| # |
Aug 14th 2009, 14:04 |
sky_l3ppard |
yes you're right, i'll fix this |
| # |
Aug 14th 2009, 14:03 |
poLK |
also, it is not patch to TranslateBehavior, but class extending it to add/change some functionality. |
| # |
Aug 14th 2009, 14:02 |
poLK |
because you're saying purpose of your code just roughly |
| # |
Aug 14th 2009, 14:02 |
poLK |
sky_l3ppard: I had no chance to test your code yet, but I readed it and it seems ok to me. As of text of this article, I miss there one thing - one or two sentences, describing better how is this behavior different from core's one. Like: 'core TranslateBehavior requires to remove 'title/body etc fields from original table and handles default translations differently then I needed' |
| # |
Aug 14th 2009, 13:58 |
sky_l3ppard |
well i have one arm and i can type too, you know, you live with it and get used to it, and when you are going into something you really like like programming, it becomes not so important |
| # |
Aug 14th 2009, 13:56 |
poLK |
well, I am online and can type, so I would say that everything is ok :) |
| # |
Aug 14th 2009, 13:56 |
sky_l3ppard |
oh sorry, I hope everything it is ok? |
| # |
Aug 14th 2009, 13:56 |
poLK |
in during of last ~2 years, I had one-weekend vacation, many weeks in hospital, and that's it |
| # |
Aug 14th 2009, 13:55 |
poLK |
doctors loves me too much |
| # |
Aug 14th 2009, 13:55 |
sky_l3ppard |
ah, so now you had a real one? |