Log message #4266582

# At Username Text
# Jun 25th 2021, 16:56 nick.vanderwoude @steinkel I did see that. Is it working?
# Jun 25th 2021, 16:55 steinkel @nick.vanderwoude we did some work time ago to provide a specific endpoint for ajax login here https://github.com/CakeDC/users/pull/789
# Jun 25th 2021, 16:55 ricmelero although placeholder length is arbitrary... mm
# Jun 25th 2021, 16:54 ricmelero and there is no attemp to trying to check longer first.. even that I understand that it may have placeholders or dinamyc parts
# Jun 25th 2021, 16:53 ricmelero yep, I see that krsort, is present in a few places.. and yes @admad, I get that, and that's why I was thinking about it, inside each path, you may have many routes
# Jun 25th 2021, 16:52 admad But you lose that optimization for lang routes since they start with a placeholder
# Jun 25th 2021, 16:51 kevin.pfeifer i guess you mean that krsort https://github.com/cakephp/cakephp/blob/master/src/Routing/RouteCollection.php#L130
# Jun 25th 2021, 16:51 admad It does sort them by *static* longer parts first.
# Jun 25th 2021, 16:50 ricmelero but besides that case, I was thinking that routes is trying to check longer paths first, ordering that way, but inside each path, this behavior does not apply... wouldn't be that a desired behavior? I mean, inside each path, sort routes with longer names or templates first.. I may work in a PR if that's the case
# Jun 25th 2021, 16:47 ricmelero this way is cleaner
# Jun 25th 2021, 16:47 ricmelero I had moved all inside Plugin::routes() method to my routes.php, also worked, but it wasn't feel rigth
# Jun 25th 2021, 16:45 ricmelero yeah, that did the trick,
# Jun 25th 2021, 16:44 admad you can use `$routes->loadPlugin('Foo')` at the top of your `routes.php` to load the plugin's route first.
# Jun 25th 2021, 16:43 ricmelero I can get it working, but it feel like a hack
# Jun 25th 2021, 16:43 ricmelero so, they are loaded after app routes
# Jun 25th 2021, 16:42 ricmelero I've app routes defined in config/routes.php, but plugin routes are in each plugin's Plugin::routes() method
# Jun 25th 2021, 16:41 admad Just overly generic routes are bound to cause you problems.
# Jun 25th 2021, 16:40 admad > sorry, it's like this "/{lang}/{controller}/{action}/*" Well then no wonder it matches, fix your routes order.
# Jun 25th 2021, 16:39 ricmelero may I attach an image here?
# Jun 25th 2021, 16:39 kevin.pfeifer but your `/{lang}/admin/{controller}/{action}` route is present above the blue one?
# Jun 25th 2021, 16:38 ricmelero @kevin.pfeifer yep
# Jun 25th 2021, 16:38 kevin.pfeifer so if you enable debugkit and check the “Routes” tab the wrong route is marked blue?
# Jun 25th 2021, 16:37 ricmelero that's why it matchs
# Jun 25th 2021, 16:37 ricmelero sorry, it's like this "/{lang}/{controller}/{action}/*"
# Jun 25th 2021, 16:34 admad > /es/admin/users/view/1 is matching with /{lang}/{controller}/{action} @ricmelero I don't see how that's possible since your URL has 4 parts while the route has just 3 (and there's no `/*` at the end). And even if that's the case just connect your routes for admin prefix earlier.
# Jun 25th 2021, 16:25 nick.vanderwoude @ndm That's good advice, thanks. I was able to make some progress from newing up my own new Response object in the controller and returning that. It prevents the api endpoint from getting redirected, which is better, but I am still having issues getting the data out on the front end
# Jun 25th 2021, 16:10 slackebot whatever you want. But since that's coming from someone who's not familiar with the plugin, take it with a grain of salt.
# Jun 25th 2021, 16:10 ndm @nick.vanderwoude I'm not overly familiar with the plugin, but looking at the code, the redirects seem pretty much hardcoded. https://github.com/CakeDC/users/blob/master/src/Controller/Component/LoginComponent.php#L145 You could probably provide a custom `login()` action, require the trait's method in an aliased fashion, invoke it manually and extract the required information from the returned response, then you can do with it
# Jun 25th 2021, 16:09 ricmelero I was debbuging and I saw that all routes ended up under "/" path in the routes collection, so the revert sorting to move longer paths first, does nothing, and inside that path, plugin routes are added after, so is matching the shorter first, without plugin prefix
# Jun 25th 2021, 16:06 slackebot way.
# Jun 25th 2021, 16:06 ricmelero @admad I'm using your i18n routing plugin, in a cakephp 4 project, and I'd isolated roles within plugins, and I having issues with routing: for example /es/admin/users/view/1 is matching with /{lang}/{controller} /{action} instead of /{lang}/admin/{controller}/{action} Sorry to bother you directly, but I just want to know if it you have used with plugins, if there is something extra to do or if just doesn't suppose to work this
# Jun 25th 2021, 16:01 staccato123 Thanks all. I have now got it throwing errors in my code instead of its code ;) plus it's five o'clock so excellent timing! Have a good weekend, all
# Jun 25th 2021, 15:53 nick.vanderwoude how can I interrupt this login action so I can handle the redirect on the front end?
# Jun 25th 2021, 15:52 nick.vanderwoude the problem is that the 302 redirect occurs, so when the response gets back to the front end it's a 500 because the 302 redirected to the next location before it returned
# Jun 25th 2021, 15:52 nick.vanderwoude This works correctly: when I hit the endpoint it correctly logs in the user with the credentials i sent in a form
# Jun 25th 2021, 15:51 nick.vanderwoude Hi all! I am looking for some support. I am working on setting up a custom React front end to handle log ins. I am connecting to a custom API endpoint that calls the login() action on the LoginTrait of the CakeDC auth plugin
# Jun 25th 2021, 15:41 staccato123 They're very short anyway
# Jun 25th 2021, 15:41 staccato123 @admad will do
# Jun 25th 2021, 15:04 greg138 Inquiring minds want to know...
# Jun 25th 2021, 15:01 admad *them then
# Jun 25th 2021, 15:01 admad staccato123: if you are going to rewrite them them better write them as commands, shells have been deprecated :)