| # |
Sep 10th 2019, 09:36 |
 admad |
Such use case is rare but we do support it in 3.x so it's better to retain it :slightly_smiling_face: |
| # |
Sep 10th 2019, 09:33 |
spriz |
I just assumed it would need to be a string as that would make sense to me |
| # |
Sep 10th 2019, 09:32 |
spriz |
Nah, but all I'm saying is that I did not even expect being able to put arrays directly in there |
| # |
Sep 10th 2019, 09:32 |
challgren |
Yeah |
| # |
Sep 10th 2019, 09:32 |
admad |
Having to use Router::url() like @spriz showed isn't user friendly |
| # |
Sep 10th 2019, 09:31 |
admad |
Usage would be same in 3.x too if someone is generating assets dynamically |
| # |
Sep 10th 2019, 09:30 |
challgren |
I couldnt find any 3.x codebases using arrays |
| # |
Sep 10th 2019, 09:30 |
challgren |
But again those were only in 1.x and 2.x |
| # |
Sep 10th 2019, 09:29 |
admad |
..in HtmlHelper at least |
| # |
Sep 10th 2019, 09:29 |
admad |
@challgren thanks for looking into this. It has made me realise that ability to using arrays should be retained |
| # |
Sep 10th 2019, 09:18 |
challgren |
@david it should |
| # |
Sep 10th 2019, 09:10 |
david |
I'm using Client() to execute a get request using a proxy. If I need to use a a proxy in a post request, is the same way as GET? |
| # |
Sep 10th 2019, 09:09 |
david |
Morning |
| # |
Sep 10th 2019, 09:08 |
spriz |
In cases where we do show image (svg) generated by another controller we actually do `$this->Html->image(Router::url([])...)` :shrug: |
| # |
Sep 10th 2019, 09:07 |
challgren |
Yeah true that would be really the only time I could see using an array |
| # |
Sep 10th 2019, 09:03 |
neon1024 |
Although if could generate it, you could probably save it to the file system |
| # |
Sep 10th 2019, 09:02 |
neon1024 |
As it looks like the array in this instance might be calling a controller to generate a barcode |
| # |
Sep 10th 2019, 09:02 |
neon1024 |
Still the use-case is valid @challgren |
| # |
Sep 10th 2019, 08:47 |
challgren |
Ok so to play devils advocate, even if they are deprecated in 3.9, I’m pretty sure the people writing code like that dont have proper tests in place to find the deprecations |
| # |
Sep 10th 2019, 08:46 |
challgren |
Yeah everyone I found is Cake 1.x or 2.x |
| # |
Sep 10th 2019, 08:45 |
challgren |
https://github.com/mytepper/zeanleague_v2/blob/61dc2382264cf78be5faa0c9b470c070adaa3d8e/app/View/Elements/predicts/list_predicts_member_table.ctp#L31-L39 |
| # |
Sep 10th 2019, 08:43 |
challgren |
Eww its 1.2 |
| # |
Sep 10th 2019, 08:43 |
challgren |
Ewww is that cake 1.x??? |
| # |
Sep 10th 2019, 08:43 |
challgren |
https://github.com/googlecode-mirror/double-l-bookmanagement/blob/cf034430ecc088893e2a879c1ccbf0af73d0a2bd/cakephp/app/View/Books/print_book_barcode.ctp#L35-L37 |
| # |
Sep 10th 2019, 08:40 |
challgren |
Now I kind of wanna find the 1 bozo using it |
| # |
Sep 10th 2019, 08:40 |
slackebot |
<challgren> |
| # |
Sep 10th 2019, 08:39 |
neon1024 |
Empirical evidence! |
| # |
Sep 10th 2019, 08:38 |
challgren |
Damm I must be bored, 30 pages and no arrays |
| # |
Sep 10th 2019, 08:35 |
challgren |
20 pages and no arrays |
| # |
Sep 10th 2019, 08:32 |
challgren |
Ive gone through 8 pages so far and looks like everyone is doing string |
| # |
Sep 10th 2019, 08:31 |
admad |
Any genius actually using `$this->Html->image(['/webroot', 'img/', 'foo.png'])` deserves his app to be broken |
| # |
Sep 10th 2019, 08:30 |
challgren |
https://github.com/search?q=%24this-%3EHtml-%3Eimage%28%5Bandtype=Code |
| # |
Sep 10th 2019, 08:30 |
neon1024 |
But as you guys said, I can’t see how you’d even use an array to path a static asset, so impact might be minimal |
| # |
Sep 10th 2019, 08:29 |
neon1024 |
It feels wrong to knowingly break someones application |
| # |
Sep 10th 2019, 08:29 |
neon1024 |
I don’t feel comfortable intentionally breaking BC though |
| # |
Sep 10th 2019, 08:29 |
neon1024 |
:thinking_face: |
| # |
Sep 10th 2019, 08:28 |
neon1024 |
`$this->Html->image(['/webroot', 'img/', 'foo.png'])`? |
| # |
Sep 10th 2019, 08:28 |
neon1024 |
How would you get an image with an array then? |
| # |
Sep 10th 2019, 08:28 |
neon1024 |
Just so you have absolutly no idea what’s going on |
| # |
Sep 10th 2019, 08:27 |
neon1024 |
`@return mixed` |
| # |
Sep 10th 2019, 08:27 |
challgren |
ROFL |