| # |
Sep 10th 2019, 08:47 |
 challgren |
Ok so to play devils advocate, even if they are deprecated in 3.9, I’m pretty sure the people writing code like that dont have proper tests in place to find the deprecations |
| # |
Sep 10th 2019, 08:46 |
challgren |
Yeah everyone I found is Cake 1.x or 2.x |
| # |
Sep 10th 2019, 08:45 |
challgren |
https://github.com/mytepper/zeanleague_v2/blob/61dc2382264cf78be5faa0c9b470c070adaa3d8e/app/View/Elements/predicts/list_predicts_member_table.ctp#L31-L39 |
| # |
Sep 10th 2019, 08:43 |
challgren |
Eww its 1.2 |
| # |
Sep 10th 2019, 08:43 |
challgren |
Ewww is that cake 1.x??? |
| # |
Sep 10th 2019, 08:43 |
challgren |
https://github.com/googlecode-mirror/double-l-bookmanagement/blob/cf034430ecc088893e2a879c1ccbf0af73d0a2bd/cakephp/app/View/Books/print_book_barcode.ctp#L35-L37 |
| # |
Sep 10th 2019, 08:40 |
challgren |
Now I kind of wanna find the 1 bozo using it |
| # |
Sep 10th 2019, 08:40 |
slackebot |
<challgren> |
| # |
Sep 10th 2019, 08:39 |
neon1024 |
Empirical evidence! |
| # |
Sep 10th 2019, 08:38 |
challgren |
Damm I must be bored, 30 pages and no arrays |
| # |
Sep 10th 2019, 08:35 |
challgren |
20 pages and no arrays |
| # |
Sep 10th 2019, 08:32 |
challgren |
Ive gone through 8 pages so far and looks like everyone is doing string |
| # |
Sep 10th 2019, 08:31 |
admad |
Any genius actually using `$this->Html->image(['/webroot', 'img/', 'foo.png'])` deserves his app to be broken |
| # |
Sep 10th 2019, 08:30 |
challgren |
https://github.com/search?q=%24this-%3EHtml-%3Eimage%28%5Bandtype=Code |
| # |
Sep 10th 2019, 08:30 |
neon1024 |
But as you guys said, I can’t see how you’d even use an array to path a static asset, so impact might be minimal |
| # |
Sep 10th 2019, 08:29 |
neon1024 |
It feels wrong to knowingly break someones application |
| # |
Sep 10th 2019, 08:29 |
neon1024 |
I don’t feel comfortable intentionally breaking BC though |
| # |
Sep 10th 2019, 08:29 |
neon1024 |
:thinking_face: |
| # |
Sep 10th 2019, 08:28 |
neon1024 |
`$this->Html->image(['/webroot', 'img/', 'foo.png'])`? |
| # |
Sep 10th 2019, 08:28 |
neon1024 |
How would you get an image with an array then? |
| # |
Sep 10th 2019, 08:28 |
neon1024 |
Just so you have absolutly no idea what’s going on |
| # |
Sep 10th 2019, 08:27 |
neon1024 |
`@return mixed` |
| # |
Sep 10th 2019, 08:27 |
challgren |
ROFL |
| # |
Sep 10th 2019, 08:27 |
neon1024 |
With `@inheritDoc` |
| # |
Sep 10th 2019, 08:27 |
neon1024 |
Probably `__call()` |
| # |
Sep 10th 2019, 08:27 |
challgren |
Its that damm cake magic I tell yah! |
| # |
Sep 10th 2019, 08:27 |
neon1024 |
Magic! |
| # |
Sep 10th 2019, 08:27 |
admad |
how do think HtmlHelper::image() gets it's image path? :slightly_smiling_face: |
| # |
Sep 10th 2019, 08:27 |
neon1024 |
I tend to use `$this->Html->image('foo.png')` |
| # |
Sep 10th 2019, 08:26 |
neon1024 |
Yeah, but your ticket said Url::image right? |
| # |
Sep 10th 2019, 08:26 |
admad |
@neon1024 you don't use `HtmlHelper::image()`? |
| # |
Sep 10th 2019, 08:25 |
admad |
> But honestly how would you even build it with an array? Since its not linked to any controllers My point exactly |
| # |
Sep 10th 2019, 08:22 |
neon1024 |
I don’t use those methods @admad |
| # |
Sep 10th 2019, 08:21 |
challgren |
But honestly how would you even build it with an array? Since its not linked to any controllers |
| # |
Sep 10th 2019, 08:20 |
challgren |
So yeah not a breaking change for me really |
| # |
Sep 10th 2019, 08:19 |
challgren |
But $this->Url I only use 5 times |
| # |
Sep 10th 2019, 08:19 |
slackebot |
#3498db; border-radius: 5px; box-sizing: border-box; cursor: pointer; text-decoration: none; font-size: 14px; font-weight: bold; margin: 0; padding: 12px 25px; text-transform: capitalize; border-color: #3498db;">View Audit</a>``` |
| # |
Sep 10th 2019, 08:19 |
challgren |
```<a href="<?= $this->Url->build(['controller' => 'EnergyAudits', 'action' => 'view', $energyAudit->id], ['fullBase' => true]) ?>" target="_blank" style="display: inline-block; color: #ffffff; background-color: #3498db; border: solid 2px |
| # |
Sep 10th 2019, 08:18 |
admad |
you are using string `'/favicon-32x32.png'` not url array :slightly_smiling_face: |
| # |
Sep 10th 2019, 08:16 |
challgren |
`<img src=“<?= $this->Url->image(‘/favicon-32x32.png’, [‘fullBase’ => true]) ?>” width=“41" height=“41” alt=“Logo” align=“center” style=“border: none; -ms-interpolation-mode: bicubic; max-width: 100%;“>` |
| # |
Sep 10th 2019, 08:16 |
challgren |
I use it one time |