# |
Jan 1st 2019, 14:09 |
challgren |
Ok so I think its related to the routes still being loaded via file. |
# |
Jan 1st 2019, 14:06 |
challgren |
Ok got it |
# |
Jan 1st 2019, 13:48 |
challgren |
Nope thats not it |
# |
Jan 1st 2019, 13:47 |
challgren |
My guess is maybe because its underscore vs dashed |
# |
Jan 1st 2019, 13:40 |
challgren |
I was struggling with the MissingRouteException when I was writing tests for my custom Mailer, I’ve posted multiple times and no one has responded or given guidance. |
# |
Jan 1st 2019, 13:36 |
slackebot |
<challgren> |
# |
Jan 1st 2019, 13:36 |
challgren |
I dont think they will, I’m not sure how to resolve the 2 failures |
# |
Jan 1st 2019, 13:35 |
dereuromark |
if the first is green and merged, rest will look fine |
# |
Jan 1st 2019, 13:18 |
challgren |
Ahh crap those didn’t go how I wanted |
# |
Jan 1st 2019, 13:16 |
challgren |
@dereuromark incoming PRs |
# |
Jan 1st 2019, 12:47 |
asdfgh |
i ran: cake bake model Agents |
# |
Jan 1st 2019, 12:46 |
asdfgh |
what does it mean? |
# |
Jan 1st 2019, 12:46 |
asdfgh |
Notice Error: Undefined index: JobMessages in [/home/dam/work/vendor/cakephp/bake/src/View/Helper/DocBlockHelper.php, line 243] |
# |
Jan 1st 2019, 12:46 |
asdfgh |
One moment while associations are detected. |
# |
Jan 1st 2019, 12:46 |
asdfgh |
hello |
# |
Jan 1st 2019, 10:35 |
challgren |
Actually the PR isn’t that big, most of the deprecations are in the tests. 8 src files. 23 tests and composer.json |
# |
Jan 1st 2019, 10:19 |
challgren |
I do have 1 failure but I think its cause your de and I’m us |
# |
Jan 1st 2019, 10:18 |
challgren |
better than the 100+ I started with |
# |
Jan 1st 2019, 10:18 |
challgren |
There’s only like 13 depreciation errors but that’s regarding typemap for JsonBehavior which I have no clue how to fix |
# |
Jan 1st 2019, 10:17 |
challgren |
Ok I’ll try to break it up into each tests -> part for yah |
# |
Jan 1st 2019, 10:17 |
dereuromark |
and try making small prs. |
# |
Jan 1st 2019, 10:17 |
challgren |
:( |
# |
Jan 1st 2019, 10:16 |
dereuromark |
thats why this is not done |
# |
Jan 1st 2019, 10:16 |
dereuromark |
yeah |
# |
Jan 1st 2019, 10:15 |
challgren |
I did notice that Inflector::slug vs Text::slug don’t return the same results |
# |
Jan 1st 2019, 10:14 |
challgren |
Ok, I’m working on a massive PR for Tools might need some of your expertise to fix a few tests |
# |
Jan 1st 2019, 10:13 |
kitcat711 |
good (first) morning (of this new year!) |
# |
Jan 1st 2019, 10:13 |
dereuromark |
True |
# |
Jan 1st 2019, 09:58 |
challgren |
Its over 3 years old so I’m not 100% sure |
# |
Jan 1st 2019, 09:55 |
challgren |
@dereuromark Is this a true deprecation in Tools or just annotation for Cake? https://github.com/dereuromark/cakephp-tools/blame/master/src/Controller/Component/CommonComponent.php#L118 |
# |
Jan 1st 2019, 09:39 |
challgren |
Morning little birdy |
# |
Jan 1st 2019, 09:38 |
birdy247 |
happy new year |
# |
Jan 1st 2019, 09:38 |
birdy247 |
Morning |
# |
Jan 1st 2019, 08:09 |
challgren |
Happy new years!!! |
# |
Jan 1st 2019, 06:10 |
NickBusey |
Happy New Years ya'll! |
# |
Jan 1st 2019, 03:52 |
Ayam |
:) |
# |
Jan 1st 2019, 03:52 |
Ayam |
hello |
# |
Jan 1st 2019, 03:20 |
challgren |
and do the checks there if you wanted |
# |
Jan 1st 2019, 03:20 |
challgren |
You could write a method on the Table to process your delete |
# |
Jan 1st 2019, 03:20 |
challgren |
The entity wont get the request data so it wont be able to do any validation |
# |
Jan 1st 2019, 03:19 |
cgtag |
okay |