# |
Jan 1st 2019, 12:46 |
asdfgh |
hello |
# |
Jan 1st 2019, 10:35 |
challgren |
Actually the PR isn’t that big, most of the deprecations are in the tests. 8 src files. 23 tests and composer.json |
# |
Jan 1st 2019, 10:19 |
challgren |
I do have 1 failure but I think its cause your de and I’m us |
# |
Jan 1st 2019, 10:18 |
challgren |
better than the 100+ I started with |
# |
Jan 1st 2019, 10:18 |
challgren |
There’s only like 13 depreciation errors but that’s regarding typemap for JsonBehavior which I have no clue how to fix |
# |
Jan 1st 2019, 10:17 |
challgren |
Ok I’ll try to break it up into each tests -> part for yah |
# |
Jan 1st 2019, 10:17 |
dereuromark |
and try making small prs. |
# |
Jan 1st 2019, 10:17 |
challgren |
:( |
# |
Jan 1st 2019, 10:16 |
dereuromark |
thats why this is not done |
# |
Jan 1st 2019, 10:16 |
dereuromark |
yeah |
# |
Jan 1st 2019, 10:15 |
challgren |
I did notice that Inflector::slug vs Text::slug don’t return the same results |
# |
Jan 1st 2019, 10:14 |
challgren |
Ok, I’m working on a massive PR for Tools might need some of your expertise to fix a few tests |
# |
Jan 1st 2019, 10:13 |
kitcat711 |
good (first) morning (of this new year!) |
# |
Jan 1st 2019, 10:13 |
dereuromark |
True |
# |
Jan 1st 2019, 09:58 |
challgren |
Its over 3 years old so I’m not 100% sure |
# |
Jan 1st 2019, 09:55 |
challgren |
@dereuromark Is this a true deprecation in Tools or just annotation for Cake? https://github.com/dereuromark/cakephp-tools/blame/master/src/Controller/Component/CommonComponent.php#L118 |
# |
Jan 1st 2019, 09:39 |
challgren |
Morning little birdy |
# |
Jan 1st 2019, 09:38 |
birdy247 |
happy new year |
# |
Jan 1st 2019, 09:38 |
birdy247 |
Morning |
# |
Jan 1st 2019, 08:09 |
challgren |
Happy new years!!! |
# |
Jan 1st 2019, 06:10 |
NickBusey |
Happy New Years ya'll! |
# |
Jan 1st 2019, 03:52 |
Ayam |
:) |
# |
Jan 1st 2019, 03:52 |
Ayam |
hello |
# |
Jan 1st 2019, 03:20 |
challgren |
and do the checks there if you wanted |
# |
Jan 1st 2019, 03:20 |
challgren |
You could write a method on the Table to process your delete |
# |
Jan 1st 2019, 03:20 |
challgren |
The entity wont get the request data so it wont be able to do any validation |
# |
Jan 1st 2019, 03:19 |
cgtag |
okay |
# |
Jan 1st 2019, 03:19 |
challgren |
That and many other things, If you need to control deletion run your checks in the controller |
# |
Jan 1st 2019, 03:19 |
cgtag |
Because of associated data? |
# |
Jan 1st 2019, 03:18 |
challgren |
Nope |
# |
Jan 1st 2019, 03:18 |
cgtag |
Seems like a business rule constraint in the domain of the model. If you make it a rule it stops all attack vectors. Wouldn't it? |
# |
Jan 1st 2019, 03:17 |
challgren |
The validation is for data being created/patched you would need to define your own access control in the controller |
# |
Jan 1st 2019, 03:16 |
cgtag |
I want to check user ownership of records. Make sure the user_id is for the current user. |
# |
Jan 1st 2019, 03:16 |
challgren |
Why would you need validation rules when deleting? |
# |
Jan 1st 2019, 03:14 |
cgtag |
When creating a custom rule. The docs say that "$rules->add(..)" only adds rules for create and update options. Does this mean that the rule is excluded from delete operations? If so, does anyone know why it's excluded? |
# |
Jan 1st 2019, 03:13 |
cgtag |
I have a question about the documentation here: https://book.cakephp.org/3.0/en/orm/validation.html#creating-a-rules-checker |
# |
Jan 1st 2019, 03:13 |
cgtag |
Happy New Year! |
# |
Jan 1st 2019, 02:23 |
wp4nuv |
Happy New Year!! |
# |
Jan 1st 2019, 00:23 |
wp4nuv |
Hello folks! On Cake2, has anyone had issues with queries that do not return all requested fields? |
# |
Dec 31st 2018, 23:33 |
murat |
Just to differentiate between an error and authorization problem when I process the ajax response. |
# |
Dec 31st 2018, 23:32 |
murat |
Anything other than 500 is fine. |