| # |
Jul 19th 2018, 12:45 |
 flavius |
also imho, if you provide a "backend" (which is what you did, this is not CLI) you should provide the assets as well |
| # |
Jul 19th 2018, 12:45 |
flavius |
i see you merged my PR regarding windows paths, you should check if it still works on your box (linux) |
| # |
Jul 19th 2018, 12:44 |
flavius |
hard to do that when the templates you provided include the missing asset's code |
| # |
Jul 19th 2018, 12:43 |
dereuromark |
i thought about providing a asset less fallback. no dependencies then. only opt in |
| # |
Jul 19th 2018, 12:43 |
flavius |
i don't know what lib you used for that |
| # |
Jul 19th 2018, 12:43 |
flavius |
but im missing the modal |
| # |
Jul 19th 2018, 12:42 |
flavius |
File uploaded https://cakesf.slack.com/files/U75U0UMR9/FBSLR88BS/image.png / https://slack-files.com/T053DPNCM-FBSLR88BS-cebfed8cec - currently i took them from my own plugin :smile: |
| # |
Jul 19th 2018, 12:41 |
flavius |
include all the assets as well (jquery and font-awesome) |
| # |
Jul 19th 2018, 12:41 |
flavius |
you should fix the layout part yourself, i can't make a PR for that |
| # |
Jul 19th 2018, 12:41 |
dereuromark |
a video or screencast |
| # |
Jul 19th 2018, 12:40 |
dereuromark |
@flavius Would be cool to have some nice looking demo once all works |
| # |
Jul 19th 2018, 12:35 |
abdualelah.mdy |
File uploaded https://cakesf.slack.com/files/UBSRFQFLP/FBUDA3XCP/-.php / https://slack-files.com/T053DPNCM-FBUDA3XCP-41cf0907e8 |
| # |
Jul 19th 2018, 12:33 |
abdualelah.mdy |
hello everyone, so i am trying to add a login functionality however $team = $this->Auth->identify(); results in FALSE even though the password is right. I tried to get the errors by this. $team->getErrors(); but it says can't for boolean. is there a way to know what it is going wrong |
| # |
Jul 19th 2018, 12:27 |
flavius |
i guess when you generate coverage for a single file it wont put it in its own directory |
| # |
Jul 19th 2018, 12:19 |
iqu |
hmm. how do i change model saveStrategy to replace at controller? |
| # |
Jul 19th 2018, 12:16 |
cakephp-slack |
@okelet Because $this->response is not available in a Helper |
| # |
Jul 19th 2018, 12:16 |
flavius |
@dereuromark Generated by php-code-coverage 5.3.2 using PHP 7.2.6 with Xdebug 2.6.0 and PHPUnit 6.5.9 at Thu Jul 19 15:10:59 EEST 2018. |
| # |
Jul 19th 2018, 12:14 |
flavius |
i have xdebug running |
| # |
Jul 19th 2018, 12:13 |
flavius |
i dont get it, the coverage file generated is not in `webroot/coverage/src/Controller/IndexController.php.html` but it is in `webroot/coverage/IndexController.php.html` |
| # |
Jul 19th 2018, 12:08 |
dereuromark |
ah we gonna tag a new release after all fixes |
| # |
Jul 19th 2018, 12:06 |
flavius |
nvm, apparently you commited the fix after release |
| # |
Jul 19th 2018, 12:03 |
flavius |
@dereuromark does coverage work for you in your test-case plugin? |
| # |
Jul 19th 2018, 11:54 |
josbeir |
instead of return |
| # |
Jul 19th 2018, 11:54 |
okelet |
or just `return $this->response->withHeader('X-Test', 'Test');` |
| # |
Jul 19th 2018, 11:54 |
josbeir |
or setResponse() |
| # |
Jul 19th 2018, 11:54 |
josbeir |
$response = $this->getResponse()->withHeader('X-Test', 'Test'); return $this->setResponse($response); |
| # |
Jul 19th 2018, 11:51 |
okelet |
and not $this->response = $this->response->withHeader('X-Test', 'Test'); ? |
| # |
Jul 19th 2018, 11:50 |
okelet |
just curious, why _View? |
| # |
Jul 19th 2018, 11:50 |
cakephp-slack |
Eventually got it to work with `$this->_View->request = $this->_View->request->withHeader('X-Test', 'Test');` |
| # |
Jul 19th 2018, 11:42 |
cakephp-slack |
Ah that makes sense, thnx! |
| # |
Jul 19th 2018, 11:40 |
dereuromark |
yeah you need to fix up response object |
| # |
Jul 19th 2018, 11:31 |
okelet |
:face_with_monocle: |
| # |
Jul 19th 2018, 11:31 |
flavius |
lol, true, isn't that for response instead of request? :slightly_smiling_face: |
| # |
Jul 19th 2018, 11:30 |
okelet |
@cakephp-slack haven't read previous messages, but are you using request instead response? |
| # |
Jul 19th 2018, 11:26 |
flavius |
i usually overwrite the request in the controller or in a component, haven't tried doing it in a view helper |
| # |
Jul 19th 2018, 11:20 |
cakephp-slack |
Could it be that my helper function is called too late? I’ts called in the default layout ctp |
| # |
Jul 19th 2018, 11:19 |
cakephp-slack |
Thank you for your answers, I’ve tried `$this->request = $this->request->withHeader('X-Test', 'Test');` but no header still. |
| # |
Jul 19th 2018, 11:07 |
admad |
Should have a beta soon though |
| # |
Jul 19th 2018, 11:07 |
neon1024 |
https://github.com/cakephp/cakephp/releases Ah yes |
| # |
Jul 19th 2018, 11:07 |
admad |
3.7 isn't released :) |
| # |
Jul 19th 2018, 11:07 |
neon1024 |
Thanks :thumbsup: |
