| # |
Jul 19th 2018, 12:14 |
 flavius |
i have xdebug running |
| # |
Jul 19th 2018, 12:13 |
flavius |
i dont get it, the coverage file generated is not in `webroot/coverage/src/Controller/IndexController.php.html` but it is in `webroot/coverage/IndexController.php.html` |
| # |
Jul 19th 2018, 12:08 |
dereuromark |
ah we gonna tag a new release after all fixes |
| # |
Jul 19th 2018, 12:06 |
flavius |
nvm, apparently you commited the fix after release |
| # |
Jul 19th 2018, 12:03 |
flavius |
@dereuromark does coverage work for you in your test-case plugin? |
| # |
Jul 19th 2018, 11:54 |
josbeir |
instead of return |
| # |
Jul 19th 2018, 11:54 |
okelet |
or just `return $this->response->withHeader('X-Test', 'Test');` |
| # |
Jul 19th 2018, 11:54 |
josbeir |
or setResponse() |
| # |
Jul 19th 2018, 11:54 |
josbeir |
$response = $this->getResponse()->withHeader('X-Test', 'Test'); return $this->setResponse($response); |
| # |
Jul 19th 2018, 11:51 |
okelet |
and not $this->response = $this->response->withHeader('X-Test', 'Test'); ? |
| # |
Jul 19th 2018, 11:50 |
okelet |
just curious, why _View? |
| # |
Jul 19th 2018, 11:50 |
cakephp-slack |
Eventually got it to work with `$this->_View->request = $this->_View->request->withHeader('X-Test', 'Test');` |
| # |
Jul 19th 2018, 11:42 |
cakephp-slack |
Ah that makes sense, thnx! |
| # |
Jul 19th 2018, 11:40 |
dereuromark |
yeah you need to fix up response object |
| # |
Jul 19th 2018, 11:31 |
okelet |
:face_with_monocle: |
| # |
Jul 19th 2018, 11:31 |
flavius |
lol, true, isn't that for response instead of request? :slightly_smiling_face: |
| # |
Jul 19th 2018, 11:30 |
okelet |
@cakephp-slack haven't read previous messages, but are you using request instead response? |
| # |
Jul 19th 2018, 11:26 |
flavius |
i usually overwrite the request in the controller or in a component, haven't tried doing it in a view helper |
| # |
Jul 19th 2018, 11:20 |
cakephp-slack |
Could it be that my helper function is called too late? I’ts called in the default layout ctp |
| # |
Jul 19th 2018, 11:19 |
cakephp-slack |
Thank you for your answers, I’ve tried `$this->request = $this->request->withHeader('X-Test', 'Test');` but no header still. |
| # |
Jul 19th 2018, 11:07 |
admad |
Should have a beta soon though |
| # |
Jul 19th 2018, 11:07 |
neon1024 |
https://github.com/cakephp/cakephp/releases Ah yes |
| # |
Jul 19th 2018, 11:07 |
admad |
3.7 isn't released :) |
| # |
Jul 19th 2018, 11:07 |
neon1024 |
Thanks :thumbsup: |
| # |
Jul 19th 2018, 11:06 |
neon1024 |
3.6.7, time for an upgrade! :) |
| # |
Jul 19th 2018, 11:06 |
neon1024 |
Ooh, I wonder what I’m running |
| # |
Jul 19th 2018, 11:06 |
admad |
We missed it in 3.6 |
| # |
Jul 19th 2018, 11:06 |
admad |
In 3.7 |
| # |
Jul 19th 2018, 11:06 |
neon1024 |
ORLY |
| # |
Jul 19th 2018, 11:06 |
admad |
@neon1024 because it has? |
| # |
Jul 19th 2018, 11:05 |
neon1024 |
Just curious but how come View hasn’t got a `getRequest()` method yet? |
| # |
Jul 19th 2018, 11:00 |
dereuromark |
;) Oh ok |
| # |
Jul 19th 2018, 10:57 |
graziel |
in sandbox i mean |
| # |
Jul 19th 2018, 10:57 |
graziel |
@dereuromark the only thing i would change is use some real names instead of 'foo', 'bar', 'xyz' : ) |
| # |
Jul 19th 2018, 10:56 |
dereuromark |
I am curious what the haters out there have to say about the framework and plugins :P https://www.reddit.com/r/PHP/comments/904bwg/beginner_tutorial_cakephp_tagging/ |
| # |
Jul 19th 2018, 10:55 |
flavius |
so `$this->request = $this->request->withHeader('X-Test', 'Test');` |
| # |
Jul 19th 2018, 10:53 |
dereuromark |
but either way, you need to reassign it as per docs: $this->request = ... - otherwise the modification is lost and useless. |
| # |
Jul 19th 2018, 10:53 |
dereuromark |
ideally your helper doesnt do that, but your controller or component. |
| # |
Jul 19th 2018, 10:53 |
dereuromark |
yeah its called immutability |
| # |
Jul 19th 2018, 10:45 |
cakephp-slack |
Is there a reason why doing `$this->request->withHeader('X-Test', 'Test');` from my custom html helper does not send the header? (CakePHP 3.6) |
| # |
Jul 19th 2018, 10:36 |
dereuromark |
The more out of the box, the cleaner IMO. |