| # |
Jun 22nd 2018, 08:09 |
 neon1024 |
Then the class just has |
| # |
Jun 22nd 2018, 08:09 |
neon1024 |
`$stationary = new Stationary();` `$stationary->save($dataArray)` perhaps |
| # |
Jun 22nd 2018, 08:08 |
neon1024 |
No, wai t asec |
| # |
Jun 22nd 2018, 08:07 |
neon1024 |
`$stationary = new Stationary(Pen $pen, Ruler $ruler);` |
| # |
Jun 22nd 2018, 08:07 |
neon1024 |
If the objects are tightly coupled, wrapping up the way they are created feels logical to me |
| # |
Jun 22nd 2018, 08:06 |
birdy247 |
Thats why I put the logic into Listeners, as it never really felt like it belonged anywhere |
| # |
Jun 22nd 2018, 08:06 |
birdy247 |
The main issue is, if a Pen needs to save a Ruler, is dpendent on some other information |
| # |
Jun 22nd 2018, 08:05 |
birdy247 |
but are you suggesting to move this into another class? |
| # |
Jun 22nd 2018, 08:05 |
birdy247 |
Everything we are saving is rpresented by a cake model |
| # |
Jun 22nd 2018, 08:05 |
birdy247 |
It feels quite complex whats happening, but I know it could be made beautfiully simple |
| # |
Jun 22nd 2018, 08:04 |
birdy247 |
continuous improvement :slightly_smiling_face: |
| # |
Jun 22nd 2018, 08:04 |
birdy247 |
no not at all |
| # |
Jun 22nd 2018, 08:04 |
neon1024 |
#braindump |
| # |
Jun 22nd 2018, 08:03 |
neon1024 |
Sorry, that sounds like a lecture reading it back. |
| # |
Jun 22nd 2018, 08:03 |
neon1024 |
Trying to write tests for events in something, Crud I think, was quite tough |
| # |
Jun 22nd 2018, 08:02 |
neon1024 |
*imho |
| # |
Jun 22nd 2018, 08:02 |
neon1024 |
Class abstractions will be ten billion times easier to test than events |
| # |
Jun 22nd 2018, 08:02 |
birdy247 |
I am keen to get things working (mvp) and ensure all tests are passing, then we can refactor |
| # |
Jun 22nd 2018, 08:01 |
birdy247 |
I agree, I expect this code to go through many iterations before we are 100% happy with it |
| # |
Jun 22nd 2018, 08:00 |
neon1024 |
If the objects are as tightly coupled as you say |
| # |
Jun 22nd 2018, 08:00 |
neon1024 |
`$stationary->hasPen() { // Drawing }` |
| # |
Jun 22nd 2018, 08:00 |
neon1024 |
Then I can work with the Collection abstraction and query it to know if certain objects exist |
| # |
Jun 22nd 2018, 08:00 |
neon1024 |
Like a collection concept |
| # |
Jun 22nd 2018, 08:00 |
neon1024 |
Stationary class which composes other class instances of Pen, Ruler, etc |
| # |
Jun 22nd 2018, 07:59 |
neon1024 |
So you might also push up to a Super class |
| # |
Jun 22nd 2018, 07:59 |
neon1024 |
I’m creating a collection of objects |
| # |
Jun 22nd 2018, 07:59 |
neon1024 |
As I’m not really creating a Pen |
| # |
Jun 22nd 2018, 07:59 |
neon1024 |
Then I could call that anywhere in my application whenever I wanted to create a Pen |
| # |
Jun 22nd 2018, 07:59 |
neon1024 |
..and leave the dependent calculation wrapped in a class or single method |
| # |
Jun 22nd 2018, 07:59 |
neon1024 |
So that I could call a method with some data, and get back the objects I need |
| # |
Jun 22nd 2018, 07:58 |
neon1024 |
If anything I would try and abstract the dependent nature into it’s own class at least |
| # |
Jun 22nd 2018, 07:58 |
neon1024 |
Yeah, but there is no need to use events for that, as you’ll surely know that when you create your Pen |
| # |
Jun 22nd 2018, 07:58 |
birdy247 |
A Ruler can only be saved after a Pen. Not all Pens create Rulers |
| # |
Jun 22nd 2018, 07:57 |
neon1024 |
Then I would think about front-loading the problem, to manage the conditional nature earlier, so I could save everything in one go |
| # |
Jun 22nd 2018, 07:57 |
neon1024 |
This scenario makes me stop and think, this is a code smell. Where does my software design stink enough that I need so many dependent events |
| # |
Jun 22nd 2018, 07:55 |
birdy247 |
I would also like Rulers to be returned if they were saved |
| # |
Jun 22nd 2018, 07:55 |
birdy247 |
actually I didnt explain this well.. A "Paper" is saved.. in the afterSave of paper, an event is emitted. This event then saves a Pen, which may then save a Ruler in the afterSave. Pens are then returned to the "Paper" in the event result |
| # |
Jun 22nd 2018, 07:53 |
neon1024 |
So if anything was observing that event it could get both entities in the event subject |
| # |
Jun 22nd 2018, 07:53 |
neon1024 |
Then I could pass both the Pen and Ruler with the event |
| # |
Jun 22nd 2018, 07:53 |
birdy247 |
ah right, which contains the Pen id? |
| # |
Jun 22nd 2018, 07:52 |
birdy247 |
I thought about stamping some guid on the records to show they are linked, and then performing a find with any records matching these guids |