| # |
Jun 13th 2018, 12:34 |
 dereuromark |
one of the most advanced and complete code sniffer packages there are. our codebase is pretty clean from a cs point of view. also helps to reduce errors as then also phpstan integrates nicely due to the doc block consistency for example. |
| # |
Jun 13th 2018, 12:33 |
dereuromark |
more or less :slightly_smiling_face: |
| # |
Jun 13th 2018, 12:28 |
josbeir |
Spryker looks interesting, yours @dereuromark? |
| # |
Jun 13th 2018, 12:20 |
dereuromark |
i recommend also to use a sniff that properly enforces this and takes care of this. Spryker package has a good one here. |
| # |
Jun 13th 2018, 12:19 |
josbeir |
]:( phpstorm |
| # |
Jun 13th 2018, 12:18 |
dereuromark |
why psr? its about the throws annotations only |
| # |
Jun 13th 2018, 12:14 |
rudy1976s |
okay I will investigate: you mean PSR support ? |
| # |
Jun 13th 2018, 12:13 |
dereuromark |
@rudy1976s fix your IDE. you should only have primary level (0) there, the default is bad IMO. |
| # |
Jun 13th 2018, 12:04 |
lorenzo |
if there isn’t open a ticket a bout it, I think it is importnat to have those kind of examples available |
| # |
Jun 13th 2018, 11:48 |
josbeir |
new authentication plugin question: is there an example of what the best way is to set up integration tests in an app that is uisng the plugin? |
| # |
Jun 13th 2018, 11:42 |
rudy1976s |
why since last update every time I comment with PHPStorm a function there is a "* @throws \Aura\Intl\Exception" ? |
| # |
Jun 13th 2018, 10:43 |
josbeir |
but probably more handy when using automated stuff |
| # |
Jun 13th 2018, 10:42 |
josbeir |
@lorenzo i don't see the whole nested entity validation part in DocumentContext working in real life situations as you can't really validate nested entities from a form using a whole new validator/index class, only nested (addNested,addNestedMany) is applicable in that scenario |
| # |
Jun 13th 2018, 10:38 |
josbeir |
@lorenzo pr up |
| # |
Jun 13th 2018, 10:28 |
dereuromark |
hah |
| # |
Jun 13th 2018, 10:22 |
lorenzo |
that’s the secret sauce |
| # |
Jun 13th 2018, 10:22 |
lorenzo |
the github user you use for jenkins needs to be admin on the repo |
| # |
Jun 13th 2018, 10:19 |
dereuromark |
Does anyone connect Jenkins CI to GitHub PRs? Our guy cant seem to get it done. I wonder what the missing piece is. Does anyone have a current "howto" for this or sth? |
| # |
Jun 13th 2018, 10:19 |
johan_hedin |
which is solving my issue .. but what about $this->request->getQueryParams() or $this->request->getQuery('foo') never works |
| # |
Jun 13th 2018, 10:18 |
johan_hedin |
and i never get solution of this issue. to work with query param i am doing this ,$this->request->getServerParams()['REQUEST_URI'] |
| # |
Jun 13th 2018, 10:17 |
johan_hedin |
this is serious issue ,, i faced thousand times.. and always raised this issue in this group .. |
| # |
Jun 13th 2018, 10:17 |
johan_hedin |
in test.php i can get "get" values.. but in cakephp blank array |
| # |
Jun 13th 2018, 10:12 |
lorenzo |
waht about `$_GET` and `$_POST` ? |
| # |
Jun 13th 2018, 10:06 |
johan_hedin |
means if i will get write simple $_REQUEST in test.php it works |
| # |
Jun 13th 2018, 10:05 |
lorenzo |
what do you mean? |
| # |
Jun 13th 2018, 10:03 |
johan_hedin |
but if i will get in core php $_REQUEST it works.. but not in cakephp |
| # |
Jun 13th 2018, 10:03 |
rudy1976s |
@lorenzo thank you |
| # |
Jun 13th 2018, 10:03 |
lorenzo |
not sure how to help you with that |
| # |
Jun 13th 2018, 10:02 |
lorenzo |
sounds like a problem with your web server not passing that data |
| # |
Jun 13th 2018, 10:02 |
johan_hedin |
pr($_GET); |
| # |
Jun 13th 2018, 10:02 |
johan_hedin |
pr($_POST); all are blank |
| # |
Jun 13th 2018, 10:02 |
johan_hedin |
pr($this->request->getQueryParams()); |
| # |
Jun 13th 2018, 10:02 |
johan_hedin |
@lorenzo : |
| # |
Jun 13th 2018, 10:01 |
lorenzo |
the plugin needs to be loaded, part of the composer class map, the class needs the right namespace and so on |
| # |
Jun 13th 2018, 10:00 |
lorenzo |
as long as it can find the class, yes |
| # |
Jun 13th 2018, 09:58 |
rudy1976s |
because I set table name in Post model and the Table object generated looks for the standard underscored version and not my custom |
| # |
Jun 13th 2018, 09:57 |
rudy1976s |
The TableLocator is aware of the table name when using like the following ? $this->Posts = TableRegistry::getTableLocator()->get('MyPlugin.Postsl); ? |
| # |
Jun 13th 2018, 09:57 |
lorenzo |
do you see anthing in `$_GET` or `$_POST`? |
| # |
Jun 13th 2018, 09:49 |
johan_hedin |
when i am accessing https://apis.domain.com/fb-pages/auth/?foo=bar |
| # |
Jun 13th 2018, 09:47 |
johan_hedin |
hi there..why my cakephp always returns blank array with $this->request->getQueryParams() or $this->request->getQuery('foo') |
| # |
Jun 13th 2018, 09:25 |
rudy1976s |
@lorenzo open issue https://github.com/cakephp/cakephp/issues/12228 |