| # |
Jun 13th 2018, 10:19 |
 dereuromark |
Does anyone connect Jenkins CI to GitHub PRs? Our guy cant seem to get it done. I wonder what the missing piece is. Does anyone have a current "howto" for this or sth? |
| # |
Jun 13th 2018, 10:19 |
johan_hedin |
which is solving my issue .. but what about $this->request->getQueryParams() or $this->request->getQuery('foo') never works |
| # |
Jun 13th 2018, 10:18 |
johan_hedin |
and i never get solution of this issue. to work with query param i am doing this ,$this->request->getServerParams()['REQUEST_URI'] |
| # |
Jun 13th 2018, 10:17 |
johan_hedin |
this is serious issue ,, i faced thousand times.. and always raised this issue in this group .. |
| # |
Jun 13th 2018, 10:17 |
johan_hedin |
in test.php i can get "get" values.. but in cakephp blank array |
| # |
Jun 13th 2018, 10:12 |
lorenzo |
waht about `$_GET` and `$_POST` ? |
| # |
Jun 13th 2018, 10:06 |
johan_hedin |
means if i will get write simple $_REQUEST in test.php it works |
| # |
Jun 13th 2018, 10:05 |
lorenzo |
what do you mean? |
| # |
Jun 13th 2018, 10:03 |
johan_hedin |
but if i will get in core php $_REQUEST it works.. but not in cakephp |
| # |
Jun 13th 2018, 10:03 |
rudy1976s |
@lorenzo thank you |
| # |
Jun 13th 2018, 10:03 |
lorenzo |
not sure how to help you with that |
| # |
Jun 13th 2018, 10:02 |
lorenzo |
sounds like a problem with your web server not passing that data |
| # |
Jun 13th 2018, 10:02 |
johan_hedin |
pr($_GET); |
| # |
Jun 13th 2018, 10:02 |
johan_hedin |
pr($_POST); all are blank |
| # |
Jun 13th 2018, 10:02 |
johan_hedin |
pr($this->request->getQueryParams()); |
| # |
Jun 13th 2018, 10:02 |
johan_hedin |
@lorenzo : |
| # |
Jun 13th 2018, 10:01 |
lorenzo |
the plugin needs to be loaded, part of the composer class map, the class needs the right namespace and so on |
| # |
Jun 13th 2018, 10:00 |
lorenzo |
as long as it can find the class, yes |
| # |
Jun 13th 2018, 09:58 |
rudy1976s |
because I set table name in Post model and the Table object generated looks for the standard underscored version and not my custom |
| # |
Jun 13th 2018, 09:57 |
rudy1976s |
The TableLocator is aware of the table name when using like the following ? $this->Posts = TableRegistry::getTableLocator()->get('MyPlugin.Postsl); ? |
| # |
Jun 13th 2018, 09:57 |
lorenzo |
do you see anthing in `$_GET` or `$_POST`? |
| # |
Jun 13th 2018, 09:49 |
johan_hedin |
when i am accessing https://apis.domain.com/fb-pages/auth/?foo=bar |
| # |
Jun 13th 2018, 09:47 |
johan_hedin |
hi there..why my cakephp always returns blank array with $this->request->getQueryParams() or $this->request->getQuery('foo') |
| # |
Jun 13th 2018, 09:25 |
rudy1976s |
@lorenzo open issue https://github.com/cakephp/cakephp/issues/12228 |
| # |
Jun 13th 2018, 09:19 |
lorenzo |
sounds likely |
| # |
Jun 13th 2018, 09:19 |
neothermic |
@lorenzo mm, as noted, the email passes both normal and deep in my testing, leading me to conclude the issue is further up the chain (as in this data came in with some whitespace unicode that made it invalid) |
| # |
Jun 13th 2018, 09:13 |
lorenzo |
@neothermic `deep` is the argument to theck mx records |
| # |
Jun 13th 2018, 09:13 |
rudy1976s |
@lorenzo ok I will open a ticket |
| # |
Jun 13th 2018, 09:11 |
neothermic |
but I'm pondering if the original data had some weird characters before/after the address |
| # |
Jun 13th 2018, 09:11 |
neothermic |
and the mx check |
| # |
Jun 13th 2018, 09:11 |
neothermic |
I have no idea if we're doing deep or not, but it passes both regexes |
| # |
Jun 13th 2018, 09:10 |
lorenzo |
even when setting the `deep` option to false? |
| # |
Jun 13th 2018, 09:08 |
neothermic |
hmm. trying to work out why an email is failing validation, but when I run through the code by-hand (inc the regexes), it should pass :| |
| # |
Jun 13th 2018, 09:06 |
lorenzo |
no, I think we just check if the thing exists at all |
| # |
Jun 13th 2018, 09:06 |
neothermic |
but then we do nothing with it? :) |
| # |
Jun 13th 2018, 09:06 |
neothermic |
oooh, hah, it's byref |
| # |
Jun 13th 2018, 09:05 |
lorenzo |
@neothermic that’s just actually pure php fun |
| # |
Jun 13th 2018, 09:04 |
lorenzo |
@josbeir ok, let me know of your progress |
| # |
Jun 13th 2018, 09:04 |
neothermic |
https://github.com/cakephp/cakephp/blob/2.x/lib/Cake/Utility/Validation.php#L475 where does `$mxhosts` come from? it's not defined _anywhere else_ |
| # |
Jun 13th 2018, 09:04 |
neothermic |
Hmm, I think I've found another fun weirdness in 2.x's codebase |
| # |
Jun 13th 2018, 09:00 |
josbeir |
i'll just go trough all bits and see whats the best way to fix it :slightly_smiling_face: |