| # |
Jun 13th 2018, 09:47 |
johan_hedin |
hi there..why my cakephp always returns blank array with $this->request->getQueryParams() or $this->request->getQuery('foo') |
| # |
Jun 13th 2018, 09:25 |
 rudy1976s |
@lorenzo open issue https://github.com/cakephp/cakephp/issues/12228 |
| # |
Jun 13th 2018, 09:19 |
lorenzo |
sounds likely |
| # |
Jun 13th 2018, 09:19 |
neothermic |
@lorenzo mm, as noted, the email passes both normal and deep in my testing, leading me to conclude the issue is further up the chain (as in this data came in with some whitespace unicode that made it invalid) |
| # |
Jun 13th 2018, 09:13 |
lorenzo |
@neothermic `deep` is the argument to theck mx records |
| # |
Jun 13th 2018, 09:13 |
rudy1976s |
@lorenzo ok I will open a ticket |
| # |
Jun 13th 2018, 09:11 |
neothermic |
but I'm pondering if the original data had some weird characters before/after the address |
| # |
Jun 13th 2018, 09:11 |
neothermic |
and the mx check |
| # |
Jun 13th 2018, 09:11 |
neothermic |
I have no idea if we're doing deep or not, but it passes both regexes |
| # |
Jun 13th 2018, 09:10 |
lorenzo |
even when setting the `deep` option to false? |
| # |
Jun 13th 2018, 09:08 |
neothermic |
hmm. trying to work out why an email is failing validation, but when I run through the code by-hand (inc the regexes), it should pass :| |
| # |
Jun 13th 2018, 09:06 |
lorenzo |
no, I think we just check if the thing exists at all |
| # |
Jun 13th 2018, 09:06 |
neothermic |
but then we do nothing with it? :) |
| # |
Jun 13th 2018, 09:06 |
neothermic |
oooh, hah, it's byref |
| # |
Jun 13th 2018, 09:05 |
lorenzo |
@neothermic that’s just actually pure php fun |
| # |
Jun 13th 2018, 09:04 |
lorenzo |
@josbeir ok, let me know of your progress |
| # |
Jun 13th 2018, 09:04 |
neothermic |
https://github.com/cakephp/cakephp/blob/2.x/lib/Cake/Utility/Validation.php#L475 where does `$mxhosts` come from? it's not defined _anywhere else_ |
| # |
Jun 13th 2018, 09:04 |
neothermic |
Hmm, I think I've found another fun weirdness in 2.x's codebase |
| # |
Jun 13th 2018, 09:00 |
josbeir |
i'll just go trough all bits and see whats the best way to fix it :slightly_smiling_face: |
| # |
Jun 13th 2018, 08:58 |
josbeir |
the whole validation => context is pretty complex, haven't looked at it in great detail |
| # |
Jun 13th 2018, 08:58 |
josbeir |
i'm not sure, thats the problem :) |
| # |
Jun 13th 2018, 08:57 |
josbeir |
for me yes, but dont think it should work like that |
| # |
Jun 13th 2018, 08:56 |
lorenzo |
would the result be desirable to you? |
| # |
Jun 13th 2018, 08:56 |
lorenzo |
what happens if you sacrifice one of the conflicting features? |
| # |
Jun 13th 2018, 08:55 |
lorenzo |
I’m aware of the ticket |
| # |
Jun 13th 2018, 08:53 |
josbeir |
(the issue is in the DocumentContext::error method that doesn't take care of nested paths) |
| # |
Jun 13th 2018, 08:52 |
josbeir |
hope i'm not to cryptic with the description :) |
| # |
Jun 13th 2018, 08:52 |
josbeir |
and i'm not sure how to 'fix' this correctly, that both use cases work correctly |
| # |
Jun 13th 2018, 08:51 |
josbeir |
nested validation rules on the current form context dont work currently, but in test cases they do work when the sub entity has errors, the problem is that nested validation sets the errors of the sub entity on the parent context (or something like that) |
| # |
Jun 13th 2018, 08:50 |
josbeir |
@lorenzo i'm struggling a bit with the formContext and nested validation rules in the ES plugin, maybe you could shed a light |
| # |
Jun 13th 2018, 08:49 |
lorenzo |
please open a ticket about it |
| # |
Jun 13th 2018, 08:49 |
lorenzo |
that’s an interesting side effect |
| # |
Jun 13th 2018, 08:49 |
josbeir |
morning all |
| # |
Jun 13th 2018, 08:49 |
lorenzo |
the newer time class has support for microseconds |
| # |
Jun 13th 2018, 08:48 |
lorenzo |
ah, yes |
| # |
Jun 13th 2018, 08:46 |
rudy1976s |
@lorenzo it seems that setting SQLServer column type from "datetime" to "datetime2" fixed the problem: does the timestamp behavior changes the way it handles data in the last version of cake ? Datetime2 differs from Datetime in several ways , first of all ability to store bigger information in lesser space reading from Microsoft official docs and the date stored in DB is like the following : 2018-06-13 10:40:43.0000000 |
| # |
Jun 13th 2018, 08:28 |
slackebot |
Action: admad put on "Another brick in the wall" |
| # |
Jun 13th 2018, 08:28 |
admad |
i guess it's spelled "laddie" |
| # |
Jun 13th 2018, 08:26 |
admad |
moin, get to work laddy :slightly_smiling_face: |
| # |
Jun 13th 2018, 08:23 |
neon1024 |
Morning |
| # |
Jun 13th 2018, 08:22 |
lorenzo |
so we can fix it |