# |
Jun 13th 2018, 09:06 |
lorenzo |
no, I think we just check if the thing exists at all |
# |
Jun 13th 2018, 09:06 |
neothermic |
but then we do nothing with it? :) |
# |
Jun 13th 2018, 09:06 |
neothermic |
oooh, hah, it's byref |
# |
Jun 13th 2018, 09:05 |
lorenzo |
@neothermic that’s just actually pure php fun |
# |
Jun 13th 2018, 09:04 |
lorenzo |
@josbeir ok, let me know of your progress |
# |
Jun 13th 2018, 09:04 |
neothermic |
https://github.com/cakephp/cakephp/blob/2.x/lib/Cake/Utility/Validation.php#L475 where does `$mxhosts` come from? it's not defined _anywhere else_ |
# |
Jun 13th 2018, 09:04 |
neothermic |
Hmm, I think I've found another fun weirdness in 2.x's codebase |
# |
Jun 13th 2018, 09:00 |
josbeir |
i'll just go trough all bits and see whats the best way to fix it :slightly_smiling_face: |
# |
Jun 13th 2018, 08:58 |
josbeir |
the whole validation => context is pretty complex, haven't looked at it in great detail |
# |
Jun 13th 2018, 08:58 |
josbeir |
i'm not sure, thats the problem :) |
# |
Jun 13th 2018, 08:57 |
josbeir |
for me yes, but dont think it should work like that |
# |
Jun 13th 2018, 08:56 |
lorenzo |
would the result be desirable to you? |
# |
Jun 13th 2018, 08:56 |
lorenzo |
what happens if you sacrifice one of the conflicting features? |
# |
Jun 13th 2018, 08:55 |
lorenzo |
I’m aware of the ticket |
# |
Jun 13th 2018, 08:53 |
josbeir |
(the issue is in the DocumentContext::error method that doesn't take care of nested paths) |
# |
Jun 13th 2018, 08:52 |
josbeir |
hope i'm not to cryptic with the description :) |
# |
Jun 13th 2018, 08:52 |
josbeir |
and i'm not sure how to 'fix' this correctly, that both use cases work correctly |
# |
Jun 13th 2018, 08:51 |
josbeir |
nested validation rules on the current form context dont work currently, but in test cases they do work when the sub entity has errors, the problem is that nested validation sets the errors of the sub entity on the parent context (or something like that) |
# |
Jun 13th 2018, 08:50 |
josbeir |
@lorenzo i'm struggling a bit with the formContext and nested validation rules in the ES plugin, maybe you could shed a light |
# |
Jun 13th 2018, 08:49 |
lorenzo |
please open a ticket about it |
# |
Jun 13th 2018, 08:49 |
lorenzo |
that’s an interesting side effect |
# |
Jun 13th 2018, 08:49 |
josbeir |
morning all |
# |
Jun 13th 2018, 08:49 |
lorenzo |
the newer time class has support for microseconds |
# |
Jun 13th 2018, 08:48 |
lorenzo |
ah, yes |
# |
Jun 13th 2018, 08:46 |
rudy1976s |
@lorenzo it seems that setting SQLServer column type from "datetime" to "datetime2" fixed the problem: does the timestamp behavior changes the way it handles data in the last version of cake ? Datetime2 differs from Datetime in several ways , first of all ability to store bigger information in lesser space reading from Microsoft official docs and the date stored in DB is like the following : 2018-06-13 10:40:43.0000000 |
# |
Jun 13th 2018, 08:28 |
slackebot |
Action: admad put on "Another brick in the wall" |
# |
Jun 13th 2018, 08:28 |
admad |
i guess it's spelled "laddie" |
# |
Jun 13th 2018, 08:26 |
admad |
moin, get to work laddy :slightly_smiling_face: |
# |
Jun 13th 2018, 08:23 |
neon1024 |
Morning |
# |
Jun 13th 2018, 08:22 |
lorenzo |
so we can fix it |
# |
Jun 13th 2018, 08:22 |
lorenzo |
try to create a small reproducible example of your problem and open a ticket about it |
# |
Jun 13th 2018, 07:44 |
rudy1976s |
same of all |
# |
Jun 13th 2018, 07:44 |
rudy1976s |
same basecode |
# |
Jun 13th 2018, 07:44 |
rudy1976s |
this problem afflicts only SQLServer while the upgrade does not create issue on mysql server |
# |
Jun 13th 2018, 07:42 |
rudy1976s |
both in create and edit |
# |
Jun 13th 2018, 07:41 |
rudy1976s |
and if I put the timestamo behavior off from the table no error |
# |
Jun 13th 2018, 07:40 |
rudy1976s |
this happened only after update to 3.6.5 |
# |
Jun 13th 2018, 07:40 |
rudy1976s |
Hi lorenzo |
# |
Jun 13th 2018, 07:38 |
lorenzo |
or maybe you have a custom getter for the property in the entity |
# |
Jun 13th 2018, 07:38 |
lorenzo |
Likely because you are setting the field directly in the entity |
# |
Jun 13th 2018, 07:38 |
lorenzo |
You are saving a string as a date |