| # |
Jul 14th 2017, 14:33 |
 neon1024 |
I haven’t, but I’d certainly mock the response from Facebook. As you don’t want to have your tests hit the live remote API |
| # |
Jul 14th 2017, 14:27 |
ericadeefox |
I'll ask it again tho as the day gets started: has anyone got any experience running integration tests while using Facebook's PHP SDK? |
| # |
Jul 14th 2017, 14:26 |
diego182 |
if i change the strategy to `select` its way faster, but not shure if is the best option, maybe if someone advise me doing it, i would fell more confortable about it |
| # |
Jul 14th 2017, 14:25 |
johan |
Oh, right, I see your original post now :S |
| # |
Jul 14th 2017, 14:24 |
diego182 |
@johan @hmlc this query is auto generated on pagination component, i dont know how to change it, i guess its needed to make the pagination logic |
| # |
Jul 14th 2017, 14:23 |
jeremyharris |
@awi I think it would be best to re-think the process though, perhaps a validation error or something would be more appropriate |
| # |
Jul 14th 2017, 14:21 |
jeremyharris |
or, put the logic elsewhere |
| # |
Jul 14th 2017, 14:21 |
johan |
@diego182 That appears to be doing a full table scan, because there's nothing limiting the results from MessageBoard. |
| # |
Jul 14th 2017, 14:21 |
jeremyharris |
@awi marshaling has nothing to do with saving really, so throwing an exception would work |
| # |
Jul 14th 2017, 14:21 |
ericadeefox |
The Great Facebook SDK Catastrophe of 2017: today I am using mockbuilder for the first time! |
| # |
Jul 14th 2017, 14:20 |
awi |
or should I throw some exception? |
| # |
Jul 14th 2017, 14:19 |
awi |
like false? |
| # |
Jul 14th 2017, 14:19 |
awi |
If there is something happening in beforemarshall and I want to stop saving this bunch of data, what do I need to return? |
| # |
Jul 14th 2017, 14:12 |
neon1024 |
Guess I need to make a whole bunch of exception classes now then |
| # |
Jul 14th 2017, 14:07 |
hmic |
like i said: you import it to the current namespace. this is: you create it in your current scope. so you can distinguish it from the others. it's perfectly fine that it's the same thing, you just need to be able to scope it |
| # |
Jul 14th 2017, 14:06 |
hmic |
yes |
| # |
Jul 14th 2017, 14:06 |
neon1024 |
So it’s about scope |
| # |
Jul 14th 2017, 14:06 |
hmic |
you would want to catch only invalid arguments in your current namespace, not things that go wrong somewhere else |
| # |
Jul 14th 2017, 14:06 |
neon1024 |
Guess it’s a use-case I’ve not encountered yet |
| # |
Jul 14th 2017, 14:06 |
neon1024 |
Not sure why I’d ever want to do that :slightly_smiling_face: |
| # |
Jul 14th 2017, 14:06 |
hmic |
exactly |
| # |
Jul 14th 2017, 14:05 |
neon1024 |
So you mean I could catch \MyThingy\Exception in a different way to \Exception? |
| # |
Jul 14th 2017, 14:05 |
neon1024 |
Sounds like I’ve got a gap in my knowledge here |
| # |
Jul 14th 2017, 14:04 |
hmic |
that only works this way |
| # |
Jul 14th 2017, 14:04 |
neon1024 |
The only possible reason I can think of is that if you want to change your exception, you don’t need to change it in all the places you’ve implemented it |
| # |
Jul 14th 2017, 14:04 |
hmic |
because you might not want to catch any invalid argument in the chain of things, but only the one in your namespace |
| # |
Jul 14th 2017, 14:04 |
neon1024 |
I don’t see the point of doing that when \InvalidArgumentException works just fine |
| # |
Jul 14th 2017, 14:03 |
hmic |
why you'd do that: import it to the current namespace. |
| # |
Jul 14th 2017, 14:03 |
neon1024 |
No, that’s me selecting the root one because I don’t see the point of the others |
| # |
Jul 14th 2017, 14:03 |
hmic |
obviously the autocomplete is smart enough to sujggest the current namespace first |
| # |
Jul 14th 2017, 14:03 |
neon1024 |
Still doesn’t answer my question. |
| # |
Jul 14th 2017, 14:03 |
hmic |
neon1024: yes, you decide the correct namespace to use |
| # |
Jul 14th 2017, 14:02 |
neon1024 |
Great @hmic, then you end up here, http://i.imgur.com/3fnP1wp.png |
| # |
Jul 14th 2017, 14:02 |
spencdev |
Hmm, I had this same issue myself about 3 days ago. When I created an index for the column it went away |
| # |
Jul 14th 2017, 14:02 |
hmic |
additionally, you dont need the joins on the count at all if you do not filter anyways. just drop them! |
| # |
Jul 14th 2017, 14:01 |
hmic |
there is going something completely wrong, as 400k records is really not much |
| # |
Jul 14th 2017, 14:00 |
hmic |
diego182: check if they get used by telling mysql to explain your queries |
| # |
Jul 14th 2017, 14:00 |
hmic |
neon1024: it imports it to the namespace |
| # |
Jul 14th 2017, 14:00 |
diego182 |
yes, it does |
| # |
Jul 14th 2017, 13:58 |
spencdev |
@diego182 does your table have an index for the joins? |
| # |
Jul 14th 2017, 13:52 |
diego182 |
to have a faster query |
