| # |
Jul 3rd 2017, 15:40 |
 jeremyharris |
ouch. as an american, I take offense. our shitty datetime format is the corner stone of our shitty democracy! |
| # |
Jul 3rd 2017, 15:38 |
ndm |
Well, that's just a matter of configuration, my datetimes are using non-retarded formatting ;) But yeah, as far as debug kit concerned, it's pretty much a non-issue. |
| # |
Jul 3rd 2017, 15:36 |
inoas |
neon1024 :+1: |
| # |
Jul 3rd 2017, 15:36 |
inoas |
ndm I am saying its a non-issue. If we want to be inclusive we have to fix default datetimes to be ISO instead of english-american :p |
| # |
Jul 3rd 2017, 15:36 |
neon1024 |
Perhaps an RFC ticket to remove the left overs? |
| # |
Jul 3rd 2017, 15:35 |
ndm |
@ionas Ok, it read as if you thought I'd refer to the source... I'd tend to agree that it seems that no one really seems to want it translated. |
| # |
Jul 3rd 2017, 15:35 |
neon1024 |
I guess just an omission @ndm :slightly_smiling_face: |
| # |
Jul 3rd 2017, 15:35 |
neon1024 |
:coffee: |
| # |
Jul 3rd 2017, 15:34 |
inoas |
anyway I will stfu |
| # |
Jul 3rd 2017, 15:34 |
inoas |
and we cannot get the doc blocks translated reasonably |
| # |
Jul 3rd 2017, 15:34 |
inoas |
what I am saying is that doc blocks matter the most, then book documentation, then at some point debug kit locales ;-P |
| # |
Jul 3rd 2017, 15:34 |
neon1024 |
Translations !== Source code |
| # |
Jul 3rd 2017, 15:34 |
neon1024 |
Sigh, you’re stuck on source code today inoas |
| # |
Jul 3rd 2017, 15:33 |
inoas |
neon1024 I would welcome to have uuids in source code comments and some kind of uber-tool that translates all doc blocks on the fly :p |
| # |
Jul 3rd 2017, 15:33 |
neon1024 |
If they help make things more accessible for non-english speakers |
| # |
Jul 3rd 2017, 15:33 |
neon1024 |
But for translations, any contributed translations are a positive thing in my book :slightly_smiling_face: |
| # |
Jul 3rd 2017, 15:33 |
inoas |
ndm I know. I am just saying - as a "german motherlanguage dude" - that I could live without those and because no one complained so far maybe we all can and reduce maintainance/costs |
| # |
Jul 3rd 2017, 15:32 |
inoas |
Anyway you don't have to agree. I rather have a consistent output that is English than outdated locales - luckly this is in bootstrap.php ;) ini_set('intl.default_locale', Configure::read('App.defaultLocale')) (so we all have by default some kind of English to talk to each other) |
| # |
Jul 3rd 2017, 15:32 |
ndm |
@ionas I'm not referring to the source code, but to the translation files that ship with the plugin :slightly_smiling_face: |
| # |
Jul 3rd 2017, 15:32 |
neon1024 |
I had a good chat with @brettl and @steinkel about non-english language source code. If I recall the consensus was much the same as yours @inoas - that English source code was easiest for collaboration |
| # |
Jul 3rd 2017, 15:31 |
neon1024 |
Just chance to have been born in an English speaking country, certainly |
| # |
Jul 3rd 2017, 15:30 |
inoas |
you are not glad because you are not affected anyway :p |
| # |
Jul 3rd 2017, 15:30 |
inoas |
and that no one noticed so far tells a story |
| # |
Jul 3rd 2017, 15:30 |
neon1024 |
Well, then I am glad it is not your plugin :slightly_smiling_face: |
| # |
Jul 3rd 2017, 15:30 |
inoas |
that includes debugkit IMHO as it is pretty low level |
| # |
Jul 3rd 2017, 15:30 |
inoas |
The point I am making is: for collaboration it is probably better to stick to one language |
| # |
Jul 3rd 2017, 15:30 |
neon1024 |
Well ndm wasn’t talking about source code |
| # |
Jul 3rd 2017, 15:30 |
inoas |
the doc blocks at least ,-) |
| # |
Jul 3rd 2017, 15:29 |
inoas |
I mean the SOURCE ;-) not the messages |
| # |
Jul 3rd 2017, 15:29 |
neon1024 |
Pretty sure all the core messages are wrapped with `__()` |
| # |
Jul 3rd 2017, 15:29 |
inoas |
;-) |
| # |
Jul 3rd 2017, 15:29 |
neon1024 |
You can if you want to :slightly_smiling_face: |
| # |
Jul 3rd 2017, 15:29 |
inoas |
why not translate the cakephp source code to french? |
| # |
Jul 3rd 2017, 15:29 |
neon1024 |
I would think debugging something in your native language would make life much easier |
| # |
Jul 3rd 2017, 15:27 |
neon1024 |
Why would translating something be bad? |
| # |
Jul 3rd 2017, 15:27 |
inoas |
ndm why was DebugKit translated in the first place? Not sure that's a good thing tbh |
| # |
Jul 3rd 2017, 15:25 |
ndm |
@admad Well it seems so... just wanted to make sure that I'm looking at an actual "bug" :slightly_smiling_face: |
| # |
Jul 3rd 2017, 15:19 |
admad |
@ndm guess no one else has taken an issue either :) |
| # |
Jul 3rd 2017, 15:15 |
ndm |
I never noticed it, as I never took an issue with DebugKit being shown in english only, but it looks like DebugKits `Locale` folders haven't been upgraded to 3.x? `LC_MESSAGES` isn't been used anymore, or is it? https://github.com/cakephp/debug_kit/tree/3.10.4/src/Locale |
| # |
Jul 3rd 2017, 15:12 |
dereuromark |
like a property being set |
| # |
Jul 3rd 2017, 15:12 |
dereuromark |
most traits that need it have some internal state check etc |