| # |
Apr 26th 2017, 10:48 |
inoas |
https://github.com/ADmad/cakephp-i18n/blob/master/src/Routing/Filter/I18nFilter.php |
| # |
Apr 26th 2017, 10:48 |
inoas |
its still using dispatch filters (so middleware) |
| # |
Apr 26th 2017, 10:46 |
 dereuromark |
checkout the Admad/I18n plugin, I think it contains a few ideas on that |
| # |
Apr 26th 2017, 10:45 |
dereuromark |
I still vote to keep them, the visibility part is super transparent with them, especially without code IDE highlighting in diffs and other sources. |
| # |
Apr 26th 2017, 10:45 |
inoas |
should routing be done in middleware? |
| # |
Apr 26th 2017, 10:45 |
inoas |
is that something that "should" be done in middleware? |
| # |
Apr 26th 2017, 10:45 |
inoas |
what's the best way to read browser locale and session locale from routes? |
| # |
Apr 26th 2017, 10:44 |
dereuromark |
Many find them super useful. |
| # |
Apr 26th 2017, 10:44 |
inoas |
^_^ |
| # |
Apr 26th 2017, 10:44 |
dereuromark |
who said we cant have them? They are perfectly legal and fine - always have been, always will be. |
| # |
Apr 26th 2017, 10:44 |
dereuromark |
but that is to be expected the way they did things |
| # |
Apr 26th 2017, 10:43 |
dereuromark |
inoas: lol, if you love consistency you must hate psr2 :P |
| # |
Apr 26th 2017, 10:42 |
inoas |
so I like the underscores, but if we can't have them they should ALL be removed in 4.x ;) |
| # |
Apr 26th 2017, 10:42 |
inoas |
but anyway, I love consistency and pretty much otherwise I am *shrug* |
| # |
Apr 26th 2017, 10:41 |
inoas |
just classes and non-anon functions |
| # |
Apr 26th 2017, 10:41 |
inoas |
and all the other statements neither |
| # |
Apr 26th 2017, 10:41 |
inoas |
that's weirdo |
| # |
Apr 26th 2017, 10:41 |
inoas |
but not anon functions |
| # |
Apr 26th 2017, 10:41 |
inoas |
I have more gripes with functions having { on a new line |
| # |
Apr 26th 2017, 10:40 |
Neon1024 |
Very diplomatic! |
| # |
Apr 26th 2017, 10:40 |
Neon1024 |
Haha |
| # |
Apr 26th 2017, 10:40 |
inoas |
I can see reasons for both :p |
| # |
Apr 26th 2017, 10:40 |
Neon1024 |
I mean tabs are great right? |
| # |
Apr 26th 2017, 10:39 |
inoas |
:) |
| # |
Apr 26th 2017, 10:39 |
inoas |
<3 |
| # |
Apr 26th 2017, 10:39 |
inoas |
haha |
| # |
Apr 26th 2017, 10:39 |
Neon1024 |
:p |
| # |
Apr 26th 2017, 10:39 |
Neon1024 |
It’s not my fault you’re wrong. |
| # |
Apr 26th 2017, 10:39 |
Neon1024 |
Yeah, both positions are immovable |
| # |
Apr 26th 2017, 10:39 |
inoas |
then do that, but do not impose others to be forced to adapt tools their dislike strongly |
| # |
Apr 26th 2017, 10:39 |
Neon1024 |
Other people would rather put that into the code |
| # |
Apr 26th 2017, 10:39 |
inoas |
that does not help vim users much |
| # |
Apr 26th 2017, 10:39 |
Neon1024 |
I prefer to change my tools rather than my code |
| # |
Apr 26th 2017, 10:39 |
inoas |
I am okay with adding type hinting stuff that helps ides |
| # |
Apr 26th 2017, 10:38 |
inoas |
it's all good! |
| # |
Apr 26th 2017, 10:38 |
Neon1024 |
Which is why I did say to birdy that it’s my opinion |
| # |
Apr 26th 2017, 10:38 |
inoas |
sure it is ;) |
| # |
Apr 26th 2017, 10:38 |
Neon1024 |
¯\_(ツ)_/¯ |
| # |
Apr 26th 2017, 10:37 |
Neon1024 |
Code style is always contentious |
| # |
Apr 26th 2017, 10:37 |
inoas |
there is nothinig bad about that |
| # |
Apr 26th 2017, 10:37 |
Neon1024 |
It’s easier to change your IDE than your codebase |