| # |
Apr 26th 2017, 10:41 |
inoas |
just classes and non-anon functions |
| # |
Apr 26th 2017, 10:41 |
inoas |
and all the other statements neither |
| # |
Apr 26th 2017, 10:41 |
inoas |
that's weirdo |
| # |
Apr 26th 2017, 10:41 |
inoas |
but not anon functions |
| # |
Apr 26th 2017, 10:41 |
inoas |
I have more gripes with functions having { on a new line |
| # |
Apr 26th 2017, 10:40 |
Neon1024 |
Very diplomatic! |
| # |
Apr 26th 2017, 10:40 |
Neon1024 |
Haha |
| # |
Apr 26th 2017, 10:40 |
inoas |
I can see reasons for both :p |
| # |
Apr 26th 2017, 10:40 |
Neon1024 |
I mean tabs are great right? |
| # |
Apr 26th 2017, 10:39 |
inoas |
:) |
| # |
Apr 26th 2017, 10:39 |
inoas |
<3 |
| # |
Apr 26th 2017, 10:39 |
inoas |
haha |
| # |
Apr 26th 2017, 10:39 |
Neon1024 |
:p |
| # |
Apr 26th 2017, 10:39 |
Neon1024 |
It’s not my fault you’re wrong. |
| # |
Apr 26th 2017, 10:39 |
Neon1024 |
Yeah, both positions are immovable |
| # |
Apr 26th 2017, 10:39 |
inoas |
then do that, but do not impose others to be forced to adapt tools their dislike strongly |
| # |
Apr 26th 2017, 10:39 |
Neon1024 |
Other people would rather put that into the code |
| # |
Apr 26th 2017, 10:39 |
inoas |
that does not help vim users much |
| # |
Apr 26th 2017, 10:39 |
Neon1024 |
I prefer to change my tools rather than my code |
| # |
Apr 26th 2017, 10:39 |
inoas |
I am okay with adding type hinting stuff that helps ides |
| # |
Apr 26th 2017, 10:38 |
inoas |
it's all good! |
| # |
Apr 26th 2017, 10:38 |
Neon1024 |
Which is why I did say to birdy that it’s my opinion |
| # |
Apr 26th 2017, 10:38 |
inoas |
sure it is ;) |
| # |
Apr 26th 2017, 10:38 |
Neon1024 |
¯\_(ツ)_/¯ |
| # |
Apr 26th 2017, 10:37 |
Neon1024 |
Code style is always contentious |
| # |
Apr 26th 2017, 10:37 |
inoas |
there is nothinig bad about that |
| # |
Apr 26th 2017, 10:37 |
Neon1024 |
It’s easier to change your IDE than your codebase |
| # |
Apr 26th 2017, 10:37 |
Neon1024 |
Forming good code should paramount though |
| # |
Apr 26th 2017, 10:37 |
inoas |
Code Style should not impose IDE as a hard requirement |
| # |
Apr 26th 2017, 10:37 |
inoas |
anyway, I suspect it will get removed for 4.x |
| # |
Apr 26th 2017, 10:37 |
Neon1024 |
You tools should not define your code style. |
| # |
Apr 26th 2017, 10:36 |
inoas |
it is also very clear to see when calling |
| # |
Apr 26th 2017, 10:36 |
inoas |
Neon1024: The core teams excuse is that it’s easier to see in Vim <= I am with the core team here |
| # |
Apr 26th 2017, 10:35 |
inoas |
can I somehow sane access the user's browser language (request object) in my custom router? |
| # |
Apr 26th 2017, 10:26 |
 birdy247 |
but then I am stuck |
| # |
Apr 26th 2017, 10:26 |
birdy247 |
I then pass the entity back |
| # |
Apr 26th 2017, 10:26 |
birdy247 |
so my class is doing the ->set('property', arrayOfValues) |
| # |
Apr 26th 2017, 10:25 |
birdy247 |
ok |
| # |
Apr 26th 2017, 10:25 |
Neon1024 |
Well if you’re parsing associations you can use foreach ($table->associations() as $type => $name) { iirc |
| # |
Apr 26th 2017, 10:24 |
birdy247 |
but I cant save |
| # |
Apr 26th 2017, 10:24 |
birdy247 |
its updating the entities |