| # |
Apr 26th 2010, 17:31 |
ADmad |
glad to have you onboard, the help was much needed :) |
| # |
Apr 26th 2010, 17:30 |
ADmad |
yup |
| # |
Apr 26th 2010, 17:29 |
nurvzy |
Indeed, just like any author, if you take pride in your work you pour a bit of yourself into your work. Critisicm on that work can feel like judgement on a personal level even though its truely not. |
| # |
Apr 26th 2010, 17:27 |
ADmad |
s/and not/are not |
| # |
Apr 26th 2010, 17:27 |
ADmad |
in my experience most authors and not as receptive to feedback. either they don't check the messages or don't want to bother improving their code or maybe take is as a insult when asked to make chnage :P which is why i kinda lost interest in moderating. |
| # |
Apr 26th 2010, 17:24 |
nurvzy |
Indeed, it was valuable feedback like you provided that helped push me to produce better, cleaner, and expandable code. This is why I love idea behind the Bakery. |
| # |
Apr 26th 2010, 17:20 |
ADmad |
nice |
| # |
Apr 26th 2010, 17:20 |
nurvzy |
I believe I will be updating that article, since I've released a few more version since then. |
| # |
Apr 26th 2010, 17:19 |
ADmad |
yeah just found it. |
| # |
Apr 26th 2010, 17:19 |
nurvzy |
http://bakery.cakephp.org/articles/view/paypal-ipn-instant-payment-notification-plugin-complete-with-paypalhelper |
| # |
Apr 26th 2010, 17:19 |
ADmad |
ah i knew your nick looked familiar |
| # |
Apr 26th 2010, 17:19 |
nurvzy |
ADmad: that is correct. Paypal plugin,. =) |
| # |
Apr 26th 2010, 17:17 |
ADmad |
nurvzy: iirc i had moderated a paypal datasource/plugin article you had posted. does my memory serve me right ? |
| # |
Apr 26th 2010, 17:16 |
ADmad |
no probs, keep'em coming :) |
| # |
Apr 26th 2010, 17:15 |
nurvzy |
Ok, I think I have enough to leave constructive feedback. Thanks ADmad for being my soundboard. =) |
| # |
Apr 26th 2010, 17:14 |
nurvzy |
I used the ajax helper alot before 1.3 came out and blew it's socks off. The article was written for 1.2 so the usage of the ajax helper seems A-OK to me. |
| # |
Apr 26th 2010, 17:13 |
nurvzy |
Well there are a few issues. One, he's modifing the core to include an extra paramter in observeField. It would be better if he just extended the AjaxHelper and applied his own logic IMHO. |
| # |
Apr 26th 2010, 17:12 |
ADmad |
i have never even used a js/ajax helper myself :) |
| # |
Apr 26th 2010, 17:11 |
ADmad |
for the article code content itself also i don't have an opinion. in general i don't care about JS related posts. they dont have much to do with cakephp |
| # |
Apr 26th 2010, 17:10 |
nurvzy |
Ok, will do |
| # |
Apr 26th 2010, 17:10 |
nurvzy |
Alright, well assuming we overlook the spelling/grammar issues and condesending tone, the article content seems OK. Thoughts? |
| # |
Apr 26th 2010, 17:09 |
ADmad |
leave him some feedback and see if you can get him to improve on it |
| # |
Apr 26th 2010, 17:07 |
nurvzy |
Ah, I see your point. |
| # |
Apr 26th 2010, 17:07 |
nurvzy |
Indeed, personally, if the poster doesn't have the respect for the article to read through it once/twice before submitting it shouldn't be published (ie feedback given). |
| # |
Apr 26th 2010, 17:07 |
ADmad |
english might not be the first langauge of that person and since bakery isnt internationalized yet we leave him no choice but to submit in english |
| # |
Apr 26th 2010, 17:06 |
ADmad |
hmm thats kind of a grey area i would say :) |
| # |
Apr 26th 2010, 17:06 |
nurvzy |
(other than code presentation) |
| # |
Apr 26th 2010, 17:05 |
nurvzy |
Or do we just focus on content, regardless of presentation? |
| # |
Apr 26th 2010, 17:05 |
nurvzy |
There are many gramatical and spelling errors througout the entire article. Is that a relavant feedback to give and hold publication? |
| # |
Apr 26th 2010, 17:04 |
ADmad |
. |
| # |
Apr 26th 2010, 16:59 |
nurvzy |
Hi, anyone around? I have a moderation question regarding the pending article http://bakery.cakephp.org/articles/view/better-use-of-the-observefield-method . |
| # |
Apr 26th 2010, 11:56 |
nurvzy |
Yuck, I hate seeing apps like that. One of my clients handed me an app and said "fix it" the previous coder had no idea what he was doing. mysql functions all over the place, mainly in the views. Why even use a framework if you're going to do that?! |
| # |
Apr 26th 2010, 11:55 |
ADmad |
yup |
| # |
Apr 26th 2010, 11:55 |
nurvzy |
Ok, thanks. I'm currently looking at http://bakery.cakephp.org/articles/view/image-resize-and-crop-on-the-fly and am formatting the Author PM to include suggestions for HTML helper as the crop function does not return a valid img tag. Would you agree? |
| # |
Apr 26th 2010, 11:54 |
ADmad |
and just take care that the code is of decent quality. for instance a while back a wordpress helper was published which was absolute crap. fetching data from tables using mysql_* functions. shouldn't even bother giving a response on such stuff imo. |
| # |
Apr 26th 2010, 11:53 |
ADmad |
nah no such priority, i would just give priority to the ones which need least changes to get published :) |
| # |
Apr 26th 2010, 11:52 |
nurvzy |
oldest* too :) |
| # |
Apr 26th 2010, 11:52 |
nurvzy |
Will do. As a newbie mod, Is there anything I should know that isn't documented? I've read through the guidelines as well as coding standards in trac. For instance, is there a priority order for the queue? oldets->newest? |
| # |
Apr 26th 2010, 11:47 |
ADmad |
a msg would be nice |
| # |
Apr 26th 2010, 11:44 |
nurvzy |
Indeed. Should I PM the author about the issues before removal or should I remove? |
| # |
Apr 26th 2010, 11:43 |
ADmad |
that one looks like crap anyway. If people expect their articles to be published they should alteast properly format them |