| # |
Jul 23rd 2009, 15:44 |
_1marc |
spam |
| # |
Jul 23rd 2009, 15:01 |
ProLoser|Work |
that's the only reason why I haven't been doing it, i wasn't sure if it affects other files |
| # |
Jul 23rd 2009, 15:00 |
ProLoser|Work |
which files don't need the closing ?> |
| # |
Jul 23rd 2009, 15:00 |
ProLoser|Work |
in thechaw, i'm on a fork and want to merge the latest master with my fork so i'm updated, how do i do this? |
| # |
Jul 23rd 2009, 14:53 |
ADmad |
good to see the closing ?> dropped in 1.3 files.. should encourage the users to follow the same |
| # |
Jul 23rd 2009, 14:50 |
alkemann |
creates UPDATE `test_articles` AS `Article` SET `Article`.`article_page_count` = 1 WHERE `Article`.`id` = 1 |
| # |
Jul 23rd 2009, 14:50 |
alkemann |
gwoo: http://bin.cakephp.org/view/650001983 |
| # |
Jul 23rd 2009, 14:49 |
alkemann |
gwoo: i tried making a simpler test, here it doesnt do it for me |
| # |
Jul 23rd 2009, 14:48 |
gwoo |
im pretty sure its consistently creating them |
| # |
Jul 23rd 2009, 14:48 |
alkemann |
gwoo: do u have an idea why the updateAll is inconsistent about creating the joins though? |
| # |
Jul 23rd 2009, 14:46 |
alkemann |
yea |
| # |
Jul 23rd 2009, 14:46 |
alkemann |
gwoo: yes 21 passes (it's 22 on 1.2 i think) |
| # |
Jul 23rd 2009, 14:45 |
jperras |
I'll take a look at those to remove them as well. |
| # |
Jul 23rd 2009, 14:45 |
jperras |
ok |
| # |
Jul 23rd 2009, 14:45 |
gwoo |
jperras: no there are more |
| # |
Jul 23rd 2009, 14:45 |
gwoo |
alkemann: does that work better? |
| # |
Jul 23rd 2009, 14:45 |
jperras |
were those the only places that the core still used 'uses' ? |
| # |
Jul 23rd 2009, 14:44 |
gwoo |
ok done |
| # |
Jul 23rd 2009, 14:42 |
ADmad |
1) alkemann's bin 2) jperass mentioning it was renamed to cake_session 3) alkemann said only happens in helper not component .. BAMM |
| # |
Jul 23rd 2009, 14:42 |
jperras |
yup, nice catch |
| # |
Jul 23rd 2009, 14:42 |
gwoo |
i'll push changes in a sec |
| # |
Jul 23rd 2009, 14:41 |
alkemann |
good spot ADmad :) |
| # |
Jul 23rd 2009, 14:39 |
gwoo |
yeah |
| # |
Jul 23rd 2009, 14:39 |
jperras |
might be a test bleedthrough issue |
| # |
Jul 23rd 2009, 14:39 |
gwoo |
i thought i fixed that thought |
| # |
Jul 23rd 2009, 14:38 |
jperras |
odd though, since I'm quite certain that the tests passed before I made the commit |
| # |
Jul 23rd 2009, 14:38 |
jperras |
rather, my negligence was the problem |
| # |
Jul 23rd 2009, 14:38 |
gwoo |
fixing |
| # |
Jul 23rd 2009, 14:38 |
jperras |
yup, that's the problem |
| # |
Jul 23rd 2009, 14:37 |
ADmad |
k |
| # |
Jul 23rd 2009, 14:37 |
gwoo |
thechaw is no longer up to date |
| # |
Jul 23rd 2009, 14:37 |
gwoo |
ADmad: look on code.cakephp.org |
| # |
Jul 23rd 2009, 14:37 |
jperras |
whoops |
| # |
Jul 23rd 2009, 14:37 |
jperras |
ha |
| # |
Jul 23rd 2009, 14:36 |
ADmad |
http://thechaw.com/cakephp/source/branches/1.3/cake/libs/view/helpers/session.php#28 |
| # |
Jul 23rd 2009, 14:36 |
gwoo |
on login form |
| # |
Jul 23rd 2009, 14:36 |
gwoo |
weird form helper is not working |
| # |
Jul 23rd 2009, 14:35 |
jperras |
hm |
| # |
Jul 23rd 2009, 14:35 |
alkemann |
gwoo: maybe its a windows thing? |
| # |
Jul 23rd 2009, 14:35 |
alkemann |
jperras: cakesession works |
| # |
Jul 23rd 2009, 14:34 |
gwoo |
alkemann: it seems to be workign for me |