| # |
Jul 20th 2009, 12:55 |
markstory |
or something with a less stupid name. |
| # |
Jul 20th 2009, 12:55 |
markstory |
so Article->saveBigTime() |
| # |
Jul 20th 2009, 12:55 |
markstory |
can always make a method that wraps up all the save() calls. |
| # |
Jul 20th 2009, 12:51 |
alkemann |
but maybe ur right that it would work |
| # |
Jul 20th 2009, 12:51 |
alkemann |
also need to set the pagenumber to 0 specifically |
| # |
Jul 20th 2009, 12:50 |
ADmad |
*too |
| # |
Jul 20th 2009, 12:50 |
ADmad |
ok.. though behaviors will run on ArticlePage is using saveAll to |
| # |
Jul 20th 2009, 12:49 |
alkemann |
the extra couple lines only makes the code more readable. no real benefit from using saveAll |
| # |
Jul 20th 2009, 12:48 |
alkemann |
making sure behaviours are run on the Article Page to create a revision |
| # |
Jul 20th 2009, 12:47 |
alkemann |
there was a reason i didnt do that.. hmm. |
| # |
Jul 20th 2009, 12:47 |
ADmad |
alkemann: can we/should we make saving Article and Intro atomic (ie saveAll) ? |
| # |
Jul 20th 2009, 12:46 |
alkemann |
hopefully it will help other developers see how it's intended to work and make sure they dont break it ;) |
| # |
Jul 20th 2009, 12:45 |
alkemann |
atm revision makes revisions when a page is accepte. i think changing the order in the model may fix it |
| # |
Jul 20th 2009, 12:45 |
markstory |
more of a functional / acceptance test. |
| # |
Jul 20th 2009, 12:44 |
alkemann |
markstory: not exactly a "unit" test, but it works well for making sure my behaviours are working together |
| # |
Jul 20th 2009, 12:44 |
Phally |
hmm yes indeed |
| # |
Jul 20th 2009, 12:44 |
alkemann |
that would be good as well |
| # |
Jul 20th 2009, 12:44 |
alkemann |
Phally: or maybe your thinking of a controller test, where you make sure u only correct user can run an acction |
| # |
Jul 20th 2009, 12:43 |
markstory |
neat |
| # |
Jul 20th 2009, 12:43 |
alkemann |
Phally: right. 2nd last test tests direct edit. checking for permission for doing this would be a seperate test |
| # |
Jul 20th 2009, 12:42 |
Phally |
alkemann: yeah, but i mean an article will be published immediately when he is an accepter author i.e. |
| # |
Jul 20th 2009, 12:41 |
alkemann |
last test |
| # |
Jul 20th 2009, 12:41 |
alkemann |
markstory: ^ |
| # |
Jul 20th 2009, 12:41 |
alkemann |
http://thechaw.com/bakery/source/branches/2.0/tests/cases/models/article_page.test.php |
| # |
Jul 20th 2009, 12:41 |
alkemann |
as per unit testing pattern. permissions would belong in a seperate test |
| # |
Jul 20th 2009, 12:41 |
markstory |
testing flows? |
| # |
Jul 20th 2009, 12:41 |
alkemann |
Phally: it's far from done. |
| # |
Jul 20th 2009, 12:41 |
Phally |
alkemann: yeah, i realised that, building a site without a site |
| # |
Jul 20th 2009, 12:40 |
alkemann |
beats inventing shit and F5 with debug(); |
| # |
Jul 20th 2009, 12:40 |
Phally |
alkemann: missing a thing though: the dependency on the group the user belongs to |
| # |
Jul 20th 2009, 12:39 |
Phally |
alkemann: the concept of testing flows is awesome |
| # |
Jul 20th 2009, 12:39 |
Phally |
alkemann: i checked out the article page flow |
| # |
Jul 20th 2009, 12:37 |
alkemann |
giggle |
| # |
Jul 20th 2009, 12:36 |
markstory |
I usually do :) |
| # |
Jul 20th 2009, 12:36 |
ProLoser|Work |
i'm not worthy of #bakery |
| # |
Jul 20th 2009, 12:36 |
ProLoser|Work |
please ignore my massive stupidity |
| # |
Jul 20th 2009, 12:36 |
ProLoser|Work |
bah |
| # |
Jul 20th 2009, 12:36 |
ProLoser|Work |
wait |
| # |
Jul 20th 2009, 12:36 |
ProLoser|Work |
i suppose is where i got confused |
| # |
Jul 20th 2009, 12:35 |
ProLoser|Work |
well what's the pages controller then? |
| # |
Jul 20th 2009, 12:35 |
ProLoser|Work |
uh |