| # |
Jul 17th 2009, 18:14 |
Phally |
so the modulus is in the right position, only the first() isn't called there |
| # |
Jul 17th 2009, 18:10 |
Phally |
the 1 is my fix |
| # |
Jul 17th 2009, 18:09 |
Phally |
in the numbers from that bin, 2-7 is the modulus |
| # |
Jul 17th 2009, 18:01 |
Phally |
i was try to adapt the condition for the if indeed, but always ended up with double 2 |
| # |
Jul 17th 2009, 18:00 |
gwoo |
maybe the calculation for $start is wrong |
| # |
Jul 17th 2009, 17:59 |
gwoo |
and im thking this will make the code even clearner |
| # |
Jul 17th 2009, 17:59 |
gwoo |
i think how much gets passed to first and last methods needs to be relative to the modulus and current page |
| # |
Jul 17th 2009, 17:58 |
gwoo |
we need more test cases |
| # |
Jul 17th 2009, 17:56 |
Phally |
right |
| # |
Jul 17th 2009, 17:55 |
gwoo |
modules right? |
| # |
Jul 17th 2009, 17:55 |
gwoo |
1-7 is the module |
| # |
Jul 17th 2009, 17:55 |
gwoo |
according to your ticket |
| # |
Jul 17th 2009, 17:55 |
gwoo |
Phally: that is not right |
| # |
Jul 17th 2009, 17:51 |
Phally |
the hardcoded 2 seems hardcoded but it is actually (first page + 1) which is always 2 as the opposite of (pageCount - 1) |
| # |
Jul 17th 2009, 17:44 |
Phally |
a lot of numbers, but it seems to give proper behavior: http://bin.cakephp.org/view/1518302476 |
| # |
Jul 17th 2009, 17:35 |
gwoo |
and current page == 5 |
| # |
Jul 17th 2009, 17:35 |
gwoo |
for example what happens if first == 5 and modulus == 5 |
| # |
Jul 17th 2009, 17:35 |
gwoo |
because it seems to only take into account these tested cases |
| # |
Jul 17th 2009, 17:34 |
gwoo |
the fix though i think needs some work |
| # |
Jul 17th 2009, 17:34 |
gwoo |
i see the issue it points out |
| # |
Jul 17th 2009, 17:34 |
Phally |
*patch |
| # |
Jul 17th 2009, 17:34 |
Phally |
gwoo: how about the PaginatorHelper, do you agree on the path? |
| # |
Jul 17th 2009, 17:33 |
gwoo |
ok cool |
| # |
Jul 17th 2009, 17:33 |
Phally |
yes, i know what you mean |
| # |
Jul 17th 2009, 17:33 |
gwoo |
Phally: did I explain it well enough? |
| # |
Jul 17th 2009, 17:33 |
Phally |
very well, i will refactor it |
| # |
Jul 17th 2009, 17:32 |
gwoo |
$controller gets passed to the callbacks because those are the only places where it should be needed |
| # |
Jul 17th 2009, 17:32 |
gwoo |
it is hard to know how much of "controller" is really used when you just set a property to the value coming in from the callbacks |
| # |
Jul 17th 2009, 17:32 |
gwoo |
and set it to a member of the current class |
| # |
Jul 17th 2009, 17:31 |
gwoo |
to get it |
| # |
Jul 17th 2009, 17:31 |
gwoo |
use the initialize or startup method |
| # |
Jul 17th 2009, 17:31 |
gwoo |
if you need data from teh Auth component |
| # |
Jul 17th 2009, 17:31 |
gwoo |
meaning that the original callbacks have not been used properly |
| # |
Jul 17th 2009, 17:31 |
gwoo |
to me that is bad form |
| # |
Jul 17th 2009, 17:31 |
gwoo |
Phally: also try to avoid set $this->__controller |
| # |
Jul 17th 2009, 17:30 |
gwoo |
in the second case |
| # |
Jul 17th 2009, 17:30 |
gwoo |
Phally: use isAuthorized |
| # |
Jul 17th 2009, 17:29 |
pointlessjon |
has anyone considered shell tasks as a category for articles? |
| # |
Jul 17th 2009, 17:29 |
Phally |
gwoo: so i extracted it as a method |
| # |
Jul 17th 2009, 17:29 |
Phally |
gwoo: it is called twice |
| # |
Jul 17th 2009, 17:28 |
gwoo |
why not just put that code in isAuthorized? |