| # |
Feb 10th 2020, 15:06 |
 challgren |
Its not making links active or adding the in |
| # |
Feb 10th 2020, 15:06 |
ndm |
@challgren What do you mean? |
| # |
Feb 10th 2020, 14:59 |
challgren |
No matches :( |
| # |
Feb 10th 2020, 14:45 |
ndm |
Maybe the `inherit*`/`consume*` options should somehow support not only the link element, but also the nest element... |
| # |
Feb 10th 2020, 14:41 |
slackebot |
parent::_renderNested($item, $options); }``` |
| # |
Feb 10th 2020, 14:41 |
ndm |
Something quick and dirty: ```protected function _renderNested(ItemInterface $item, array $options): string { if ( !$item->hasChildren() || $options['depth'] === 0 || !$item->getDisplayChildren() ) { return ''; } if ($this->_matcher->isAncestor($item, $options['matchingDepth'])) { $options['attributes']['class'] .= ' ' . $options['ancestorClass']; } return |
| # |
Feb 10th 2020, 14:37 |
ndm |
@challgren Well, that's some uncommon positioning for the ancestor class, it's hard to cover all those cases. You should be able to do that by extending the renderer, and adding the class in `\Icings\Menu\Renderer\StringTemplateRenderer::_renderNested()` |
| # |
Feb 10th 2020, 14:33 |
challgren |
Ehh yeah no JS too unreliable with the paths |
| # |
Feb 10th 2020, 14:29 |
challgren |
I did a little js hackery and got it working, but kind of defeats the serverside component |
| # |
Feb 10th 2020, 14:26 |
slackebot |
<challgren> |
| # |
Feb 10th 2020, 14:25 |
ndm |
what exactly do you want your output to look like? |
| # |
Feb 10th 2020, 14:25 |
challgren |
hrmmm |
| # |
Feb 10th 2020, 14:25 |
ndm |
@challgren Actually, that's the intended behavior, the ancestor class is being set on the ancestor `<a>` and `<li>` |
| # |
Feb 10th 2020, 14:25 |
FunkadelicRelic |
Awesome - that's installed something! I'll have a play around with it. Thank you @challgren. Much appreciated. |
| # |
Feb 10th 2020, 14:23 |
challgren |
I think its `composer require friendsofcake/bootstrap-ui @beta` |
| # |
Feb 10th 2020, 14:22 |
FunkadelicRelic |
4.0.3 not listed. |
| # |
Feb 10th 2020, 14:22 |
FunkadelicRelic |
3.6.5, 3.6.6, 3.6.7, 3.6.8, 3.6.9, 3.7.0, 3.7.0-RC1, 3.7.0-RC2, 3.7.0-RC3, 3.7.0-beta1, 3.7.1, 3.7.2, 3.7.3, 3.7.4, 3.7.5, 3.7.6, 3.7.7, 3.7.8, 3.7.9, 3.8.0, 3.8.0-RC1, 3.8.0-RC2, 3.8.0-RC3, 3.8.0-beta1, 3.8.1, 3.8.2, 3.8.3, 3.8.4, 3.8.5, 3.8.6, 3.8.7, 3.8.8, 3.8.9, 3.x-dev] but these conflict with your requirements or minimum-stability. |
| # |
Feb 10th 2020, 14:22 |
FunkadelicRelic |
- friendsofcake/bootstrap-ui 1.4.1 requires cakephp/cakephp ^3.5 -> satisfiable by cakephp/cakephp[3.5.0, 3.5.0-RC1, 3.5.0-RC2, 3.5.1, 3.5.10, 3.5.11, 3.5.12, 3.5.13, 3.5.14, 3.5.15, 3.5.16, 3.5.17, 3.5.18, 3.5.2, 3.5.3, 3.5.4, 3.5.5, 3.5.6, 3.5.7, 3.5.8, 3.5.9, 3.6.0, 3.6.0-RC1, 3.6.0-RC2, 3.6.0-beta1, 3.6.0-beta2, 3.6.0-beta3, 3.6.1, 3.6.10, 3.6.11, 3.6.12, 3.6.13, 3.6.14, 3.6.15, 3.6.2, 3.6.3, 3.6.4, |
| # |
Feb 10th 2020, 14:22 |
FunkadelicRelic |
Problem 1 |
| # |
Feb 10th 2020, 14:22 |
FunkadelicRelic |
Different error now... |
| # |
Feb 10th 2020, 14:20 |
challgren |
Current release is 3.0.0-beta |
| # |
Feb 10th 2020, 14:20 |
FunkadelicRelic |
@challgren - Oh cool - let me try that. Thank you. |
| # |
Feb 10th 2020, 14:19 |
FunkadelicRelic |
When I run the command 'composer require friendsofcake/bootstrap-ui' I get issues on the dependencies - 'Installation request for friendsofcake/bootstrap-ui ^1.4 -> satisfiable by friendsofcake/bootstrap-ui[1.4.0, 1.4.1]' 'Can only install one of: cakephp/cakephp[4.0.3, 3.x-dev]' |
| # |
Feb 10th 2020, 14:19 |
challgren |
funkadelicrelic make sure you have min-stability: beta in your compoter |
| # |
Feb 10th 2020, 14:19 |
damiano |
ok |
| # |
Feb 10th 2020, 14:18 |
challgren |
it doesn’t get the ul |
| # |
Feb 10th 2020, 14:18 |
slackebot |
<challgren> |
| # |
Feb 10th 2020, 14:18 |
ndm |
@challgren What output do you get? |
| # |
Feb 10th 2020, 14:18 |
FunkadelicRelic |
Hey all - I'm having some problems trying to install the friendsofcake\bootstrap-ui plugin on CakePHP 4.0.3 - was hoping someone might be able to point me in the right direction? |
| # |
Feb 10th 2020, 14:17 |
challgren |
Yeah moving it to render isnt working either |
| # |
Feb 10th 2020, 14:16 |
ndm |
just like `nestedMenuClass` |
| # |
Feb 10th 2020, 14:16 |
ndm |
@challgren Yeah, it's a not valid menu creation option, only `templates`, `templateVars` and `menuAttributes`, `ancestorClass` can be set in `render()` |
| # |
Feb 10th 2020, 14:15 |
spriz |
@damian just the way it works :) |
| # |
Feb 10th 2020, 14:14 |
challgren |
4.0 |
| # |
Feb 10th 2020, 14:13 |
ndm |
@challgren What version are you using? I have to check whether `ancestorClass` is actually a valid menu creation option |
| # |
Feb 10th 2020, 14:12 |
dereuromark |
I should have some examples in the sandbox |
| # |
Feb 10th 2020, 14:12 |
challgren |
So I add the ancestorClass and for some reason its not getting added to the UL for the nestedMenu |
| # |
Feb 10th 2020, 14:11 |
damiano |
or it is the way it works? |
| # |
Feb 10th 2020, 14:11 |
damiano |
@spriz is it a known bug? |
| # |
Feb 10th 2020, 14:11 |
ndm |
sure |
| # |
Feb 10th 2020, 14:10 |
challgren |
Anyone play with icings/menu? |