Log message #4220612

# At Username Text
# Dec 31st 2019, 15:08 birdy247 Then loads of files were updated
# Dec 31st 2019, 15:08 birdy247 so I did
# Dec 31st 2019, 15:08 birdy247 then it said I needed to do a git pull
# Dec 31st 2019, 15:08 birdy247 commited and went to push
# Dec 31st 2019, 15:08 birdy247 I then made my changes
# Dec 31st 2019, 15:07 birdy247 My compiter had master from 2018-02-01
# Dec 31st 2019, 15:07 dereuromark when I did a commit too early, and want to restash, i use https://www.git-tower.com/learn/git/faq/undo-last-commit
# Dec 31st 2019, 15:06 slackebot <birdy247>
# Dec 31st 2019, 15:05 slackebot <birdy247>
# Dec 31st 2019, 15:03 dereuromark how, if you had a new commit there? only force would push
# Dec 31st 2019, 15:03 birdy247 or reset to the commit before the merge?
# Dec 31st 2019, 15:02 birdy247 I have already pushed though
# Dec 31st 2019, 15:02 dereuromark it would be easier to just reset your local commit and stash the changes, then pull, then reapply stash
# Dec 31st 2019, 15:02 birdy247 now my merge shows about 1000 files changed
# Dec 31st 2019, 15:02 birdy247 I then did a git pull and fixed any conflicts
# Dec 31st 2019, 15:01 birdy247 I had actually started my changes from a version of master about 100 commits behind master
# Dec 31st 2019, 15:01 birdy247 made loads of chnages and just gone to push
# Dec 31st 2019, 15:01 birdy247 hadnt done a git pull
# Dec 31st 2019, 15:01 birdy247 started working on a new feature from a project
# Dec 31st 2019, 15:01 birdy247 I just did a really dumb thing
# Dec 31st 2019, 14:00 tibor.hajos https://github.com/cakephp/cakephp/pull/14106 I hope I understood everything well enough. Any feedback is welcome, I'll do my best to apply fixes accordingly.
# Dec 31st 2019, 11:05 admad @brian.french we are looking for contributors, we have no one on the team who uses it to maintaining it is proving difficult
# Dec 31st 2019, 08:37 brian.french Is cakephp/codeception still an active package? Is it going to move forward to the 4.x branch, or is it going to be abandoned?
# Dec 31st 2019, 00:12 phantomwatson Actually, completely ignore that. I was running into a weird error caused by running some migrations and then not clearing out `/tmp/cache/models`.
# Dec 30th 2019, 23:40 phantomwatson @dereuromark, speaking of which, MySQL 5.7.5 introduced `STRICT_TRANS_TABLES` mode, which gets cranky if an `INSERT` query is missing a field that doesn't have a default value. The Queue plugin runs afoul of that with the `workerkey` field, so a migration that adds a default value to that field on both tables would fix that. I can probably get that taken care of in a pull request this week.
# Dec 30th 2019, 22:18 phantomwatson I'd be happy to contribute, if I can. I can keep an eye out for issues that I could tackle with pull requests.
# Dec 30th 2019, 22:17 dereuromark you're welcome :) maybe you can help finalize the 4.x version, I want to release a beta here soon. if you might also need it soon there.
# Dec 30th 2019, 22:16 phantomwatson Oh, I'm sure they mention migrations. It was just my mistake. By the way, I've been using the plugin a lot over the last few years and really appreciate all of the work that you've put into it.
# Dec 30th 2019, 22:15 dereuromark If the docs dont point out migrations, you can also PR an improvement to docs here.
# Dec 30th 2019, 22:14 dereuromark sry, I thought it had some reserved keywords that require quoteIdentifier true :) Never mind then
# Dec 30th 2019, 22:07 phantomwatson What would the breaking change be? Sorry, I don't understand.
# Dec 30th 2019, 22:05 dereuromark @phantomwatson make a PR to change all reserverd keywords, the 4.x release could make this breaking change now :)
# Dec 30th 2019, 22:01 phantomwatson @brian.french, that's really unintuitive. Thanks for pointing it out.
# Dec 30th 2019, 22:01 phantomwatson @dereuromark, it turns out I just hadn't run a migration yet. Rookie mistake.
# Dec 30th 2019, 21:51 dereuromark I am not so sure, i have never needed this for a single app or plugin.
# Dec 30th 2019, 21:40 slackebot persistent.
# Dec 30th 2019, 21:40 brian.french So, I ran into an interesting situation while trying to test Model/Tables. The loaded Model was using the default database connection, instead of the test connection. After a few hours of trying to figure out why, I was able to track down what was causing it. Turns out is is a setting in the phpunit.xml file `processIsolation="true"` . This needs to be set to `processIsolation="false"` so that the fixtures and database connection is
# Dec 30th 2019, 21:19 phantomwatson Cool, now I know(?) how to hunt this down. Thanks!
# Dec 30th 2019, 21:19 phpnut cberdata"
# Dec 30th 2019, 21:19 phantomwatson Duh. Not sure why my first instinct was to blame the core. :slightly_frowning_face:
# Dec 30th 2019, 21:17 phantomwatson Oh crap, the `queue_processes` table from the `Queue` plugin has a field by that name.