| # |
Sep 11th 2019, 11:08 |
 spriz |
moving it to `afterSaveCommit` fixes that, but when we do save this (Tags) entity as `$this->Articles->save(['text' => 'foo', 'tags' => [ ['value' => 'bar'], [ 'value' => 'foobar']]);` the `afterSaveCommit` is not triggered for the `TagsTable` - only for the `ArticlesTable` |
| # |
Sep 11th 2019, 11:06 |
spriz |
we have a msg queue listening to a msg that is sent in an `afterSave`, but we have a race condition where the consumer picks up the msg that contains the `id`. Consumer does `$this->Table->get($id)` and gets `RecordNotFoundException` because it is not yet comitted :) |
| # |
Sep 11th 2019, 11:05 |
spriz |
Is there any way to have the `afterSaveCommit` called for a table even if it is a save happening from associations? |
| # |
Sep 11th 2019, 10:59 |
barlas |
When running composer install, I am getting "No Security.salt placeholder to replace." |
| # |
Sep 11th 2019, 10:50 |
spriz |
I think you've chipped in enough fornow |
| # |
Sep 11th 2019, 10:50 |
spriz |
Yeah, take some time off rather :raised_hands: |
| # |
Sep 11th 2019, 10:49 |
spriz |
;P |
| # |
Sep 11th 2019, 10:49 |
dereuromark |
time.. this thing called time.. |
| # |
Sep 11th 2019, 10:49 |
spriz |
way to ruin a dream there |
| # |
Sep 11th 2019, 10:49 |
spriz |
Aww |
| # |
Sep 11th 2019, 10:49 |
spriz |
Sweet! I'll sit back and wait for that ^^ |
| # |
Sep 11th 2019, 10:49 |
dereuromark |
not any time soon^^ |
| # |
Sep 11th 2019, 10:49 |
neon1024 |
@dereuromark Is doing that ;) |
| # |
Sep 11th 2019, 10:46 |
spriz |
one should build a new tool that configure, run and compile results from ALL OF THE THINGS |
| # |
Sep 11th 2019, 10:46 |
spriz |
phpmd, phpcpd, phpcs, phpstan, psalm - oh the choices! |
| # |
Sep 11th 2019, 10:45 |
spriz |
These reports are actually quite nice: http://maven.apache.org/plugins/maven-checkstyle-plugin/project-reports.html Most of those can be built with PHP tools as well including at least pmd, checkstyle, cpd, javadoc, and sonar |
| # |
Sep 11th 2019, 10:44 |
neon1024 |
One of those where they say it’s a bug because they expect it work differently to how they originally asked for it work |
| # |
Sep 11th 2019, 10:44 |
spriz |
Aww! Good luck though! |
| # |
Sep 11th 2019, 10:44 |
neon1024 |
Been given other things to work on now |
| # |
Sep 11th 2019, 10:44 |
spriz |
like http://maven.apache.org/plugins/maven-checkstyle-plugin/checkstyle.html |
| # |
Sep 11th 2019, 10:43 |
spriz |
Our previous Jenkins had nice HTML views for checkstyle.xml format @neon1024 - so something is out there! :) |
| # |
Sep 11th 2019, 10:15 |
neon1024 |
@admad Yes, and thanks for the PR to add the `compact` output format! |
| # |
Sep 11th 2019, 09:55 |
alexdd55976 |
man.. there are horrible communities around framework .... thanks guys for being the great guys |
| # |
Sep 11th 2019, 09:28 |
admad |
Have you actually checked the output formats it supports? |
| # |
Sep 11th 2019, 09:20 |
admad |
checkstyle is a standard format, so might be even able to find an existing xslt for it |
| # |
Sep 11th 2019, 09:16 |
neon1024 |
Ah didn’t know you could style up XML, interesting |
| # |
Sep 11th 2019, 09:14 |
admad |
XSL(T) |
| # |
Sep 11th 2019, 09:13 |
slackebot |
!google XSL |
| # |
Sep 11th 2019, 09:13 |
slackebot |
Command sent from Slack by neon1024: |
| # |
Sep 11th 2019, 09:12 |
neon1024 |
What’s XSL? |
| # |
Sep 11th 2019, 09:12 |
admad |
@neon1024 psalm can generate checkstyle xml. So slap on a XSL to it :) |
| # |
Sep 11th 2019, 09:10 |
dereuromark |
dont have much docker experience yet :slightly_smiling_face: |
| # |
Sep 11th 2019, 09:07 |
neon1024 |
Although, for me at least, Docker does add some initial friction to getting results quickly |
| # |
Sep 11th 2019, 09:06 |
neon1024 |
phpmetrics I quite like actually, as it can show some nice insights |
| # |
Sep 11th 2019, 09:06 |
neon1024 |
Not sure how you feel about Docker, but it might make a collection of tools / pipeline more mobile in a container |
| # |
Sep 11th 2019, 09:05 |
neon1024 |
@dereuromark Did you see this? https://github.com/adamculp/php-code-quality |
| # |
Sep 11th 2019, 09:05 |
dereuromark |
we are using that mainly company internal for pre-release review, but I want to also leverage some tooling for my plugins mainly. especially with the 4.x upgrade of 20+ apps. |
| # |
Sep 11th 2019, 09:04 |
dereuromark |
I am working on some automation tooling in general, including phpstan, cs, and other things to be wrapped for plugin or app analysis. |
| # |
Sep 11th 2019, 09:02 |
neon1024 |
Or if I get really bored today, I might look at a PR to add HTML output |
| # |
Sep 11th 2019, 09:02 |
neon1024 |
Nevermind, I’ll just put up with the `compact` output on the CLI and do it a file at a time |
| # |
Sep 11th 2019, 09:01 |
neon1024 |
;) |