| # |
Apr 3rd 2019, 10:09 |
 challgren |
@livia.scapin https://github.com/CakeDC/users/blob/develop/tests/TestApplication.php is what you would do |
| # |
Apr 3rd 2019, 10:07 |
slackebot2 |
pretty much https://github.com/cakephp/app/blob/master/tests/bootstrap.php I do understand that since the plugins are not loaded in bootstrap.php anymore, I guess I should do something in tests/bootstrap.php to load them? Or maybe somehow call Application::bootstrap? How do you guys handle this in your applications? And should we maybe adjust the app template? :slightly_smiling_face: |
| # |
Apr 3rd 2019, 10:07 |
livia.scapin |
So... I just updated a CakePHP 3.6 application to 3.7, everything went pretty well I guess. There is one problem, though and I'm not sure how to fix it, maybe someone could point me in the right direction? My problem is that plugin configuration isn't available anymore in my unit tests, which kind of makes sense. As suggested I moved all the plugin loading stuff from bootstrap.php to Application::bootstrap(). My tests/bootstrap.php is |
| # |
Apr 3rd 2019, 09:59 |
challgren |
Yep thats it! So its an flystsem-aws-3-v3 bug |
| # |
Apr 3rd 2019, 09:57 |
challgren |
Ok so it appears thats returning null because the content is not a string |
| # |
Apr 3rd 2019, 09:53 |
challgren |
Yep I have it |
| # |
Apr 3rd 2019, 09:51 |
challgren |
let me check if I got finfo |
| # |
Apr 3rd 2019, 09:45 |
admad |
@challgren https://github.com/thephpleague/flysystem/blob/master/src/Util/MimeType.php#L182 |
| # |
Apr 3rd 2019, 09:38 |
asdfgh |
the same |
| # |
Apr 3rd 2019, 09:38 |
asdfgh |
th ecomposer.json is the cakephp/app |
| # |
Apr 3rd 2019, 09:38 |
asdfgh |
i do not understand the reason |
| # |
Apr 3rd 2019, 09:37 |
asdfgh |
guys why do i get bash: bin/cake: No such file or directory ??? i run composer install |
| # |
Apr 3rd 2019, 09:31 |
challgren |
Guess its time for a custom Writer |
| # |
Apr 3rd 2019, 09:30 |
challgren |
But if I could pass Config on https://github.com/FriendsOfCake/cakephp-upload/blob/master/src/File/Writer/DefaultWriter.php#L122 I could manually set the ContentType |
| # |
Apr 3rd 2019, 09:29 |
challgren |
So it can serve it correctly |
| # |
Apr 3rd 2019, 09:29 |
challgren |
But S3 needs the content-type |
| # |
Apr 3rd 2019, 09:28 |
challgren |
Thats part of FlySystem |
| # |
Apr 3rd 2019, 09:28 |
admad |
Why is it even trying to detect type using extension, it's error prone anyway. Don't you have finfo() available? |
| # |
Apr 3rd 2019, 09:22 |
challgren |
But not really a cakephp-upload bug either |
| # |
Apr 3rd 2019, 09:20 |
challgren |
Its not really the adapters bug |
| # |
Apr 3rd 2019, 09:20 |
challgren |
Well the easiest solution would be to have a custom writerinterface it seems |
| # |
Apr 3rd 2019, 09:20 |
neon1024 |
Perhaps you can submit a failing test |
| # |
Apr 3rd 2019, 09:19 |
neon1024 |
Check the test-cases |
| # |
Apr 3rd 2019, 09:19 |
neon1024 |
Sounds like a bug then |
| # |
Apr 3rd 2019, 09:19 |
challgren |
so I guess my solution would be to rename the temp file |
| # |
Apr 3rd 2019, 09:19 |
challgren |
Just the path to the tmp file |
| # |
Apr 3rd 2019, 09:19 |
neon1024 |
Well yeah, that’s guessing using the absolute file path, so it probably isn’t an uploaded file array |
| # |
Apr 3rd 2019, 09:18 |
challgren |
But its in the adapter |
| # |
Apr 3rd 2019, 09:18 |
challgren |
https://github.com/thephpleague/flysystem-aws-s3-v3/blob/master/src/AwsS3Adapter.php#L577 |
| # |
Apr 3rd 2019, 09:17 |
neon1024 |
Indeed, but the `['name']` will do ;) |
| # |
Apr 3rd 2019, 09:16 |
challgren |
Actually it fails and returns text/plain because the tmp file doesnt have an extension |
| # |
Apr 3rd 2019, 09:15 |
challgren |
https://github.com/thephpleague/flysystem/blob/master/src/Util/MimeType.php#L218 fails and then calls the detectByFileExtension |
| # |
Apr 3rd 2019, 09:14 |
challgren |
It does https://github.com/thephpleague/flysystem/blob/master/src/Util/MimeType.php#L202:28 |
| # |
Apr 3rd 2019, 09:10 |
neon1024 |
Although that won’t have any impact |
| # |
Apr 3rd 2019, 09:10 |
neon1024 |
It will be |
| # |
Apr 3rd 2019, 09:09 |
challgren |
It tries to guess it but I think it's working on the temp name |
| # |
Apr 3rd 2019, 09:09 |
challgren |
Set one when using awss3adapter |
| # |
Apr 3rd 2019, 09:09 |
neon1024 |
I used the file info php extension |
| # |
Apr 3rd 2019, 09:09 |
neon1024 |
Set one? Or do you mean read the mime type from the uploaded file? |
| # |
Apr 3rd 2019, 09:08 |
challgren |
Any have an idea how to set a mine type when using foc/upload? |
| # |
Apr 3rd 2019, 09:06 |
neon1024 |
It sure does! |