| # |
Jan 18th 2019, 13:53 |
 ricksaccous |
that man is my hero, our hero probably |
| # |
Jan 18th 2019, 13:53 |
ricksaccous |
@neon1024 yeah ADmad updated it when someone pointed it out to him a couple days ago, haha |
| # |
Jan 18th 2019, 12:48 |
neon1024 |
Ah, it’s been updated already. Must me my code is out of date |
| # |
Jan 18th 2019, 12:47 |
neon1024 |
However the docblock doesn’t mention false explicity, it’s a guess |
| # |
Jan 18th 2019, 12:47 |
neon1024 |
I presume the idea is `->allowEmptyString('table_alias', false)` |
| # |
Jan 18th 2019, 12:41 |
neon1024 |
It’s not explicit enough |
| # |
Jan 18th 2019, 12:41 |
neon1024 |
I don’t like this change at all |
| # |
Jan 18th 2019, 12:38 |
neon1024 |
Why would I require a field with allowEmpty? |
| # |
Jan 18th 2019, 12:38 |
neon1024 |
https://github.com/cakephp/cakephp/blob/master/src/Validation/Validator.php#L990-L992 |
| # |
Jan 18th 2019, 12:38 |
neon1024 |
I don’t understand this |
| # |
Jan 18th 2019, 12:35 |
neon1024 |
I bet this might be because the html will transmit request data as a string right? Before it’s marshalled into correct types |
| # |
Jan 18th 2019, 12:35 |
neon1024 |
`->allowEmptyString('id', 'create');` |
| # |
Jan 18th 2019, 12:35 |
neon1024 |
Hah |
| # |
Jan 18th 2019, 12:26 |
neon1024 |
Blimey, you’d have to be brave to pr phpunit! |
| # |
Jan 18th 2019, 12:17 |
dereuromark |
you could pr 2|3 for phpunit 6 as patch |
| # |
Jan 18th 2019, 12:14 |
neon1024 |
Although I have made changes to config/bootstrap.php config/boostrap_cli.php and src/Application.php already beforehand |
| # |
Jan 18th 2019, 12:14 |
neon1024 |
The skeleton upgrade shell didn’t think I needed anything doing, so I must be up to date with cakephp/app |
| # |
Jan 18th 2019, 12:13 |
neon1024 |
Well Rector seems to work well! |
| # |
Jan 18th 2019, 12:10 |
neon1024 |
phpunit 7.0.0 is the minimum for sebastian/diff 3.0 |
| # |
Jan 18th 2019, 12:09 |
neon1024 |
..and the core is still `^5.7.14|^6.0"` |
| # |
Jan 18th 2019, 12:08 |
neon1024 |
> phpunit/phpunit 6.5.13 requires sebastian/diff (^2.0) |
| # |
Jan 18th 2019, 12:08 |
neon1024 |
Found the culprit |
| # |
Jan 18th 2019, 11:59 |
neon1024 |
Oh I see, thanks! I’ll take a look at Rector again once I’ve upgraded my skeleton. I would like to get Rector working so I can share it with my colleagues for their projects |
| # |
Jan 18th 2019, 11:58 |
dereuromark |
and there shouldnt be issues |
| # |
Jan 18th 2019, 11:58 |
dereuromark |
then you should be able to use 3.x of diff |
| # |
Jan 18th 2019, 11:58 |
neon1024 |
My local Mac that is |
| # |
Jan 18th 2019, 11:58 |
neon1024 |
`7.2.12` it seems |
| # |
Jan 18th 2019, 11:57 |
dereuromark |
you are on php 71? |
| # |
Jan 18th 2019, 11:56 |
dereuromark |
ah ok |
| # |
Jan 18th 2019, 11:56 |
neon1024 |
Not you, sorry dude, I meant Rector. Seems to collide with something on `sebastian/diff` |
| # |
Jan 18th 2019, 11:56 |
dereuromark |
whats the issue with the lock file of my tool? |
| # |
Jan 18th 2019, 11:55 |
neon1024 |
There is a bit of work for each minor release these days, if you keep up with the deprecations, perhaps that’s putting people off a bit |
| # |
Jan 18th 2019, 11:55 |
dereuromark |
no one seems interested in upgrading further |
| # |
Jan 18th 2019, 11:55 |
neon1024 |
I can Run a code inspection for deprecations in php storm I guess, so I’ll just update my skeleton :thumbsup: |
| # |
Jan 18th 2019, 11:54 |
neon1024 |
Yeah, plus it’s rife with composer conflicts, and the prefixed rector only goes up to 3.6! |
| # |
Jan 18th 2019, 11:52 |
dereuromark |
upgrade skeleton works fine for me to get the latest things in. rector is more for the method upgrades |
| # |
Jan 18th 2019, 11:51 |
dereuromark |
as for the tools: smart people use both :slightly_smiling_face: as they solve different things |
| # |
Jan 18th 2019, 11:51 |
dereuromark |
second that^^ |
| # |
Jan 18th 2019, 11:51 |
neon1024 |
I should use the effort I’m putting into monologuing to contribute upgrade techniques to the book :thinking_face: |
| # |
Jan 18th 2019, 11:48 |
neon1024 |
Sorry Mark :P |
| # |
Jan 18th 2019, 11:48 |
neon1024 |
Actually, I’ll try Rector :slightly_smiling_face: |