Log message #4170090

# At Username Text
# Oct 4th 2018, 11:00 narendravaghela @admad he said that earlier that he found my plugin
# Oct 4th 2018, 11:00 neon1024 Ahhh!
# Oct 4th 2018, 11:00 narendravaghela https://github.com/sprintcube/cakephp-sendgrid
# Oct 4th 2018, 11:00 admad @narendravaghela I blame you for not telling him to just use your plugin :P
# Oct 4th 2018, 11:00 neon1024 @narendravaghela Did you store the repo somewhere else?
# Oct 4th 2018, 11:00 neon1024 https://github.com/narendravaghela?utf8=%E2%9C%93andtab=repositoriesandq=sendgridandtype=andlanguage=
# Oct 4th 2018, 10:59 neon1024 But as we said, we could discuss this all day! ;P
# Oct 4th 2018, 10:59 neon1024 My point is more that the core team are maintaining an email implementation and a framework. The team on SwiftMailer only do email
# Oct 4th 2018, 10:58 neon1024 Well, indeed
# Oct 4th 2018, 10:58 admad > I’d still be deploying code I’m not using though Then stop using any framework
# Oct 4th 2018, 10:58 narendravaghela @neon1024 you said it
# Oct 4th 2018, 10:58 btx woah @neon1024 this might be a game-changer
# Oct 4th 2018, 10:58 neon1024 I could only find MailGun and another one on the Awesome list
# Oct 4th 2018, 10:58 neon1024 I didn’t know he’d done one!
# Oct 4th 2018, 10:57 neon1024 @narendravaghela Was right I think, if I don’t think it’s great, why not PR
# Oct 4th 2018, 10:57 admad Why are you not just using the sendgrid transport @narendravaghela has made?
# Oct 4th 2018, 10:57 neon1024 I’d still be deploying code I’m not using though
# Oct 4th 2018, 10:57 neon1024 But yes, you’re not wrong
# Oct 4th 2018, 10:57 neon1024 Apart from being in the middle of building an email transport class…
# Oct 4th 2018, 10:56 admad @neon1024 stop bitching unnecessarily :slightly_smiling_face: Nothing stopping you from using swiftmailer right now too if you want to
# Oct 4th 2018, 10:54 narendravaghela This is endless ;)
# Oct 4th 2018, 10:54 narendravaghela :)
# Oct 4th 2018, 10:54 neon1024 You mean like the `mail()` function :P
# Oct 4th 2018, 10:54 narendravaghela @neon1024 yes, but having some basic features inbuilt is a good thing :slightly_smiling_face:
# Oct 4th 2018, 10:53 neon1024 How many records are you working with?
# Oct 4th 2018, 10:53 btx chunk seems like it needs the data prior to being called - but it should be easy enough to test
# Oct 4th 2018, 10:52 btx hmm i wonder if I did a for loop with pagination or something instead
# Oct 4th 2018, 10:51 neon1024 I guess you could argue scope all day though
# Oct 4th 2018, 10:51 neon1024 Having lots of features is RAD, but you gotta maintain them all and compete with all the other package maintainers
# Oct 4th 2018, 10:50 narendravaghela :slightly_smiling_face:
# Oct 4th 2018, 10:50 neon1024 Then if you wanted to use SwiftMailer or something you could drop that in
# Oct 4th 2018, 10:50 neon1024 Spin it off into a plugin
# Oct 4th 2018, 10:50 neon1024 I’d remove it
# Oct 4th 2018, 10:50 narendravaghela You can update Email class :)
# Oct 4th 2018, 10:49 neon1024 It should be better than that
# Oct 4th 2018, 10:49 narendravaghela https://github.com/cakephp/cakephp/blob/master/src/Mailer/Email.php#L955
# Oct 4th 2018, 10:49 neon1024 This stuff kinda makes me feel a bit uncomfortable
# Oct 4th 2018, 10:49 neon1024 https://3v4l.org/06lEa :)
# Oct 4th 2018, 10:48 btx hmm that’s a new one lemme check
# Oct 4th 2018, 10:48 neon1024 Perhaps you could use Collection::chunk ?
# Oct 4th 2018, 10:47 btx probably streaming yeah, like return 1000 records, free up memory, do the next 1000