| # |
Jun 19th 2018, 16:43 |
 dwms |
????????????????????? |
| # |
Jun 19th 2018, 16:34 |
dwms |
top 100 |
| # |
Jun 19th 2018, 16:34 |
dwms |
example |
| # |
Jun 19th 2018, 16:34 |
dwms |
how to add top in selects |
| # |
Jun 19th 2018, 16:34 |
dwms |
my select is slow because cakephp 3 uses offset rather than top |
| # |
Jun 19th 2018, 16:33 |
dwms |
I use sqlserver with cakephp 3 |
| # |
Jun 19th 2018, 16:33 |
dwms |
help |
| # |
Jun 19th 2018, 16:17 |
neon1024 |
https://github.com/cakephp/phinx/blob/master/.travis.yml#L38 |
| # |
Jun 19th 2018, 16:17 |
neon1024 |
So it could be entirely possible that there are no issues to fix |
| # |
Jun 19th 2018, 16:17 |
neon1024 |
PHP CS is run by Travis for Phinx also |
| # |
Jun 19th 2018, 16:16 |
neon1024 |
So that specific case is already in the ruleset it would seem |
| # |
Jun 19th 2018, 16:15 |
neon1024 |
File uploaded https://cakesf.slack.com/files/U1BT622HW/FBB5X3VDL/screen_shot_2018-06-19_at_17.15.32.png / https://slack-files.com/T053DPNCM-FBB5X3VDL-a94de446a5 |
| # |
Jun 19th 2018, 16:15 |
josbeir |
i just use the cake one |
| # |
Jun 19th 2018, 16:15 |
neon1024 |
However, that might be phpcs, or phpmd, I have a bunch of stuff running in PHP Storm |
| # |
Jun 19th 2018, 16:14 |
neon1024 |
Mine here enforces a blank line before a return inside a method at least |
| # |
Jun 19th 2018, 16:14 |
neon1024 |
The Cake standard is an extension of PSR2 |
| # |
Jun 19th 2018, 16:11 |
josbeir |
so i guess psr2 it is :slightly_smiling_face: |
| # |
Jun 19th 2018, 16:11 |
josbeir |
travis uses the default config |
| # |
Jun 19th 2018, 16:11 |
josbeir |
- if [[ $PHPCS = 1 ]]; then vendor/bin/phpcs -p -s src; fi |
| # |
Jun 19th 2018, 16:11 |
josbeir |
have you checked travis? |
| # |
Jun 19th 2018, 16:11 |
rquadling |
It seems that no one is really defining what's what. |
| # |
Jun 19th 2018, 16:10 |
josbeir |
then check with one that knows :) |
| # |
Jun 19th 2018, 16:09 |
rquadling |
I am a "phinx dude". Ha !!! |
| # |
Jun 19th 2018, 16:09 |
josbeir |
i have no answer for you, best check with phinx dudes :slightly_smiling_face: |
| # |
Jun 19th 2018, 16:09 |
rquadling |
So overrides the standard. |
| # |
Jun 19th 2018, 16:08 |
rquadling |
Interestingly, the phpcs.xml.dist is PSR2, but the composer.json file run script uses --standard=vendor/cakephp/cakephp-codesniffer/CakePHP |
| # |
Jun 19th 2018, 16:07 |
josbeir |
not cake |
| # |
Jun 19th 2018, 16:07 |
josbeir |
but you said phinx codebase, thats using PSR2... |
| # |
Jun 19th 2018, 16:07 |
rquadling |
I ran composer cs-fix and got no changes. Reformatted in PHPStorm. LOAD of changes. Re-ran composer cs-fix. Nothing. Seems that the majority of w/s issues aren't defined in CakePHP's definition. Don't want to push a load of w/s for no reason. |
| # |
Jun 19th 2018, 16:05 |
josbeir |
that should be improved as well :P |
| # |
Jun 19th 2018, 16:05 |
josbeir |
thats right |
| # |
Jun 19th 2018, 16:04 |
rquadling |
Seems that the CakePHP standard doesn't define things like blank lines after file level docblock, or before @return / return. |
| # |
Jun 19th 2018, 16:01 |
josbeir |
thats good, does phpcbf fix that automatically ? |
| # |
Jun 19th 2018, 16:01 |
admad |
@josbeir it's intended to be changed in next major |
| # |
Jun 19th 2018, 16:00 |
josbeir |
use sorting should be improved tho :P |
| # |
Jun 19th 2018, 16:00 |
rquadling |
Aha! Found it. |
| # |
Jun 19th 2018, 15:58 |
admad |
I would say CakePHP's standard since it's now part of the cake family |
| # |
Jun 19th 2018, 15:58 |
rquadling |
Yes,. |
| # |
Jun 19th 2018, 15:58 |
admad |
@rquadling coding standard? |
| # |
Jun 19th 2018, 15:54 |
rquadling |
What c/s should be applied to the Phinx code base? Or is this not really a concern? |
| # |
Jun 19th 2018, 15:14 |
mdunham |
https://imgur.com/a/5zIF9I3 |
