| # |
Jun 18th 2018, 11:46 |
magiq |
How to move controller to subfolder ? |
| # |
Jun 18th 2018, 10:44 |
 dereuromark |
And ~ makes no difference here |
| # |
Jun 18th 2018, 10:43 |
dereuromark |
You seem both a bit confused about semver. ^3.6 is >=3.6 for the scope of this issue. As such it is fine to use (and does not allow 3.5 either way of course) |
| # |
Jun 18th 2018, 10:42 |
neon1024 |
Using `~` would get both it seems, https://semver.mwl.be/#?package=cakephp%2Fcakephpandversion=~3.5andminimum-stability=stable |
| # |
Jun 18th 2018, 10:41 |
neon1024 |
Seems that `^3.6` is just 3.6 |
| # |
Jun 18th 2018, 10:41 |
neon1024 |
https://semver.mwl.be/#?package=cakephp%2Fcakephpandversion=%5E3.6andminimum-stability=stable |
| # |
Jun 18th 2018, 10:41 |
spriz |
should it be `>=3.6` for this? |
| # |
Jun 18th 2018, 10:40 |
spriz |
now I’m in doubt though - does “cakephp/cakephp”: “^3.6" actually allow 3.5 ? |
| # |
Jun 18th 2018, 10:39 |
spriz |
it’s easy to allow 3.5 since the’re aliasas in place for the core, but I understand if you want to push to 3.6 :) |
| # |
Jun 18th 2018, 10:38 |
spriz |
Made https://github.com/FriendsOfCake/crud/pull/595 :slightly_smiling_face: |
| # |
Jun 18th 2018, 10:38 |
dereuromark |
at least for a few more months as long as it doesnt require any functional improvement from 3.6 this is the most sane thing to do. |
| # |
Jun 18th 2018, 10:37 |
dereuromark |
I just keep mine 3.5+ with forcing deprecation silence. easier for everyone |
| # |
Jun 18th 2018, 10:37 |
dereuromark |
probably, better than fatal errors unexpectely :slightly_smiling_face: |
| # |
Jun 18th 2018, 10:35 |
neon1024 |
@dereuromark Should plugins be pushing 3.6 as a minimum in newer releases? |
| # |
Jun 18th 2018, 10:32 |
dereuromark |
this repo has no BC check using prefer-lowest? |
| # |
Jun 18th 2018, 10:32 |
dereuromark |
looks like the constraint to ^3.5 is than invalid |
| # |
Jun 18th 2018, 10:31 |
josbeir |
:@ |
| # |
Jun 18th 2018, 10:31 |
josbeir |
what the, second time i want to go to gmail in browser and slack is the active window |
| # |
Jun 18th 2018, 10:30 |
josbeir |
gm |
| # |
Jun 18th 2018, 10:30 |
josbeir |
mind the calories tho |
| # |
Jun 18th 2018, 10:29 |
spriz |
Wohoo :tada: |
| # |
Jun 18th 2018, 10:29 |
neon1024 |
Have an extra doughnut today! ;) |
| # |
Jun 18th 2018, 10:29 |
neon1024 |
Well found! |
| # |
Jun 18th 2018, 10:29 |
spriz |
seems to be a simple bug :slightly_smiling_face: |
| # |
Jun 18th 2018, 10:29 |
spriz |
https://github.com/cakephp/cakephp/tree/3.6.5/src/Http |
| # |
Jun 18th 2018, 10:29 |
spriz |
Nope, not in 3.6 neither |
| # |
Jun 18th 2018, 10:29 |
neon1024 |
Oh right, my next suggestion was to check your `@expectedException` but that wouldn’t help :slightly_smiling_face: |
| # |
Jun 18th 2018, 10:28 |
spriz |
I guess there is in 3.6 :slightly_smiling_face: |
| # |
Jun 18th 2018, 10:28 |
josbeir |
gm |
| # |
Jun 18th 2018, 10:28 |
spriz |
the `Cake\Http\Exception\NotFoundException` @neon1024 |
| # |
Jun 18th 2018, 10:28 |
spriz |
at least not in cakephp 3.5.17 |
| # |
Jun 18th 2018, 10:27 |
spriz |
There is no such exception in Cake\Http\Exception :) |
| # |
Jun 18th 2018, 10:25 |
neon1024 |
Your composer json autoloading the core? |
| # |
Jun 18th 2018, 10:25 |
spriz |
Ah - that kinda makes sense: https://github.com/FriendsOfCake/crud/pull/592/files |
| # |
Jun 18th 2018, 10:25 |
neon1024 |
Autoloader? |
| # |
Jun 18th 2018, 10:24 |
spriz |
crud 5.4.2 broke it somehow :P |
| # |
Jun 18th 2018, 10:22 |
spriz |
earlier a `$this->assertResponseContains('Not found');` could be used :P |
| # |
Jun 18th 2018, 10:22 |
spriz |
on a `$this->delete('/admin/feature_groups/delete/invalidId');` |
| # |
Jun 18th 2018, 10:21 |
spriz |
As so: `PHP Fatal error: Class 'Cake\Http\Exception\NotFoundException' not found in /var/www/apacta/vendor/friendsofcake/crud/src/Traits/FindMethodTrait.php on line 95` |
| # |
Jun 18th 2018, 10:21 |
spriz |
anyone else have had problems with cake exceptions not being caught by phpunit in integration test cases? For us crud 5.4.x cause the trouble (trying to figure out which patch version) |
| # |
Jun 18th 2018, 09:58 |
louis |
No problem, thank’s for your help :thumbsup: |