| # |
Jun 14th 2018, 13:15 |
 lorenzo |
so it was s solid win |
| # |
Jun 14th 2018, 13:15 |
lorenzo |
but, it also allows instant searches on historic data, by nested columns as well |
| # |
Jun 14th 2018, 13:15 |
itmpls |
jeez |
| # |
Jun 14th 2018, 13:15 |
lorenzo |
we ran into a situation where the audit log tables we over 200Gb, and deleting from them would block the database |
| # |
Jun 14th 2018, 13:14 |
lorenzo |
but you can scale ES easier by adding more machines |
| # |
Jun 14th 2018, 13:14 |
lorenzo |
to be honest, the main reason elastic search is the default is because disk space for databases is expensive |
| # |
Jun 14th 2018, 13:14 |
itmpls |
but I imagine ES would be the go-to for a bigger db/overall so it does the decoding natively? haven't used ES that much |
| # |
Jun 14th 2018, 13:13 |
itmpls |
err - elastic search* |
| # |
Jun 14th 2018, 13:13 |
itmpls |
i did get a solution, but i did it nasty because i'm json_decoding the columns - i'm guessing that's why lucene is recommended. for my database, this report is run manually and there aren't going to be more than 100 users probably so |
| # |
Jun 14th 2018, 13:13 |
lorenzo |
@itmpls I imagined it had to do with a nested trasaction |
| # |
Jun 14th 2018, 13:13 |
spriz |
I’ll make sure to bring enough coffee :,) |
| # |
Jun 14th 2018, 13:13 |
lorenzo |
haha |
| # |
Jun 14th 2018, 13:13 |
lorenzo |
exciting |
| # |
Jun 14th 2018, 13:12 |
spriz |
@lorenzo found a commit in october 2017 where things work - so I’ll go ahead with git bisect tomorrow - I’ll update you :) |
| # |
Jun 14th 2018, 13:12 |
itmpls |
basically not having the proper "dirty" logic, and also having to manually do the audit trail saveOptions in a nested transaction |
| # |
Jun 14th 2018, 13:11 |
lorenzo |
what was the problem/ |
| # |
Jun 14th 2018, 13:11 |
lorenzo |
yay! |
| # |
Jun 14th 2018, 13:10 |
itmpls |
@lorenzo thanks for the help - got it. the rest was on me :slightly_smiling_face: awesome plugin |
| # |
Jun 14th 2018, 13:08 |
spriz |
that’s the best test I’ve ever wrote. $this->assertTrue(true) :) |
| # |
Jun 14th 2018, 13:08 |
spriz |
True that! |
| # |
Jun 14th 2018, 13:08 |
spriz |
Oh well, we have something really fishy going on - one of my colleagues just told me that it has been a problem for him on his local machine for a long time… :anguished: |
| # |
Jun 14th 2018, 13:06 |
lorenzo |
at least you have a workaround :troll: |
| # |
Jun 14th 2018, 13:03 |
spriz |
yeah nope, not the first test in that plugin that fails |
| # |
Jun 14th 2018, 13:01 |
spriz |
trying to run full test suite with --debug so I can check that |
| # |
Jun 14th 2018, 13:01 |
spriz |
gimme a sec |
| # |
Jun 14th 2018, 13:01 |
spriz |
maybe it’s the first file in this specific plugin |
| # |
Jun 14th 2018, 13:00 |
spriz |
Hmm |
| # |
Jun 14th 2018, 13:00 |
lorenzo |
or a specific fixture |
| # |
Jun 14th 2018, 13:00 |
spriz |
Nah, seems to apply for other files |
| # |
Jun 14th 2018, 13:00 |
lorenzo |
maybe the things it imports? |
| # |
Jun 14th 2018, 13:00 |
lorenzo |
I really don’t know what could be special about that file |
| # |
Jun 14th 2018, 12:59 |
lorenzo |
wow, makes no sense |
| # |
Jun 14th 2018, 12:59 |
spriz |
but only seem to be that file |
| # |
Jun 14th 2018, 12:59 |
spriz |
yurp |
| # |
Jun 14th 2018, 12:58 |
lorenzo |
? |
| # |
Jun 14th 2018, 12:58 |
lorenzo |
even when running that file alone |
| # |
Jun 14th 2018, 12:55 |
spriz |
so no matter what the first method fails |
| # |
Jun 14th 2018, 12:55 |
spriz |
whenever I add method number 2, that method will pass |
| # |
Jun 14th 2018, 12:54 |
spriz |
if i comment all the methods, and enable them one by one, they all fail |
| # |
Jun 14th 2018, 12:51 |
lorenzo |
tray removing one by one until you find which it is |
| # |
Jun 14th 2018, 12:50 |
lorenzo |
there must be one test in that file that is making the others fail |