# |
Mar 8th 2018, 04:56 |
meder |
i'll have to adapt that pull request for 3.3 |
# |
Mar 8th 2018, 04:53 |
meder |
and that's great :) |
# |
Mar 8th 2018, 04:52 |
meder |
haha |
# |
Mar 8th 2018, 04:52 |
savant |
we’re allowed to make code better between releases |
# |
Mar 8th 2018, 04:51 |
meder |
totally different |
# |
Mar 8th 2018, 04:51 |
meder |
jeez, 3.3 RoutingMiddleware differs from whatever that version is (guessing 3.5) |
# |
Mar 8th 2018, 04:28 |
meder |
just the dynamic ones at least |
# |
Mar 8th 2018, 04:27 |
meder |
3089 routes |
# |
Mar 8th 2018, 04:26 |
meder |
savant: mm found it.. some code was basically looping through all plugins and going through dynamicRoutes, and then calling ->connect() on all of them. |
# |
Mar 8th 2018, 03:46 |
savant |
i’ll leave you be then :slightly_smiling_face: |
# |
Mar 8th 2018, 03:45 |
savant |
ok |
# |
Mar 8th 2018, 03:45 |
meder |
hah |
# |
Mar 8th 2018, 03:45 |
savant |
and gist them |
# |
Mar 8th 2018, 03:45 |
meder |
my eyes are tired, because to get to this point took me all day |
# |
Mar 8th 2018, 03:45 |
savant |
just open every routes.php file |
# |
Mar 8th 2018, 03:45 |
savant |
I’m offering to take a look and show you where those are being injected |
# |
Mar 8th 2018, 03:45 |
meder |
the second i find out i will share |
# |
Mar 8th 2018, 03:45 |
meder |
just inherited it |
# |
Mar 8th 2018, 03:45 |
savant |
can you just gist every routes.php file you have? |
# |
Mar 8th 2018, 03:45 |
meder |
again, this isn't my app :p |
# |
Mar 8th 2018, 03:44 |
meder |
hah |
# |
Mar 8th 2018, 03:44 |
savant |
it seems to me it would be better to decrease that |
# |
Mar 8th 2018, 03:44 |
meder |
yeah man. i'm trying to find it dude |
# |
Mar 8th 2018, 03:44 |
savant |
I’m more curious as to where you are getting those 4k routes |
# |
Mar 8th 2018, 03:44 |
savant |
I wonder what else changed |
# |
Mar 8th 2018, 03:44 |
savant |
seems like it |
# |
Mar 8th 2018, 03:44 |
savant |
*3.3 |
# |
Mar 8th 2018, 03:44 |
savant |
does 3.x support middleware? |
# |
Mar 8th 2018, 03:43 |
meder |
i guess 2, 1 is a test |
# |
Mar 8th 2018, 03:43 |
meder |
it's 3 files changed? could i just override those at the app level? |
# |
Mar 8th 2018, 03:41 |
meder |
right |
# |
Mar 8th 2018, 03:41 |
meder |
3.3.16 |
# |
Mar 8th 2018, 03:41 |
savant |
that pull request is not released yet :slightly_smiling_face: |
# |
Mar 8th 2018, 03:40 |
meder |
might have to patch it by overriding the file |
# |
Mar 8th 2018, 03:40 |
savant |
search for a VERSION.txt file |
# |
Mar 8th 2018, 03:40 |
meder |
now it's time to figure out what version of cake this monolithic site is on... |
# |
Mar 8th 2018, 03:40 |
meder |
sweet |
# |
Mar 8th 2018, 03:38 |
admad |
meder: https://github.com/cakephp/cakephp/pull/11765 |
# |
Mar 8th 2018, 03:37 |
meder |
sec |
# |
Mar 8th 2018, 03:37 |
meder |
yeah.. let me find it first |
# |
Mar 8th 2018, 03:37 |
savant |
if you gist those, I can help you better. |