| # |
Oct 12th 2017, 14:48 |
inoas |
+202 I say. |
| # |
Oct 12th 2017, 14:48 |
inoas |
<3 |
| # |
Oct 12th 2017, 14:48 |
inoas |
HAHA |
| # |
Oct 12th 2017, 14:48 |
inoas |
Well, it is clearly not meant to handle binaries |
| # |
Oct 12th 2017, 14:48 |
 neon1024 |
Sure, it’s called the power button ;) |
| # |
Oct 12th 2017, 14:47 |
inoas |
you mean the tinkering with files before committing ;)? |
| # |
Oct 12th 2017, 14:47 |
neon1024 |
The binary file handling in Git |
| # |
Oct 12th 2017, 14:47 |
inoas |
turn what off? |
| # |
Oct 12th 2017, 14:47 |
neon1024 |
You can turn that off inoas |
| # |
Oct 12th 2017, 14:46 |
inoas |
man I hate that git messes with binary files and is so stupid about mime types |
| # |
Oct 12th 2017, 14:46 |
inoas |
but I think you should load angular for that XD |
| # |
Oct 12th 2017, 14:45 |
inoas |
Html basics are rare I know :p |
| # |
Oct 12th 2017, 14:45 |
inoas |
save + reload => save + redirect |
| # |
Oct 12th 2017, 14:45 |
dereuromark |
:slightly_smiling_face: jep jep |
| # |
Oct 12th 2017, 14:45 |
inoas |
you give the buttons the same name but different values... may work, if not: 2 buttons with different names/values and check request data |
| # |
Oct 12th 2017, 14:45 |
neon1024 |
Because reasons. |
| # |
Oct 12th 2017, 14:44 |
inoas |
why? |
| # |
Oct 12th 2017, 14:42 |
neon1024 |
How would you guys approach a use-case where you have two buttons to submit your form. Save will save and redirect to index, Save and reload, will save and reload the same page. I can only really think of a JS solution |
| # |
Oct 12th 2017, 14:18 |
inoas |
<3 |
| # |
Oct 12th 2017, 14:18 |
inoas |
Okay, that's good if it relys on that |
| # |
Oct 12th 2017, 14:18 |
admad |
it will actually show an error if say return type doesnt match docblock :slightly_smiling_face: |
| # |
Oct 12th 2017, 14:18 |
admad |
probably doesn't if you have proper typehints for args and return type |
| # |
Oct 12th 2017, 14:17 |
inoas |
(But I can make typos... and well :E) |
| # |
Oct 12th 2017, 14:17 |
inoas |
Fixing those now |
| # |
Oct 12th 2017, 14:17 |
inoas |
Does it require doc blocks? Because I still miss some |
| # |
Oct 12th 2017, 14:17 |
admad |
for normal app code special configs are rarely needed |
| # |
Oct 12th 2017, 14:16 |
dereuromark |
and cakephp code not either :slightly_smiling_face: thats life |
| # |
Oct 12th 2017, 14:16 |
dereuromark |
well, its not perfect |
| # |
Oct 12th 2017, 14:16 |
inoas |
but thanks for pointing out |
| # |
Oct 12th 2017, 14:16 |
inoas |
https://github.com/dereuromark/cakephp-ide-helper/blob/master/tests/phpstan.neon ... configuration again |
| # |
Oct 12th 2017, 14:16 |
dereuromark |
yeah downloading that is probably much easier |
| # |
Oct 12th 2017, 14:15 |
admad |
locally i wouldn't even bother using composer, just it's phar |
| # |
Oct 12th 2017, 14:15 |
dereuromark |
locally anyway |
| # |
Oct 12th 2017, 14:15 |
dereuromark |
This is a trick not to have to composer require it :slightly_smiling_face: https://github.com/dereuromark/cakephp-ide-helper/blob/master/composer.json#L53-L54 |
| # |
Oct 12th 2017, 14:13 |
inoas |
using final/private wherever possible |
| # |
Oct 12th 2017, 14:13 |
inoas |
no typehints, no return types, no strict declare, often missing doc blocks, some outdated code, unit tests not to speak off |
| # |
Oct 12th 2017, 14:12 |
inoas |
and whenever there are bugs, the first thing we ask: "did you run phpstan" hehe |
| # |
Oct 12th 2017, 14:12 |
dereuromark |
make it a plugin |
| # |
Oct 12th 2017, 14:12 |
inoas |
so people can do bin/cake phpstan heh |
| # |
Oct 12th 2017, 14:12 |
dereuromark |
bin/cake phpstan |
| # |
Oct 12th 2017, 14:12 |
inoas |
it would be nice in the core heh |