| # |
Oct 12th 2017, 14:18 |
 admad |
probably doesn't if you have proper typehints for args and return type |
| # |
Oct 12th 2017, 14:17 |
inoas |
(But I can make typos... and well :E) |
| # |
Oct 12th 2017, 14:17 |
inoas |
Fixing those now |
| # |
Oct 12th 2017, 14:17 |
inoas |
Does it require doc blocks? Because I still miss some |
| # |
Oct 12th 2017, 14:17 |
admad |
for normal app code special configs are rarely needed |
| # |
Oct 12th 2017, 14:16 |
dereuromark |
and cakephp code not either :slightly_smiling_face: thats life |
| # |
Oct 12th 2017, 14:16 |
dereuromark |
well, its not perfect |
| # |
Oct 12th 2017, 14:16 |
inoas |
but thanks for pointing out |
| # |
Oct 12th 2017, 14:16 |
inoas |
https://github.com/dereuromark/cakephp-ide-helper/blob/master/tests/phpstan.neon ... configuration again |
| # |
Oct 12th 2017, 14:16 |
dereuromark |
yeah downloading that is probably much easier |
| # |
Oct 12th 2017, 14:15 |
admad |
locally i wouldn't even bother using composer, just it's phar |
| # |
Oct 12th 2017, 14:15 |
dereuromark |
locally anyway |
| # |
Oct 12th 2017, 14:15 |
dereuromark |
This is a trick not to have to composer require it :slightly_smiling_face: https://github.com/dereuromark/cakephp-ide-helper/blob/master/composer.json#L53-L54 |
| # |
Oct 12th 2017, 14:13 |
inoas |
using final/private wherever possible |
| # |
Oct 12th 2017, 14:13 |
inoas |
no typehints, no return types, no strict declare, often missing doc blocks, some outdated code, unit tests not to speak off |
| # |
Oct 12th 2017, 14:12 |
inoas |
and whenever there are bugs, the first thing we ask: "did you run phpstan" hehe |
| # |
Oct 12th 2017, 14:12 |
dereuromark |
make it a plugin |
| # |
Oct 12th 2017, 14:12 |
inoas |
so people can do bin/cake phpstan heh |
| # |
Oct 12th 2017, 14:12 |
dereuromark |
bin/cake phpstan |
| # |
Oct 12th 2017, 14:12 |
inoas |
it would be nice in the core heh |
| # |
Oct 12th 2017, 14:12 |
dereuromark |
haha |
| # |
Oct 12th 2017, 14:12 |
inoas |
yeah ;) |
| # |
Oct 12th 2017, 14:12 |
inoas |
will phpstan be added to cake as a shell? |
| # |
Oct 12th 2017, 14:12 |
dereuromark |
ionas: you can make shell wrapper if that makes you feel better |
| # |
Oct 12th 2017, 14:11 |
admad |
run it on commit hook or as part of your CI/CD |
| # |
Oct 12th 2017, 14:11 |
admad |
don't need a silly editor plugin to run one command |
| # |
Oct 12th 2017, 14:11 |
admad |
download and run phar |
| # |
Oct 12th 2017, 14:10 |
inoas |
but I will add it to my list of "todos" (sooo long) |
| # |
Oct 12th 2017, 14:10 |
inoas |
no package for atom :E |
| # |
Oct 12th 2017, 14:10 |
inoas |
phpstan hmm ok |
| # |
Oct 12th 2017, 14:09 |
inoas |
admad that's good news :trollfacE: |
| # |
Oct 12th 2017, 14:09 |
admad |
yes was gonna add that |
| # |
Oct 12th 2017, 14:09 |
dereuromark |
phpstan also does help a lot :slightly_smiling_face: |
| # |
Oct 12th 2017, 14:09 |
admad |
your app might have bugs fixable/avoidable through strict types but cake core doesn't :P |
| # |
Oct 12th 2017, 14:07 |
inoas |
those type hints help a lot |
| # |
Oct 12th 2017, 14:07 |
inoas |
I hope we don't delay 4.x too much - after 3.6 it should happen |
| # |
Oct 12th 2017, 14:07 |
inoas |
already found 2 bugs :> |
| # |
Oct 12th 2017, 14:06 |
inoas |
upgrading my app to 7.1 using strict types... |
| # |
Oct 12th 2017, 14:05 |
adriencs |
yes |
| # |
Oct 12th 2017, 13:58 |
saeideng |
can you do on mysql? |
| # |
Oct 12th 2017, 13:55 |
adriencs |
can I do like `INNER JOIN (SELECT ... ) AS foo ON ( ... )` with the query builder ? |