| # |
Jul 25th 2017, 11:12 |
inoas |
at least your income will go up :p |
| # |
Jul 25th 2017, 11:11 |
inoas |
;-) |
| # |
Jul 25th 2017, 11:11 |
inoas |
haha |
| # |
Jul 25th 2017, 11:11 |
inoas |
now sounds like you want to really do java ;p (and by the way, on the typing thing I am with you... strict typing is good stuff) |
| # |
Jul 25th 2017, 11:11 |
 neon1024 |
Perhaps I should move from PHP to Java |
| # |
Jul 25th 2017, 11:10 |
neon1024 |
$tableNameString |
| # |
Jul 25th 2017, 11:10 |
neon1024 |
I often name variables with type as well |
| # |
Jul 25th 2017, 11:10 |
neon1024 |
‘I am taking this thing and doing this to it’ |
| # |
Jul 25th 2017, 11:10 |
neon1024 |
I want my code to speak to me |
| # |
Jul 25th 2017, 11:10 |
neon1024 |
and I am not a robot, I’m just lazy |
| # |
Jul 25th 2017, 11:10 |
neon1024 |
I don’t agree with that unfortunatly |
| # |
Jul 25th 2017, 11:07 |
inoas |
unambigouous (hope that's right) |
| # |
Jul 25th 2017, 11:06 |
inoas |
as I said, you are NOT a robot and reading $this->request->data('Author') is umabigious ... and also correctly typed now that magic methods are gone |
| # |
Jul 25th 2017, 11:05 |
neon1024 |
I guess we’ll see what the choice is in the RFC :slightly_smiling_face: |
| # |
Jul 25th 2017, 11:04 |
neon1024 |
Reading will be less effort for me, as the code tells me what it’s doing just by reading it |
| # |
Jul 25th 2017, 11:04 |
inoas |
;-) |
| # |
Jul 25th 2017, 11:04 |
neon1024 |
Worried you’ll wear away your fingerprints? :slightly_smiling_face: |
| # |
Jul 25th 2017, 11:04 |
neon1024 |
lol |
| # |
Jul 25th 2017, 11:03 |
inoas |
and the other consequence will be that we add setters/getters everywhere and reading/writing code will be a lot more work |
| # |
Jul 25th 2017, 11:03 |
inoas |
The consequence will be that the query builder will be excempted and we will have inconsistency... the reasons being: deprecation of magic method is easier (markstory) and PSR7 enforces get verbosity even on immutable objects (as it seems, which seems to be bad design in PSR7) |
| # |
Jul 25th 2017, 11:02 |
inoas |
I am not catching the train now ;)) |
| # |
Jul 25th 2017, 11:01 |
neon1024 |
It’s worthwhile to discuss though |
| # |
Jul 25th 2017, 11:01 |
inoas |
what?;) |
| # |
Jul 25th 2017, 11:01 |
neon1024 |
Not all RFC’s get supported |
| # |
Jul 25th 2017, 11:01 |
neon1024 |
You need to stay involved with the discussion. |
| # |
Jul 25th 2017, 11:01 |
inoas |
anyway |
| # |
Jul 25th 2017, 11:01 |
inoas |
and (even if PSR7 says otherwise) there is no reason to prefix get to get values out of a immutable object |
| # |
Jul 25th 2017, 11:00 |
inoas |
you would ue with to clone - all good |
| # |
Jul 25th 2017, 11:00 |
neon1024 |
As with PSR7 |
| # |
Jul 25th 2017, 11:00 |
neon1024 |
No, you’d use with |
| # |
Jul 25th 2017, 11:00 |
inoas |
I am not calling you a robot, I am saying we are NOT robots |
| # |
Jul 25th 2017, 11:00 |
inoas |
if you are working with immutable objects there is really no reason to add "get" |
| # |
Jul 25th 2017, 11:00 |
neon1024 |
I don’t think calling me a robot is productive discussion :slightly_smiling_face: |
| # |
Jul 25th 2017, 11:00 |
inoas |
robots do not |
| # |
Jul 25th 2017, 10:59 |
inoas |
cause humans understand context |
| # |
Jul 25th 2017, 10:59 |
neon1024 |
You’ve swapped my example to the query class |
| # |
Jul 25th 2017, 10:59 |
inoas |
yes |
| # |
Jul 25th 2017, 10:59 |
neon1024 |
You’ve added context already |
| # |
Jul 25th 2017, 10:59 |
inoas |
where $query->getWhereClause() does not |
| # |
Jul 25th 2017, 10:59 |
inoas |
if you are a robot then you should not code... you do not need a docblock do know that $query->stuff() modifies the query |
| # |
Jul 25th 2017, 10:59 |
neon1024 |
(shrug) |