| # |
Jul 24th 2017, 15:00 |
inoas |
I'd love that |
| # |
Jul 24th 2017, 15:00 |
inoas |
if we want to go ahead - pick php 7.1 now |
| # |
Jul 24th 2017, 15:00 |
inoas |
yeah, think about it, come on! ;) |
| # |
Jul 24th 2017, 15:00 |
 dereuromark |
oh come on, |
| # |
Jul 24th 2017, 15:00 |
inoas |
verbosity kills productivity |
| # |
Jul 24th 2017, 14:59 |
inoas |
there is a 500 chars reading issue on big source code |
| # |
Jul 24th 2017, 14:59 |
inoas |
there is no 3 char issue |
| # |
Jul 24th 2017, 14:59 |
inoas |
anyway, grouping stateful objects into 3 kinds: builders, readers and vanilla objects is a very consistent concept |
| # |
Jul 24th 2017, 14:59 |
dereuromark |
also: lets for once lead by example and not run behind the others for years. We might be able to have a clear, PHP7 supportive API rather sooner than later even. |
| # |
Jul 24th 2017, 14:59 |
dereuromark |
it is :slightly_smiling_face: by not limiting yourself to a 3char issue |
| # |
Jul 24th 2017, 14:59 |
inoas |
most other code and libraries are concise and verbose? <= how is that possible at the same time ;)? |
| # |
Jul 24th 2017, 14:58 |
dereuromark |
ionas: you are wrong IMO, most other code and libraries are already concise and verbose here. they all use explicit getters and setters, and I would not use laravel for reference here though :slightly_smiling_face: |
| # |
Jul 24th 2017, 14:57 |
inoas |
$immutableRequest->data() is unambigious |
| # |
Jul 24th 2017, 14:56 |
inoas |
$queryBuilder->where() really is unambigouous |
| # |
Jul 24th 2017, 14:56 |
inoas |
if you do not use an IDE then that is you (mine ;-) choice ... but if you do you can click the class and also you should know what context an object works in... maybe builders should be called builders |
| # |
Jul 24th 2017, 14:55 |
jeremyharris |
that’s why I brought up the marketing aspect. unfortunately, it’s part of the whole deal |
| # |
Jul 24th 2017, 14:55 |
inoas |
tbh |
| # |
Jul 24th 2017, 14:55 |
inoas |
and dereuromark the barrier will not go down... people will see the verbosity and walk to laravel. |
| # |
Jul 24th 2017, 14:54 |
inoas |
I don't want to diminish the work being done to have a consistent API across all of Cake - I think that's very important. <= leaving out set or get PER class or there doesnt make it inconsistent - magic setters/getters may do ... and they are luckly gone |
| # |
Jul 24th 2017, 14:53 |
inoas |
yeah all I am saying is - me neither ;-) |
| # |
Jul 24th 2017, 14:53 |
jeremyharris |
I wasn’t suggesting that :slightly_smiling_face: |
| # |
Jul 24th 2017, 14:53 |
inoas |
so no work is wasted! |
| # |
Jul 24th 2017, 14:53 |
inoas |
@jeremyharris https://github.com/cakephp/cakephp/issues/10930#issuecomment-317447201 I did not want to - in any way - reverse the removal of magic getters/setters |
| # |
Jul 24th 2017, 14:52 |
jeremyharris |
you could go with a less strict regexp that allows [0-9a-f] for all the chunks |
| # |
Jul 24th 2017, 14:52 |
inoas |
I am just testing for strlen 36 now as long as the other side doesn't fix their broken uuids ;) |
| # |
Jul 24th 2017, 14:51 |
inoas |
which is all good @ jeremy :) |
| # |
Jul 24th 2017, 14:51 |
inoas |
the uuid is invalid it seems |
| # |
Jul 24th 2017, 14:45 |
jeremyharris |
save allowing a 0 as the first char of the 4th part |
| # |
Jul 24th 2017, 14:45 |
jeremyharris |
looks like the validator also applies that strict regexp |
| # |
Jul 24th 2017, 14:44 |
cleptric |
And it’s false on both |
| # |
Jul 24th 2017, 14:44 |
cleptric |
Cake 2 and 3 uses the same regex for uuid matching |
| # |
Jul 24th 2017, 14:43 |
lorenzo |
nervermind, I counted incorrectly the number of chars |
| # |
Jul 24th 2017, 14:43 |
jeremyharris |
according to this SO post which is a regexp based on the RFC, the 4th part fails as it starts with 3, not [89ab] https://stackoverflow.com/questions/7905929/how-to-test-valid-uuid-guid |
| # |
Jul 24th 2017, 14:42 |
lorenzo |
does not look like a cake 2 uuid |
| # |
Jul 24th 2017, 14:37 |
inoas |
can someone in a Cakephp2 project replicate: call debug(Validation::uuid('0ff94cdc-70fe-45fe-3279-6345fc757763')) returning false? |
| # |
Jul 24th 2017, 12:51 |
birdy247 |
I tried beforeSave aslo |
| # |
Jul 24th 2017, 12:51 |
birdy247 |
right |
| # |
Jul 24th 2017, 12:50 |
lorenzo |
@birdy247 |
| # |
Jul 24th 2017, 12:50 |
lorenzo |
maybe not the beforeMarshal, but 100% sure it is used for saving |
| # |
Jul 24th 2017, 12:50 |
lorenzo |
I’m pretty certain the join table is used for saving |
| # |
Jul 24th 2017, 12:50 |
sonu_nk |
ah got it |