| # |
Jul 19th 2017, 15:51 |
 jeremyharris |
inoas yes I’m afraid of the verbosity as well. we’ve discussed validating like that, which I’m more in support for, however it doesn’t solve one of the key problems which is misspelled optional *keys* (e.g., cagetory instead of category). In a discussion I actually brought up this simple validation technique and was called out on the misspelled keys problem, something I totally didn’t think about :slightly_smiling_face: |
| # |
Jul 19th 2017, 15:51 |
inoas |
set it to warn by default so that developers get notified by default but their apps do not break |
| # |
Jul 19th 2017, 15:51 |
inoas |
'warn' and 'exception' |
| # |
Jul 19th 2017, 15:51 |
inoas |
dereuromark https://github.com/cakephp/cakephp/issues/10723#issuecomment-316429214 - opt-in flag I'd do 3 states: 'ignore', |
| # |
Jul 19th 2017, 15:35 |
inoas |
I am not a pro on php errors but maybe that means it cannot find I18n at all |
| # |
Jul 19th 2017, 15:35 |
inoas |
check I18n if there is a insertArgs at all |
| # |
Jul 19th 2017, 15:35 |
inoas |
and updating cakephp to 2.9 |
| # |
Jul 19th 2017, 15:35 |
inoas |
and setting up a good environment with the recommended php version (like 5.6) there |
| # |
Jul 19th 2017, 15:34 |
inoas |
domgeek what I would try is cakebox or homestead or puphpet.net |
| # |
Jul 19th 2017, 15:34 |
inoas |
for anything else I like the new setters/getters |
| # |
Jul 19th 2017, 15:34 |
inoas |
jeremyharris its ok! you are not obligated to do anything and I respect that 101%! I am just a bit afraid on ultra verbose setters for $options and query building |
| # |
Jul 19th 2017, 15:33 |
jeremyharris |
Inoas not ignoring you, I had some morning chores to do. I'll get back to you in a bit when I'm done with them :) |
| # |
Jul 19th 2017, 15:33 |
inoas |
also did you try to switch debug on and off like https://github.com/cakephp/cakephp/issues/6072#issuecomment-80942582 suggested |
| # |
Jul 19th 2017, 15:33 |
neon1024 |
@domgeek I would recommend rephrasing your question, or providing more information. |
| # |
Jul 19th 2017, 15:33 |
inoas |
then ./Console/cakeshell |
| # |
Jul 19th 2017, 15:32 |
inoas |
domgeek tbh, I can't help you either but I would first do cd /var/www/tender.ng/public_html/app/ |
| # |
Jul 19th 2017, 15:31 |
inoas |
maybe a warning in the console could help |
| # |
Jul 19th 2017, 15:31 |
domgeek |
@all |
| # |
Jul 19th 2017, 15:30 |
inoas |
@dereuromark I don't think adding more magic to a "broken" behavior that mysql <5.7 suggested to use is a good thing in the core ;) @ https://github.com/cakephp/cakephp/issues/10723#issuecomment-316423873 |
| # |
Jul 19th 2017, 15:30 |
domgeek |
please is there any other group where i can ask my question ? |
| # |
Jul 19th 2017, 15:30 |
neon1024 |
My value objects only usually have a few things, so I guess it’s easier for me to say new OptionsThingy($foo, $bar, $baz); |
| # |
Jul 19th 2017, 15:30 |
neon1024 |
I see what you mean now |
| # |
Jul 19th 2017, 15:29 |
inoas |
options can be build up gradually so personally I'd rather check them on consumption, but that has flaws took, so yeah some checks could be done on __construct of a value object - good idea |
| # |
Jul 19th 2017, 15:29 |
inoas |
like this? https://github.com/cakephp/cakephp/issues/10866#issuecomment-313391901 :p |
| # |
Jul 19th 2017, 15:29 |
neon1024 |
Well if it’s a value object surely the constructor just checks the params? |
| # |
Jul 19th 2017, 15:28 |
neon1024 |
The only down side I have with value objects is they make the api look really complex when calling methods |
| # |
Jul 19th 2017, 15:28 |
inoas |
I can understand the desire of the IDE folks but the problem is that burzums config object to me doesn't do a good job on making sure the options "object" is in a well formed state that can be consumed |
| # |
Jul 19th 2017, 15:28 |
neon1024 |
Perhaps I’ll spend some time properly reading the stuff :slightly_smiling_face: |
| # |
Jul 19th 2017, 15:27 |
inoas |
well that's not where I would go... sadly |
| # |
Jul 19th 2017, 15:27 |
neon1024 |
I like being able to type hint against them :slightly_smiling_face: |
| # |
Jul 19th 2017, 15:27 |
neon1024 |
I’m all in favour of value objects |
| # |
Jul 19th 2017, 15:27 |
inoas |
or forgetting one, or having some that used to do things but now do not do them anymore |
| # |
Jul 19th 2017, 15:27 |
inoas |
you never have the problem of miss-typing a hashkey and not realizing again |
| # |
Jul 19th 2017, 15:27 |
inoas |
After that it is easy to use $options as you can rely on them |
| # |
Jul 19th 2017, 15:26 |
inoas |
neon1024 all I am saying is you push $options into a function that takes an option object (basically an array) and the method/function then runs it through a small schema validator. |
| # |
Jul 19th 2017, 15:26 |
domgeek |
https://github.com/cakephp/cakephp/issues/6072 please check this out |
| # |
Jul 19th 2017, 15:24 |
neon1024 |
Go well my brainy friend! ;) |
| # |
Jul 19th 2017, 15:24 |
neon1024 |
Geez Ionas, you’re so far ahead of me on these things. I don’t even understand half of it! |
| # |
Jul 19th 2017, 15:19 |
inoas |
domgeek I am not sure I can help you (or we can) but can you repost the gist with issue |
| # |
Jul 19th 2017, 15:19 |
inoas |
and this is what I fear... and there hasn't been really a clear statement where this will go https://github.com/cakephp/cakephp/issues/10866#issuecomment-313391901 |
| # |
Jul 19th 2017, 15:19 |
domgeek |
sorry to have tagged them but i posted this same post earlier on.. nobody replied me :sad: |