| # |
Jul 18th 2017, 16:16 |
 ericadeefox |
^^I did that. at the beginning of the method in the app, I have `if (empty(filter_input(INPUT_SERVER, 'QUERY_STRING')))`, which in `debug()` turned up true |
| # |
Jul 18th 2017, 16:15 |
ericadeefox |
nope. just trying to `$this->get()` a url w query string params |
| # |
Jul 18th 2017, 16:15 |
jeremyharris |
throw a debug in the integration test after build request happens; it might be building the request correctly but the app itself is doing something |
| # |
Jul 18th 2017, 16:14 |
jeremyharris |
nope, it’s a pretty standard test. do you have any components prg, or anything else playing with query params? |
| # |
Jul 18th 2017, 16:13 |
ericadeefox |
do you do anything with `$this->_url()` in those tests at all? because, in my tests, `?query=string` is just outright ignored. it says there is no query string params set, when I debug. |
| # |
Jul 18th 2017, 16:10 |
ericadeefox |
x_x "this is a different" |
| # |
Jul 18th 2017, 16:09 |
ericadeefox |
and then the the query string parameters are f-- |
| # |
Jul 18th 2017, 16:09 |
jeremyharris |
yup |
| # |
Jul 18th 2017, 16:09 |
ericadeefox |
welp. you mean, like, `$this->get('/controller/view?query=string')`? |
| # |
Jul 18th 2017, 16:08 |
jeremyharris |
I have several tests that do that |
| # |
Jul 18th 2017, 16:08 |
ericadeefox |
should it?! omg |
| # |
Jul 18th 2017, 16:08 |
jeremyharris |
it should :slightly_smiling_face: |
| # |
Jul 18th 2017, 16:07 |
ericadeefox |
trying to test a method that involves use of query string parameters. looks like just throwing the params in `get()` doesn't work, heh |
| # |
Jul 18th 2017, 15:56 |
dereuromark |
good to know |
| # |
Jul 18th 2017, 15:56 |
jeremyharris |
you can also say “oneself” |
| # |
Jul 18th 2017, 15:56 |
cleptric |
I asked mark that question at cakefest and he told me, that’s right when you don’t know the gender :slightly_smiling_face: |
| # |
Jul 18th 2017, 15:55 |
neon1024 |
I think so, as ‘them’ is one or more |
| # |
Jul 18th 2017, 15:55 |
neon1024 |
Er, good question :P |
| # |
Jul 18th 2017, 15:55 |
jeremyharris |
‘tis |
| # |
Jul 18th 2017, 15:54 |
dereuromark |
@neon1024 Is that proper english? interesting |
| # |
Jul 18th 2017, 15:38 |
mic_ |
as that will make the upgrade cost significantly smaller - while still giving both security and features to the frontend that customers use and that actually gets traffic. |
| # |
Jul 18th 2017, 15:37 |
mic_ |
anyway, thanks for your input mikesmoniker and cleptric. I will seriously investigate the option of full frontend and backend separation. |
| # |
Jul 18th 2017, 15:37 |
genellern |
Unless you need them often, like if you add clients to your app and each client with its database, then you'll need some basic database configuration, and put that sensitive data in your env, so it's never in your code/repo |
| # |
Jul 18th 2017, 15:36 |
mic_ |
mikesmoniker: you are right, although the project is constrained by funds, so I am trying to find the best possible way of tacking the problem. I know it lacks elegance and simplicity, but sometimes it's all one can get :S |
| # |
Jul 18th 2017, 15:35 |
cleptric |
mic_ :slightly_smiling_face: |
| # |
Jul 18th 2017, 15:34 |
dereuromark |
@genellern the danger of this is that you put business or even sensitive data into those for production systems. And those will be forever tracked in git then. |
| # |
Jul 18th 2017, 15:34 |
jeremyharris |
@genellern yeah that’s their only real use at the moment |
| # |
Jul 18th 2017, 15:34 |
mic_ |
cleptric: I think your comment earned a beer. I can actually do a frontend in 3.x and be PHP7 friendly whereas backend can run in a fully fenced env with old PHP |
| # |
Jul 18th 2017, 15:34 |
mikesmoniker |
mic_ I’d question the value of that, personally, but yeah.. I’d be looking to freezing a 1x/2x codebase save for security/bug fixes and port it to 3. You’ll end up with better code, anyway, since more things will be done the “3x way” vs. relying on shims, deprecated APIs, hacks, etc. |
| # |
Jul 18th 2017, 15:34 |
genellern |
Ah, yeah, that's true, I use for initial database configuration |
| # |
Jul 18th 2017, 15:33 |
jeremyharris |
running seeds runs all of them |
| # |
Jul 18th 2017, 15:33 |
jeremyharris |
they just aren’t |
| # |
Jul 18th 2017, 15:32 |
genellern |
@jeremyharris Why can't you track seeds? I never heard of an issue related |
| # |
Jul 18th 2017, 15:32 |
cleptric |
mic_ Guys like @savant suggests doing partial upgrades and running a 3.x and a older version in parallel. |
| # |
Jul 18th 2017, 15:32 |
mic_ |
mikesmoniker: the other option is 1.2->1.3 and life support on PHP - and maybe from scratch 3.x. |
| # |
Jul 18th 2017, 15:31 |
jeremyharris |
although I’m not a fan of it |
| # |
Jul 18th 2017, 15:31 |
paul_83uk |
I've just discovered that if you set a cookie but then the controller method never completes (redirected due to SAML authentication) the cookie never gets set. Is this expected behaviour? If so I will raise an issue with the docs. :slightly_smiling_face: |
| # |
Jul 18th 2017, 15:31 |
jeremyharris |
for now I admit I bake a fresh migration specifically for adding data sometimes (e.g., a new user group or something that has no admin backend) |
| # |
Jul 18th 2017, 15:31 |
mikesmoniker |
mic_: We looked at 2->3 for one of our apps (many dozens of models, actions, etc.) and it looked pretty bad. We ended up not doing it. The big bottlenecks where updating all the DB queries/hooks/etc. and investigating/updating plugins. |
| # |
Jul 18th 2017, 15:31 |
mic_ |
cleptric: yes, I know. I have a bunch of apps running 1.2/1.3 and then 3.x. To put numbers: the app is ca. 27k lines (controller, model etc.). I wanted 1.2->1.3, as that would make 1.3->2.10 easier (and that opens road to PHP7) |
| # |
Jul 18th 2017, 15:30 |
jeremyharris |
I *wish* seeds were tracked like migrations. that’d be an amazing feature imo, keep the schema/data separate |