| # |
Jul 13th 2017, 10:49 |
 neon1024 |
Confused myself here I think! |
| # |
Jul 13th 2017, 10:48 |
neon1024 |
Hah, well, let’s hope not ;) |
| # |
Jul 13th 2017, 10:48 |
savant |
unless you’re doing something stupid like reassigning it to a client. |
| # |
Jul 13th 2017, 10:48 |
neon1024 |
Cool, thanks guys :thumbsup: |
| # |
Jul 13th 2017, 10:47 |
savant |
basically 100% of the time |
| # |
Jul 13th 2017, 10:47 |
savant |
ServerRequest is used in the dispatch cycle |
| # |
Jul 13th 2017, 10:47 |
neon1024 |
Right, so *most* of the time when I’m in a controllers request it’s a PSR7 type ServerRequest then right? |
| # |
Jul 13th 2017, 10:47 |
savant |
a the client\request is what you do to make get/post/put/delete calls to other services |
| # |
Jul 13th 2017, 10:47 |
savant |
ServerRequest versus Client\Request |
| # |
Jul 13th 2017, 10:47 |
dereuromark |
thus two different classes, dispatcher request (server) vs request (client) |
| # |
Jul 13th 2017, 10:46 |
neon1024 |
Yes I am, that’s what I’m hoping for clarity :) |
| # |
Jul 13th 2017, 10:46 |
dereuromark |
you are confusing two things, the request of cake as a whole and a client request like a curl call |
| # |
Jul 13th 2017, 10:46 |
savant |
no thats right |
| # |
Jul 13th 2017, 10:45 |
neon1024 |
So is this wrong? https://github.com/cakephp/cakephp/blob/master/src/Controller/Controller.php#L125 |
| # |
Jul 13th 2017, 10:45 |
savant |
all the psr refactors made this a bit muddled. |
| # |
Jul 13th 2017, 10:45 |
savant |
there is Cake\Http\Client\Request |
| # |
Jul 13th 2017, 10:44 |
savant |
no such thing as Cake\Http\Request |
| # |
Jul 13th 2017, 10:44 |
dereuromark |
No, Cake\Http\Client\Request |
| # |
Jul 13th 2017, 10:44 |
savant |
https://github.com/cakephp/cakephp/blob/master/src/Network/Request.php |
| # |
Jul 13th 2017, 10:44 |
neon1024 |
Which then means, wtf is \Cake\Http\Request all about |
| # |
Jul 13th 2017, 10:44 |
neon1024 |
Ahh, I see, so the alias is \Cake\Network\Request -> \Cake\Http\ServerRequest |
| # |
Jul 13th 2017, 10:43 |
neon1024 |
Are you sure that’s not between \Cake\Network\Request and \Cake\Http\Request |
| # |
Jul 13th 2017, 10:43 |
savant |
class_alias |
| # |
Jul 13th 2017, 10:43 |
neon1024 |
Is there some inheritance here? |
| # |
Jul 13th 2017, 10:43 |
neon1024 |
`\Cake\Http\Request` vs `\Cake\Http\ServerRequest` |
| # |
Jul 13th 2017, 10:42 |
neon1024 |
Just a random question, simple one. |
| # |
Jul 13th 2017, 10:38 |
neon1024 |
Yes, good idea |
| # |
Jul 13th 2017, 10:37 |
savant |
maybe your component could have a getSession() method |
| # |
Jul 13th 2017, 10:37 |
neon1024 |
That’s in a Component I’m refactoring |
| # |
Jul 13th 2017, 10:37 |
neon1024 |
Why it’s not `$this->getController()->getRequest()->getSession()->write()` |
| # |
Jul 13th 2017, 10:37 |
savant |
where is that from |
| # |
Jul 13th 2017, 10:37 |
neon1024 |
Mmm, lengthy. `$this->getController()->request->session()->write('et', $this->getController()->request->getQuery('et'));` |
| # |
Jul 13th 2017, 10:09 |
spriz |
This is gold to get all those missing annotations! https://github.com/dereuromark/cakephp-ide-helper |
| # |
Jul 13th 2017, 09:44 |
saeideng |
:+1: |
| # |
Jul 13th 2017, 09:43 |
saeideng |
OH |
| # |
Jul 13th 2017, 09:42 |
savant |
https://github.com/cakephp/app/pull/460 |
| # |
Jul 13th 2017, 09:42 |
cleptric |
But we changed this in the skeleton app too, to set it back tp +2 Minute if debug is on |
| # |
Jul 13th 2017, 09:42 |
cleptric |
Yes |
| # |
Jul 13th 2017, 09:42 |
saeideng |
thats true? |
| # |
Jul 13th 2017, 09:42 |
saeideng |
https://github.com/cakephp/app/compare/3.2.5...3.4.2 |
| # |
Jul 13th 2017, 09:41 |
saeideng |
_cake_core_' duration changed from '+2 minutes', to '+1 years', |