| # |
Jun 28th 2017, 04:07 |
 tariquesani |
That is good!! |
| # |
Jun 28th 2017, 04:07 |
markstory |
I looked -- https://github.com/cakephp/phinx says 72% |
| # |
Jun 28th 2017, 04:07 |
tariquesani |
Gawd! you borked the tests? |
| # |
Jun 28th 2017, 04:07 |
markstory |
We have a bunch of example in cake |
| # |
Jun 28th 2017, 04:07 |
markstory |
@savant @xuding You are right about extending ObjectRegistry to make a service locator |
| # |
Jun 28th 2017, 04:06 |
savant |
Let's not talk about tests, @admad hates me atm |
| # |
Jun 28th 2017, 04:06 |
savant |
Haven't looked |
| # |
Jun 28th 2017, 04:06 |
tariquesani |
Yes, @savant that is a great way to get things going in projects. |
| # |
Jun 28th 2017, 04:05 |
tariquesani |
Being lazy here, what kind of unit test code coverage do we have currently? |
| # |
Jun 28th 2017, 04:04 |
savant |
Once we have that, we can decide on a next release and future plans I think |
| # |
Jun 28th 2017, 04:04 |
savant |
Have done this sort of thing before for a ton of oss projects, but this works pretty well in my experience |
| # |
Jun 28th 2017, 04:04 |
savant |
Then read through the pull requests to close dead ones, bump those that need fixes/tests, or triage the good ones for merge |
| # |
Jun 28th 2017, 04:03 |
savant |
Then reread again with the purpose of categorizing issues |
| # |
Jun 28th 2017, 04:03 |
savant |
@tariquesani my plan after more or less rewriting CrudView this week is to read through every issue |
| # |
Jun 28th 2017, 04:01 |
admad |
Don't think there is one yet. The project was transferred just few days ago. Might be a while b4 the future plan of attack is ready. |
| # |
Jun 28th 2017, 03:53 |
tariquesani |
@savant @admad I heard that Phinx needs some help... Is there a ToDo list? |
| # |
Jun 28th 2017, 03:34 |
xuding |
:tired_face: @admad |
| # |
Jun 28th 2017, 03:06 |
admad |
@xuding you have 1 week to deliver or no more support for you in here |
| # |
Jun 28th 2017, 02:15 |
xuding |
thanks! |
| # |
Jun 28th 2017, 02:15 |
savant |
ha |
| # |
Jun 28th 2017, 02:15 |
xuding |
but you can steal my idea if I did not deliver fast enough |
| # |
Jun 28th 2017, 02:15 |
savant |
great! |
| # |
Jun 28th 2017, 02:15 |
xuding |
I am going to |
| # |
Jun 28th 2017, 02:14 |
savant |
are you going to write it or do you want me to? |
| # |
Jun 28th 2017, 02:14 |
savant |
just extend the ObjectRegistry class: https://github.com/cakephp/cakephp/blob/master/src/Core/ObjectRegistry.php |
| # |
Jun 28th 2017, 02:14 |
xuding |
I think this makes an awsome blog post! |
| # |
Jun 28th 2017, 02:14 |
xuding |
right! |
| # |
Jun 28th 2017, 02:14 |
savant |
you can return any QueueEngine from it |
| # |
Jun 28th 2017, 02:14 |
savant |
https://github.com/josegonzalez/cakephp-queuesadilla/blob/master/src/Queue/QueueEngineRegistry.php |
| # |
Jun 28th 2017, 02:14 |
savant |
I made one for Queuesadilla |
| # |
Jun 28th 2017, 02:14 |
xuding |
Yea, I think you make a valid point |
| # |
Jun 28th 2017, 02:13 |
savant |
`ServiceRegistry` |
| # |
Jun 28th 2017, 02:13 |
xuding |
“service class” :slightly_smiling_face: |
| # |
Jun 28th 2017, 02:13 |
savant |
what kind of object? |
| # |
Jun 28th 2017, 02:13 |
xuding |
just a object |
| # |
Jun 28th 2017, 02:13 |
savant |
what does `makeDeleteProductVariant()` return? |
| # |
Jun 28th 2017, 02:13 |
xuding |
yea, i understood that, just wonder how to do that using cakephp |
| # |
Jun 28th 2017, 02:13 |
savant |
for instance, here is a plugin that uses Ray.DI, by one of the core developers: https://github.com/lorenzo/piping-bag |
| # |
Jun 28th 2017, 02:12 |
savant |
we also dont stop you from using your own DIC |
| # |
Jun 28th 2017, 02:12 |
xuding |
which is serving as a service locator |
| # |
Jun 28th 2017, 02:12 |
xuding |
``` function makeDeleteProductVariant() ``` |