# |
Apr 28th 2017, 10:52 |
burzum |
Until I fixed what I just found my work mate has done :face_with_rolling_eyes: |
# |
Apr 28th 2017, 10:52 |
Neon1024 |
Thanks! |
# |
Apr 28th 2017, 10:52 |
burzum |
Some time next week maybe |
# |
Apr 28th 2017, 10:52 |
burzum |
I can put it in the plugin but not today |
# |
Apr 28th 2017, 10:51 |
burzum |
We have a helper for the filters by the way |
# |
Apr 28th 2017, 10:49 |
Neon1024 |
I might fork it then and make my changes :) |
# |
Apr 28th 2017, 10:49 |
Neon1024 |
I tend to treat stuff by you guys as pretty much fine |
# |
Apr 28th 2017, 10:49 |
Neon1024 |
Interesting |
# |
Apr 28th 2017, 10:47 |
burzum |
But until they come up with something related to this again I'll threat it like poison :slightly_smiling_face: |
# |
Apr 28th 2017, 10:46 |
burzum |
You could store the params in the browsers local storage for the site and apply them via JS probably as well. This should work across tabs. |
# |
Apr 28th 2017, 10:45 |
dereuromark |
fair enough |
# |
Apr 28th 2017, 10:44 |
inoas |
https://gist.github.com/inoas/660c7419ffe2c9bdb378c50880bc6d38#gistcomment-2077188 |
# |
Apr 28th 2017, 10:44 |
burzum |
If marketing ever figures this issue out it's going to be fun. But until then: Screw it. |
# |
Apr 28th 2017, 10:44 |
inoas |
How can I add multiple WHEN statements inside of case? |
# |
Apr 28th 2017, 10:44 |
burzum |
They don't want to pass around a hashed string in every single URL because it doesn't look good. Neither do I by the way. And I'm aware of the issues the implementation has but it's acceptable in our case. |
# |
Apr 28th 2017, 10:42 |
dereuromark |
;) nah, one day I will provide a plugin for this - belieeeeve meeeee - china |
# |
Apr 28th 2017, 10:41 |
burzum |
This crap is pain in the ass to deal with |
# |
Apr 28th 2017, 10:41 |
Neon1024 |
I’ll keep on it and see how I get on |
# |
Apr 28th 2017, 10:40 |
burzum |
I did a clear-all button |
# |
Apr 28th 2017, 10:40 |
Neon1024 |
Well I’ve also hit a snag where I can’t update the filter |
# |
Apr 28th 2017, 10:40 |
burzum |
Neon, you can have a clear button, don't ask me how I did it but we have one. We'll go live on monday evening if nothing bad happens. |
# |
Apr 28th 2017, 10:40 |
Neon1024 |
As if I clear the session, the component reapplies it afterwards |
# |
Apr 28th 2017, 10:39 |
Neon1024 |
Not sure they want it quite this ‘sticky’ though |
# |
Apr 28th 2017, 10:39 |
Neon1024 |
Hah |
# |
Apr 28th 2017, 10:39 |
burzum |
I'll forward you the Skype contacts, have fun discussing that issue with them |
# |
Apr 28th 2017, 10:39 |
Neon1024 |
Ironically, it’s also exactly what my account managers want |
# |
Apr 28th 2017, 10:38 |
burzum |
@dereuromark this is exactly what marketing wanted |
# |
Apr 28th 2017, 10:30 |
Neon1024 |
*you could |
# |
Apr 28th 2017, 10:29 |
Neon1024 |
Perhaps you contribute some ideas to the repository |
# |
Apr 28th 2017, 10:29 |
dereuromark |
q=abc123 => actuall [x=>y, ...] |
# |
Apr 28th 2017, 10:29 |
dereuromark |
you can even shorten them and internally normalize that into the actual query strings |
# |
Apr 28th 2017, 10:28 |
dereuromark |
persist it with URL query strings being passed between URLs |
# |
Apr 28th 2017, 10:28 |
Neon1024 |
I’d read that dereuromark! |
# |
Apr 28th 2017, 10:28 |
inoas |
haha ;) |
# |
Apr 28th 2017, 10:28 |
dereuromark |
the whole idea :slightly_smiling_face: I could probably rent on for 10 min about how bad it is to do it via session - but maybe I should just write a blog post on how this would be done in a more sane way. |
# |
Apr 28th 2017, 10:28 |
inoas |
gaga |
# |
Apr 28th 2017, 10:28 |
Neon1024 |
inoas: You’re saying burzum is an anti-pattern?! ;) |
# |
Apr 28th 2017, 10:27 |
inoas |
I think its burzums plugin |
# |
Apr 28th 2017, 10:27 |
inoas |
optin-in-all then removing maybe ^^ |
# |
Apr 28th 2017, 10:26 |
Neon1024 |
dereuromark, Which aspects of this design would you consider to be bad programming practise? |
# |
Apr 28th 2017, 10:25 |
dereuromark |
anti |