# |
Apr 21st 2017, 13:34 |
admad |
All i can tell you is read GH docs, i don't have time right now to walk you through the process |
# |
Apr 21st 2017, 13:34 |
juniorionut |
i usually make new branches for changes |
# |
Apr 21st 2017, 13:34 |
juniorionut |
so far no, relatively new to GH, read some doc , tried to use a fork but it game the message that everytrhing is merged |
# |
Apr 21st 2017, 13:34 |
admad |
i suggest you read GH docs on how to create a PR. |
# |
Apr 21st 2017, 13:33 |
admad |
two different branch names are not necessary, the master of your fork can be compared with master of main repo. Although its' good practice to always make a new branch for changes |
# |
Apr 21st 2017, 13:32 |
admad |
have you opened pull requests on GH before? :slightly_smiling_face: |
# |
Apr 21st 2017, 13:32 |
juniorionut |
You’ll need to use two different branch names to get a valid comparison. |
# |
Apr 21st 2017, 13:31 |
admad |
huh? |
# |
Apr 21st 2017, 13:31 |
juniorionut |
@admad, i cannot create a new PR, source and comparison branch are only master |
# |
Apr 21st 2017, 13:30 |
technofection |
For example, Persons hasMany PhoneNumbers, when if I fetch a person entity by doing Persons->get(), then how do I exactly, inject a new number in the PhoneNumbers associated model? |
# |
Apr 21st 2017, 13:29 |
technofection |
Can anyone tell how to patch an entity and insert a new record in hasMany associated model ? |
# |
Apr 21st 2017, 13:28 |
admad |
though it should work with `checkAuthIn => Controller.initialize` too |
# |
Apr 21st 2017, 13:26 |
admad |
you need to use that config only if trying to check auth info in beforeFilter(), which i doubt you are |
# |
Apr 21st 2017, 13:25 |
hmic |
admad: i'm just struggling with jwt, if using checkAuthIn => Controller.initialize like in your git readme, it does not work, so allows everything. without checkAuthIn it works like i would have expected. am i wrong? cake-3.4.5 btw. |
# |
Apr 21st 2017, 13:24 |
juniorionut |
make sense :slightly_smiling_face: |
# |
Apr 21st 2017, 13:23 |
Neon1024 |
Might refactor that |
# |
Apr 21st 2017, 13:23 |
Neon1024 |
I should probably type hint against an interface really |
# |
Apr 21st 2017, 13:23 |
Neon1024 |
I take it all back |
# |
Apr 21st 2017, 13:21 |
admad |
if you don't want some other sorry soul to suffer too then yes :slightly_smiling_face: |
# |
Apr 21st 2017, 13:21 |
Neon1024 |
dereuromark, It is true! TIL https://3v4l.org/lpJ4X |
# |
Apr 21st 2017, 13:20 |
juniorionut |
@admad so do you want me to creata a new pull request? |
# |
Apr 21st 2017, 13:20 |
juniorionut |
:)) |
# |
Apr 21st 2017, 13:20 |
Neon1024 |
dereuromark, I don’t think it works myself, will try on 3v4l.org |
# |
Apr 21st 2017, 13:20 |
nemmons |
ah, my app is probably doing something weird that I've forgotten about then :-) |
# |
Apr 21st 2017, 13:20 |
Neon1024 |
dereuromark, I’d usually use php -a but I don’[t have the framework setup on CLI |
# |
Apr 21st 2017, 13:19 |
juniorionut |
@nemmons , i do not load User model in order to specify to Auth |
# |
Apr 21st 2017, 13:19 |
juniorionut |
Loading early means that that they are available early :)) |
# |
Apr 21st 2017, 13:19 |
nemmons |
I had the problem on my Users model, which, I'm not sure how you could get away with NOT loading that early, since the Auth Component needs it |
# |
Apr 21st 2017, 13:18 |
admad |
good lesson learned to not load models too early :slightly_smiling_face: |
# |
Apr 21st 2017, 13:18 |
juniorionut |
only 2-3 days lost :slightly_smiling_face: |
# |
Apr 21st 2017, 13:17 |
juniorionut |
@admad ok! |
# |
Apr 21st 2017, 13:17 |
juniorionut |
@nemmons , no problem , i did not knew either , saw now as i began to remove code :)) |
# |
Apr 21st 2017, 13:17 |
dereuromark |
Neon: you should know better - to quickly test it :slightly_smiling_face: then you would know that instance of also works with childs. |
# |
Apr 21st 2017, 13:17 |
technofection |
I am feeling helpless :( Please help me saving hasMany models |
# |
Apr 21st 2017, 13:17 |
juniorionut |
@nemmons , for me yes, that was the issue |
# |
Apr 21st 2017, 13:17 |
nemmons |
Yeah i had that same problem like a year ago. I wish i had known you were loading models in the component, i would have told you that was an issue =( |
# |
Apr 21st 2017, 13:16 |
admad |
make a PR to add note in readme |
# |
Apr 21st 2017, 13:16 |
Neon1024 |
If Chronos extends DateTime, would $chronos instance of DateTime be true? I think it’d be false right? Despite it being a child class |
# |
Apr 21st 2017, 13:16 |
nemmons |
Oh, man, that was the problem? |
# |
Apr 21st 2017, 13:16 |
juniorionut |
@admad , makes sense, i consider that this should be specified in the readme as others will lose interest quickly. I have spent alot of time untill i reached this point... |
# |
Apr 21st 2017, 13:15 |
admad |
@juniorionut if any model get's loaded through controller's initialize() it won't get the footprint listener get attached to it. |