| # |
Oct 6th 2016, 18:51 |
hmic |
nemmons: share it on the book! |
| # |
Oct 6th 2016, 18:51 |
 admad |
beforeFilter should be renamed to startup() |
| # |
Oct 6th 2016, 18:51 |
nemmons |
I'm going to sit down and draw out a diagram |
| # |
Oct 6th 2016, 18:51 |
hmic |
yeah. i did a PR to fix it, but - for the obvious reasons - it got postponed *beyond* 4.0 :p |
| # |
Oct 6th 2016, 18:50 |
admad |
The naming is surely confusing due to historical reasons |
| # |
Oct 6th 2016, 18:50 |
admad |
No, initialise is run first |
| # |
Oct 6th 2016, 18:49 |
hmic |
its quite stupid that the initziaize is run after bdfeforefilter, as i said in the beginning - the wording is so confusing! and the beforefilter event does the rest to kill all sanity in controller startup sequencing |
| # |
Oct 6th 2016, 18:49 |
nemmons |
@hmic yeah definitely. Thank you again. |
| # |
Oct 6th 2016, 18:49 |
nemmons |
@admad oh cool I'll have to take a look at that. Thanks |
| # |
Oct 6th 2016, 18:48 |
hmic |
so the things admad and i said are in respect to beforeFilter. hope it makes all sense now ;-) |
| # |
Oct 6th 2016, 18:48 |
admad |
Actually using the new 'authCheckIn' option you can have the authenticated user available in beforeFilter too now. Just not in initialise() |
| # |
Oct 6th 2016, 18:48 |
hmic |
yeah |
| # |
Oct 6th 2016, 18:47 |
nemmons |
@hmic yeah that's part of why i got so confused. I think if i understood the codebase better it would probabaly have been more obvious to me from the context that the reference to beforeRender was just a simple typo. |
| # |
Oct 6th 2016, 18:47 |
hmic |
s/your/our/ |
| # |
Oct 6th 2016, 18:47 |
Unfaiir |
Anyone know a good screencast app? I have some tutorial videos i've written for using Elixir with CakePHP with the cakephp-elixir node module, but I've never done a screencast, so any favorites? |
| # |
Oct 6th 2016, 18:47 |
hmic |
nemmons: beforeRender does make so little sense in this context, your brains just autocorrected it to beforeFilter ,-) |
| # |
Oct 6th 2016, 18:47 |
admad |
I'll update the comment when i am on pc |
| # |
Oct 6th 2016, 18:46 |
Leidenfrost |
slackebot->nemmons yes, but for some reason Users->Manager->Vendor isn't shown |
| # |
Oct 6th 2016, 18:46 |
hmic |
good for clarifying ;-) |
| # |
Oct 6th 2016, 18:46 |
nemmons |
Ah okay, that makes things make a hell of a lot more sense. Thank you both very much. |
| # |
Oct 6th 2016, 18:46 |
hmic |
because, like neomons says, beforeRender does not make quite sense for "component initialisation not run" as they are needed in the action, which executes before beforeRender does :p |
| # |
Oct 6th 2016, 18:46 |
admad |
I did mean beforeFilter and read as such too right now :) |
| # |
Oct 6th 2016, 18:44 |
hmic |
i answered nemmons, and i did read beforeFilter in your answer he pasted :p |
| # |
Oct 6th 2016, 18:44 |
hmic |
admad: you sure you did not mean beforeFilter instead of beforeRender? |
| # |
Oct 6th 2016, 18:44 |
nemmons |
Okay. Thank you for your time. |
| # |
Oct 6th 2016, 18:43 |
admad |
s/have/gave |
| # |
Oct 6th 2016, 18:43 |
admad |
I have the order if execution of the methods. Don't know any other way of stating the same |
| # |
Oct 6th 2016, 18:43 |
nemmons |
I didn't make any excuses. I agreed that your suggestion was correct and then gave the explanation for why i was unable to follow it |
| # |
Oct 6th 2016, 18:42 |
nemmons |
I'm not asking for a code change. I'm simply trying to understand how the code as written makes sense given you remark |
| # |
Oct 6th 2016, 18:42 |
slackebot |
controller::initialise(), do it in beforeFilter()" and answer to my question? |
| # |
Oct 6th 2016, 18:42 |
nemmons |
You said "A table initialized in Controller::beforeRender() won't get the footprint since AuthComponent::startup() has still not run." My question was "Looking in Http/ActionDispatcher->_invoke() it looks to me like component startup methods are definitely called before Controller::beforeRender().. Is it possible this has changed since May when you said this, or am i horribly misreading this code?" how is "don't initialise tables in |
| # |
Oct 6th 2016, 18:42 |
admad |
The code hasn't changed since my comment and unlikely to change |
| # |
Oct 6th 2016, 18:41 |
admad |
Answer came first, then the snark since you gave a lame excuse for being unable to follow advice given |
| # |
Oct 6th 2016, 18:40 |
nemmons |
No, you didn't answer me. I asked a very specific question and you gave a snarky response that was only tangentially related to what i asked. |
| # |
Oct 6th 2016, 18:40 |
admad |
Answered |
| # |
Oct 6th 2016, 18:40 |
admad |
And i answer you :) |
| # |
Oct 6th 2016, 18:39 |
nemmons |
I was just trying to ask an honest question to try and better understand the code base |
| # |
Oct 6th 2016, 18:39 |
admad |
Well sucks to be you then |
| # |
Oct 6th 2016, 18:38 |
nemmons |
i completely agree with you and if i was in total control of my codebase and had time to refactor a bunch of poorly-written stuff i would definitely do so |
| # |
Oct 6th 2016, 18:38 |
admad |
@nemmons don't initialise tables in controller::initialise(), do it in beforeFilter(). Problem solved |
| # |
Oct 6th 2016, 18:19 |
nemmons |
well, i guess it's more precise to say Users loaded through the Manager association will still have Vendors attached |