| # |
May 31st 2016, 11:15 |
 spriz |
aye |
| # |
May 31st 2016, 11:14 |
Neon1024 |
spriz, Does your method return $this->Crud->execute()? |
| # |
May 31st 2016, 11:14 |
birdy247 |
huh? |
| # |
May 31st 2016, 11:14 |
spriz |
or are there some magic that I just donâ??t get? |
| # |
May 31st 2016, 11:14 |
Neon1024 |
birdy247, But itâ??s 12:01! :p |
| # |
May 31st 2016, 11:14 |
spriz |
@neon1024: if I change something in the subject->id in the beforeFind event, itâ??s too late anyway |
| # |
May 31st 2016, 11:13 |
birdy247 |
not 09:00 |
| # |
May 31st 2016, 11:13 |
spriz |
@neon1024: is it me or is the logic here not working? :P https://github.com/FriendsOfCake/crud/blob/master/src/Traits/FindMethodTrait.php#L39 |
| # |
May 31st 2016, 11:13 |
birdy247 |
when I save though, its just going in as 10:00 |
| # |
May 31st 2016, 11:13 |
birdy247 |
which looks great |
| # |
May 31st 2016, 11:13 |
birdy247 |
this is after patching |
| # |
May 31st 2016, 11:13 |
birdy247 |
"date": "2016-06-01T10:00:00+0100", "closing_date": "2016-05-28T00:00:00+0100", |
| # |
May 31st 2016, 11:12 |
Neon1024 |
Well, I should qualify that, in one project I have it in my bootstrap.php and in the other project I donâ??t have it in my bootstrap.php |
| # |
May 31st 2016, 11:10 |
Neon1024 |
I do in 1 project, but not in the other |
| # |
May 31st 2016, 11:09 |
birdy247 |
do you use useLocaleParser(); |
| # |
May 31st 2016, 11:09 |
birdy247 |
question: |
| # |
May 31st 2016, 11:09 |
Neon1024 |
If we can come up with a nice solution, perhaps we can roll a plugin with some utilities and tools to help people tackle the problem |
| # |
May 31st 2016, 11:09 |
Neon1024 |
Otherwise, Iâ??d probably have a chat with ADmad about it, I bet heâ??s got a clever solution |
| # |
May 31st 2016, 11:08 |
Neon1024 |
He doesnâ??t use the marshaller class any more, so perhaps he has a better solution |
| # |
May 31st 2016, 11:08 |
Neon1024 |
Oh wait, he said he had two conferences, perhaps heâ??s travelling |
| # |
May 31st 2016, 11:08 |
Neon1024 |
Iâ??d defer to Jose, but I think heâ??s probably still in Amsterdam |
| # |
May 31st 2016, 11:06 |
birdy247 |
The times are still wrong :( |
| # |
May 31st 2016, 11:05 |
Neon1024 |
Would be an interesting experiment |
| # |
May 31st 2016, 11:04 |
Neon1024 |
I think perhaps not, as the DateTime object knows about daylight savings and such |
| # |
May 31st 2016, 11:04 |
Neon1024 |
Now we talk about it, I wonder if there is any value in storing the timezone in the db alongside the datetime |
| # |
May 31st 2016, 11:04 |
birdy247 |
time to look further down the chain |
| # |
May 31st 2016, 11:04 |
birdy247 |
you are right |
| # |
May 31st 2016, 11:03 |
Neon1024 |
Date times especially, as my brain doesnâ??t cope well with time, particularly datetime windows |
| # |
May 31st 2016, 11:03 |
Neon1024 |
Quite often I think something isnâ??t working, but then I realise that itâ??s working but Iâ??m looking in the wrong place or similar |
| # |
May 31st 2016, 11:03 |
micalm |
Die Driven Debugging FTW! |
| # |
May 31st 2016, 11:02 |
Neon1024 |
Do make sure to double check your testing methodology |
| # |
May 31st 2016, 11:02 |
birdy247 |
but when saving |
| # |
May 31st 2016, 11:02 |
birdy247 |
it patches the entity fine |
| # |
May 31st 2016, 11:02 |
birdy247 |
raining and 5 hours on something lol |
| # |
May 31st 2016, 11:01 |
Neon1024 |
Ouch :( |
| # |
May 31st 2016, 11:01 |
birdy247 |
this is one heck of a way to start a week :) lol |
| # |
May 31st 2016, 11:01 |
birdy247 |
@neon1024 still tryingto use that Type :slightly_smiling_face: |
| # |
May 31st 2016, 11:01 |
Neon1024 |
Whereas a <td> would be okay as itâ??s always got a andnbsp; on the end to account for that use-case |
| # |
May 31st 2016, 11:00 |
Neon1024 |
Perhaps itâ??s because the table helper might fail if a value is empty |
| # |
May 31st 2016, 10:59 |
spriz |
Might just be my hate to HTML that makes me love it :P |
| # |
May 31st 2016, 10:59 |
micalm |
Also that table helper code seems less readable, at least to me, but I could live with that. |