| # |
Oct 22nd 2009, 14:17 |
joeb |
My patch attempts to create a directory for the HTTP_HOST to store the cache files in. If it can't it just prepends the HTTP_HOST after it has been passed through Inflector::slug |
| # |
Oct 22nd 2009, 14:16 |
markstory |
unless you are doing a multisite thing there isn't much in /posts/view/4 that indicates what theme/view file should be used. |
| # |
Oct 22nd 2009, 14:16 |
ADmad |
so i guess it needs more refactoring to support caching of themed views |
| # |
Oct 22nd 2009, 14:16 |
ADmad |
hmm |
| # |
Oct 22nd 2009, 14:15 |
markstory |
ADmad: that is after the cache file has been picked. |
| # |
Oct 22nd 2009, 14:15 |
ADmad |
markstory: you can choose to run beforeFilter for cached pages too |
| # |
Oct 22nd 2009, 14:15 |
joeb |
I was just using the HTTP_HOST variable. |
| # |
Oct 22nd 2009, 14:15 |
joeb |
Well, the Dispatcher doesn't know the theme yet though. |
| # |
Oct 22nd 2009, 14:15 |
ADmad |
generate cache keys/filenames based on selected theme ? |
| # |
Oct 22nd 2009, 14:14 |
markstory |
when the cache is read the code has no access to theme information. |
| # |
Oct 22nd 2009, 14:14 |
markstory |
how is cached views supposed to work with themes? |
| # |
Oct 22nd 2009, 14:14 |
ADmad |
cool.. know what for the devs to check/respond |
| # |
Oct 22nd 2009, 14:14 |
joeb |
Yeah, I wasn't sure exactly with that. With the themeview I kinda assumed I guess =/ |
| # |
Oct 22nd 2009, 14:13 |
ADmad |
also your ticket should say something like "caching doesnt work as expected for themed views".. although you can cake isnt exactly supposed to support running multiple sites off single app |
| # |
Oct 22nd 2009, 14:13 |
joeb |
Okay. patch attached. |
| # |
Oct 22nd 2009, 14:12 |
joeb |
Will do, thanks. |
| # |
Oct 22nd 2009, 14:12 |
ADmad |
bin the diff and add link to ticket.. or fork the cakephp on code.cakephp and make changes to it and and add the commit link to ticket |
| # |
Oct 22nd 2009, 14:10 |
joeb |
I'm digging through my commits to get the one that fixed it. I'll put it up in a sec |
| # |
Oct 22nd 2009, 14:10 |
joeb |
It didn't have a spot for uploading a file |
| # |
Oct 22nd 2009, 14:09 |
ADmad |
no patch? |
| # |
Oct 22nd 2009, 14:08 |
joeb |
Okay. I submitted a ticket. |
| # |
Oct 22nd 2009, 14:08 |
t0nic |
I don't think it goes in Tag as it only pertains to tag vis-a-vis video and I to be able to add tags with their own rules |
| # |
Oct 22nd 2009, 14:07 |
t0nic |
anyway my main issue is *where* does this validation go |
| # |
Oct 22nd 2009, 14:05 |
t0nic |
hmm... it says check is "required" |
| # |
Oct 22nd 2009, 14:05 |
ADmad |
param of "multiple" |
| # |
Oct 22nd 2009, 14:05 |
ADmad |
then just use 'min' |
| # |
Oct 22nd 2009, 14:04 |
t0nic |
1. can I wildcard the multiple $check and 2. I'm still not clear as to how to reference the tag select in the video model validation |
| # |
Oct 22nd 2009, 14:03 |
t0nic |
ADmad I don't want to validate the data (tag ids) as those may change, I just want to check that they passed at least one tag |
| # |
Oct 22nd 2009, 14:01 |
ADmad |
you can only post comments on it not new tickets |
| # |
Oct 22nd 2009, 14:01 |
joeb |
Ah. Okay then. Thanks. |
| # |
Oct 22nd 2009, 14:01 |
markstory |
so its just a ticket silo for old enhancements right now |
| # |
Oct 22nd 2009, 14:01 |
markstory |
trac is still in use because we never got the tickets migrated over. |
| # |
Oct 22nd 2009, 14:00 |
markstory |
code.cakephp.org is correct. |
| # |
Oct 22nd 2009, 14:00 |
dogmatic69 |
code.cakephp |
| # |
Oct 22nd 2009, 14:00 |
dogmatic69 |
markstory: $this->Zip->zipFile( 'path/to/file' ); stuff |
| # |
Oct 22nd 2009, 14:00 |
joeb |
markstory: Well I found two places. I'm at http://code.cakephp.org/tickets/add but there was also the Trac url |
| # |
Oct 22nd 2009, 14:00 |
markstory |
joeb: code.cakephp.org can't make new ticketes on trac. |
| # |
Oct 22nd 2009, 13:59 |
ADmad |
the latter |
| # |
Oct 22nd 2009, 13:59 |
joeb |
dogmatic69: It's not so much that it's bloated but it has to do a *lot* of work to make a page. |
| # |
Oct 22nd 2009, 13:59 |
joeb |
ADmad: Should it goto trac.cakephp.org or code.cakephp.org |
| # |
Oct 22nd 2009, 13:59 |
markstory |
http://ca3.php.net/zip done |