# |
Oct 22nd 2009, 08:11 |
Gothfunc |
nah just the one |
# |
Oct 22nd 2009, 08:11 |
Gothfunc |
ok, thanks markstory |
# |
Oct 22nd 2009, 08:11 |
markstory |
it depends if you have more favorite things. |
# |
Oct 22nd 2009, 08:11 |
markstory |
Gothfunc: you can do it that way. |
# |
Oct 22nd 2009, 08:11 |
Gothfunc |
anyone? |
# |
Oct 22nd 2009, 08:11 |
Ceeram |
~tell rokker about book linking models together |
# |
Oct 22nd 2009, 08:10 |
Ceeram |
i'm convinced it's explained very clear |
# |
Oct 22nd 2009, 08:10 |
Ceeram |
rokker: what does the manual say? |
# |
Oct 22nd 2009, 08:10 |
NoReGreT |
what are the limitations of ACL ? I hear that most poeple try to avoind ACL, why is that ? |
# |
Oct 22nd 2009, 08:09 |
rokker |
What do when 2 models will "hasmany" other model? like: Places hasmany images, Rooms hasmany images.. What fields images tables contain? |
# |
Oct 22nd 2009, 08:09 |
Ceeram |
which i knind of suggested with saying: Don't understand why PHP functions are tested even |
# |
Oct 22nd 2009, 08:08 |
Ceeram |
so testUsingMbStrrpos() could be removed comletely as well |
# |
Oct 22nd 2009, 08:07 |
Ceeram |
so replacing all the mc_strrpos(0 by Multibyte::strrpos() would result in duplicate tests |
# |
Oct 22nd 2009, 08:06 |
Ceeram |
they are the same, one just uses php functions other one is using MB class |
# |
Oct 22nd 2009, 08:06 |
Ceeram |
markstory: look for function testUsingMbStrrpos() and function testMultibyteStrrpos() |
# |
Oct 22nd 2009, 08:04 |
Gothfunc |
seems a little circular |
# |
Oct 22nd 2009, 08:04 |
Gothfunc |
if you have users hasMany articles, but each user also has a favourite article, what's the correct way to implement that? article_id in the users table with belongsTo an article? |
# |
Oct 22nd 2009, 08:03 |
Ceeram |
^^ thats why i think it was copy/paste |
# |
Oct 22nd 2009, 08:03 |
Ceeram |
thats why i stated why are we testing php functions anyway? |
# |
Oct 22nd 2009, 08:02 |
Ceeram |
no just look at the tests and the ones above that, they are using MB class and running same test |
# |
Oct 22nd 2009, 08:01 |
markstory |
t have 5.1 though. |
# |
Oct 22nd 2009, 08:01 |
markstory |
I don |
# |
Oct 22nd 2009, 08:01 |
markstory |
yeah :) |
# |
Oct 22nd 2009, 08:00 |
Ceeram |
wake up a bit more and then take another look at it |
# |
Oct 22nd 2009, 07:56 |
markstory |
*possibly php's |
# |
Oct 22nd 2009, 07:56 |
Ceeram |
those are also in there already |
# |
Oct 22nd 2009, 07:56 |
Ceeram |
the other test without the $offset param in mb_strrpos(0 just pass |
# |
Oct 22nd 2009, 07:56 |
markstory |
probably, so the test needs to call Multibyte's functions instead of PHP's |
# |
Oct 22nd 2009, 07:55 |
Ceeram |
not tests when the mb_strrpos is called directly woth $offset param |
# |
Oct 22nd 2009, 07:55 |
Ceeram |
the Multibyte tests all pass |
# |
Oct 22nd 2009, 07:55 |
Ceeram |
i think the test was first written with php function and then copy pasted and changed to cake MultiByte class but forgot to take out tests with just mb_strrpos |
# |
Oct 22nd 2009, 07:54 |
Ceeram |
look at the file, you'll find the cake class test methods abiove that |
# |
Oct 22nd 2009, 07:54 |
markstory |
mb_strrpos() gets defined by multibyte if it doesn't exist. |
# |
Oct 22nd 2009, 07:53 |
markstory |
so why remove the tests, why not change them to use Multibyte::strrpos? |
# |
Oct 22nd 2009, 07:53 |
Ceeram |
$offset parameter was introduced in 5.2.0 |
# |
Oct 22nd 2009, 07:53 |
Ceeram |
http://php.net/manual/en/function.mb-strrpos.php |
# |
Oct 22nd 2009, 07:53 |
Ceeram |
not Multibyte::strrpos() |
# |
Oct 22nd 2009, 07:53 |
Ceeram |
is mb_strrpos |
# |
Oct 22nd 2009, 07:52 |
Ceeram |
no look at the code it tests the php function not cakes |
# |
Oct 22nd 2009, 07:52 |
markstory |
is there for me. |
# |
Oct 22nd 2009, 07:52 |
markstory |
Multibyte::strrpos() ? |