| # |
Sep 25th 2009, 10:38 |
alkemann |
hm.. im thinking maybe.. maybe the showDraft can always be active and only for the action for public view takes it off |
| # |
Sep 25th 2009, 10:37 |
alkemann |
making sure to not allow a flow where for instance a moderator edits the live data but keeps a draft existing |
| # |
Sep 25th 2009, 10:36 |
alkemann |
hm i dont think a use case can exist where the live table is newer than the draft, so revision should always look at draft instead of live if draft exist |
| # |
Sep 25th 2009, 10:35 |
gwoo |
then |
| # |
Sep 25th 2009, 10:35 |
gwoo |
oh i would override it in the model |
| # |
Sep 25th 2009, 10:34 |
gwoo |
yes |
| # |
Sep 25th 2009, 10:34 |
alkemann |
the method could be overwritten in the model to include that switch, but reducing those 3 lines to one is not really my point, but to remove it comepletely if we allow them knowing how to cooperate |
| # |
Sep 25th 2009, 10:34 |
gwoo |
just incase we need to change the automagic later |
| # |
Sep 25th 2009, 10:34 |
gwoo |
so maybe you could add that as a switch for showDraft |
| # |
Sep 25th 2009, 10:33 |
alkemann |
right, behaviour thing |
| # |
Sep 25th 2009, 10:33 |
gwoo |
it does not take any options |
| # |
Sep 25th 2009, 10:33 |
gwoo |
no that is always the first thing |
| # |
Sep 25th 2009, 10:33 |
gwoo |
ah it takes a Model |
| # |
Sep 25th 2009, 10:32 |
alkemann |
http://thechaw.com/bakery/source/branches/2.0/models/behaviors/revision.php#161 |
| # |
Sep 25th 2009, 10:32 |
alkemann |
no, it uses Model::id |
| # |
Sep 25th 2009, 10:31 |
alkemann |
those 3 lines do repeat yes |
| # |
Sep 25th 2009, 10:31 |
gwoo |
does createRevision take $options? |
| # |
Sep 25th 2009, 10:31 |
gwoo |
is that pretty standard? |
| # |
Sep 25th 2009, 10:31 |
gwoo |
ah i see |
| # |
Sep 25th 2009, 10:29 |
alkemann |
that create revision after save is normally automatic, the leak would be letting revision set the showDraft property on the model |
| # |
Sep 25th 2009, 10:28 |
alkemann |
http://thechaw.com/bakery/source/branches/2.0/controllers/article_pages_controller.php#27 |
| # |
Sep 25th 2009, 10:27 |
gwoo |
some leaking is fine, so long as it's documented |
| # |
Sep 25th 2009, 10:26 |
alkemann |
i put the finishing touches on getting revision and draft to work on the same model, i ended up taking revisions of automagic mode. which would you prefer, making controllers more explicit or letting them (at least in the bakery implementation) leak more into each other? |
| # |
Sep 25th 2009, 10:24 |
gwoo |
he will start working on the markup |
| # |
Sep 25th 2009, 10:24 |
gwoo |
once we finalize that |
| # |
Sep 25th 2009, 10:24 |
gwoo |
it's not quite there yet |
| # |
Sep 25th 2009, 10:24 |
gwoo |
we have been working with pointlessjon on a design |
| # |
Sep 25th 2009, 10:24 |
gwoo |
alkemann: yeah we need to get them on it |
| # |
Sep 25th 2009, 10:24 |
gwoo |
alkemann: great to hear. I been noticing the commits |
| # |
Sep 25th 2009, 10:24 |
alkemann |
do you think any of the people that said they would help, are into putting in some hours? |
| # |
Sep 25th 2009, 10:23 |
alkemann |
i think we are at a place now that people could be forking / branching and adding features, maybe get someone working on the design, view and layout |
| # |
Sep 25th 2009, 10:22 |
alkemann |
phally has come along way with the user plugin |
| # |
Sep 25th 2009, 10:21 |
alkemann |
gwoo: so now i have both test cases for article and article pages with full flow of creating, editing, publishing, with drafts and revisions, and working in the prototype app. |
| # |
Sep 24th 2009, 08:09 |
teknoid |
is it ok to reprint the article from my blog to bakery? or is that violation of terms? |
| # |
Sep 23rd 2009, 18:01 |
ProLoser1 |
ah |
| # |
Sep 23rd 2009, 18:01 |
Predominant |
But sometimes its a mess of broken html |
| # |
Sep 23rd 2009, 18:01 |
Predominant |
Sometimes its blank |
| # |
Sep 23rd 2009, 18:01 |
Predominant |
ProLoser1: The whole email I get from the bakery is a mess. |
| # |
Sep 23rd 2009, 17:22 |
ProLoser1 |
does anyone else get emails from the bakery with the <br /><br /> not getting parsed? |
| # |
Sep 23rd 2009, 09:13 |
Phally |
its not like i have never listened before d'oh |
| # |
Sep 23rd 2009, 09:12 |
alkemann |
alters |