| # |
Jul 21st 2009, 08:17 |
alkemann |
i guess if someone wants to make a branch for say implementing comments .. now would be good .. (im looking at you ADmad) |
| # |
Jul 21st 2009, 08:17 |
alkemann |
79 tests for Article and ArticlePage logic for create, edit, publish, soft delete, hard delete, draft, accept draft, and revisions created, all green. :) |
| # |
Jul 21st 2009, 08:12 |
markstory |
should be doable, the TestSuiteReporters can be a bit thorny |
| # |
Jul 21st 2009, 08:12 |
alkemann |
yea |
| # |
Jul 21st 2009, 08:12 |
markstory |
so html escaped |
| # |
Jul 21st 2009, 08:12 |
markstory |
ah ok |
| # |
Jul 21st 2009, 08:10 |
alkemann |
markstory: rendered like u see it, with html tags |
| # |
Jul 21st 2009, 08:10 |
alkemann |
markstory: http://bin.cakephp.org/view/833818512 |
| # |
Jul 21st 2009, 08:09 |
markstory |
or are you talking about string mismatches? |
| # |
Jul 21st 2009, 08:09 |
markstory |
oh for assertTags? |
| # |
Jul 21st 2009, 08:08 |
alkemann |
<style color:red> id ambigious blah blah |
| # |
Jul 21st 2009, 08:08 |
markstory |
perhaps. |
| # |
Jul 21st 2009, 08:08 |
alkemann |
markstory: im sure there are enough people out there that would actually be more motivated to do tests if it was prettier :) |
| # |
Jul 21st 2009, 08:08 |
markstory |
unrendered html? |
| # |
Jul 21st 2009, 08:08 |
alkemann |
markstory: and the yellow error messages that include unrendered html could use a small fix |
| # |
Jul 21st 2009, 08:07 |
markstory |
I'll see if I can convince the rest of the team for a facelift of the test suite. |
| # |
Jul 21st 2009, 08:07 |
ADmad |
maybe a carrot on pole |
| # |
Jul 21st 2009, 08:07 |
alkemann |
and maybe some skulls and bones for the red :) |
| # |
Jul 21st 2009, 08:06 |
alkemann |
i know. so please. make shiney |
| # |
Jul 21st 2009, 08:06 |
markstory |
same css engine. |
| # |
Jul 21st 2009, 08:06 |
alkemann |
ACTION uses chrome |
| # |
Jul 21st 2009, 08:06 |
markstory |
css gradients ftw! |
| # |
Jul 21st 2009, 08:06 |
alkemann |
that would be even better |
| # |
Jul 21st 2009, 08:06 |
markstory |
but it would only work in webkit. |
| # |
Jul 21st 2009, 08:06 |
markstory |
alkemann: I could make the green bar actually shiny :) |
| # |
Jul 21st 2009, 08:05 |
alkemann |
Phally: pushed more tests and Article logic |
| # |
Jul 21st 2009, 08:01 |
ADmad |
the reward of green bar can be alluring :) |
| # |
Jul 21st 2009, 08:01 |
alkemann |
it's so motivating implementing against tests |
| # |
Jul 21st 2009, 08:00 |
alkemann |
did it another way.. shiney green bar |
| # |
Jul 21st 2009, 08:00 |
ADmad |
you would have to assign $softDelete to a class member which you can use in beforeDelete |
| # |
Jul 21st 2009, 08:00 |
ADmad |
no.. |
| # |
Jul 21st 2009, 07:57 |
alkemann |
humm... can a callback know what params u bassed ? ie i have an overwritten delete($id, $softDelete) .. can i in beforeDelete know if i am hardDeleting? |
| # |
Jul 21st 2009, 07:52 |
alkemann |
heh |
| # |
Jul 21st 2009, 07:52 |
Phally |
well i have now, but not before i pushed that one hehe |
| # |
Jul 21st 2009, 07:51 |
alkemann |
havent u set global config? |
| # |
Jul 21st 2009, 07:51 |
Phally |
and he also forgot to commit the modified files |
| # |
Jul 21st 2009, 07:51 |
Phally |
indeed |
| # |
Jul 21st 2009, 07:51 |
alkemann |
what an idiot he is |
| # |
Jul 21st 2009, 07:50 |
Phally |
seems Frank de Graaf made a commit to the bakery |
| # |
Jul 21st 2009, 07:50 |
Phally |
hmm i screwed up hehe |
| # |
Jul 21st 2009, 07:48 |
Phally |
half an hour ago, you probably fixed it by now |