Log message #4217765

# At Username Text
# Dec 8th 2019, 00:38 challgren So your running `bin/cake upgrade rector --rules phpunit80 /home/otherapp/tests`
# Dec 8th 2019, 00:35 niel45 I'm trying to do this from the instructions: bin/cake upgrade rector --rules phpunit80 <path/to/app/tests>
# Dec 8th 2019, 00:35 challgren Whats the command your running?
# Dec 8th 2019, 00:35 niel45 no
# Dec 8th 2019, 00:34 challgren Are you trying to run your tests?
# Dec 8th 2019, 00:34 niel45 .../app/tests isn't it?
# Dec 8th 2019, 00:33 challgren Your not running it on the correct path
# Dec 8th 2019, 00:32 niel45 it's failing to fix though. crashes with a fatal error: Fatal error: Declaration of Cake\TestSuite\TestCase::setUp() must be compatible with PHPUnit\Framework\TestCase::setUp(): void in /home/niel/dev/www/nzedb-cake/vendor/cakephp/cakephp/src/TestSuite/TestCase.php on line 35
# Dec 8th 2019, 00:31 challgren Rector will try to fix stuff in your vendor if you do /home/otherapp/
# Dec 8th 2019, 00:30 challgren it should be only on the src or tests directories
# Dec 8th 2019, 00:27 corey.taylor.fl vendor is where the dependencies live so you need them until you're done.
# Dec 8th 2019, 00:17 niel45 hmmm apparently not
# Dec 8th 2019, 00:10 niel45 is it ok to delete the contents of .../vendor
# Dec 8th 2019, 00:09 niel45 damnit. fatal error running rector
# Dec 8th 2019, 00:02 challgren Yeah my app didnt have a locales either
# Dec 8th 2019, 00:02 challgren Ahh ok, I trashed my 4.x upgrade branch and I did it like 3 days ago so my paths may not be 100% correct
# Dec 8th 2019, 00:01 niel45 I see templates in base directory, but not locales
# Dec 8th 2019, 00:01 niel45 @corey.taylor.fl good point, but I won't be looking at commiting until its all done and tested
# Dec 8th 2019, 00:01 corey.taylor.fl It should be `templates/`
# Dec 8th 2019, 00:00 challgren Plus youd see the git changes
# Dec 8th 2019, 00:00 challgren Or /home/otherapp/template Im trying to recall off the top of my head
# Dec 8th 2019, 00:00 corey.taylor.fl I think the assumption is you'd see them move in git.
# Dec 8th 2019, 00:00 challgren the moved from /home/otherapp/src/Templates to /home/otherapp/templates
# Dec 7th 2019, 23:59 niel45 only one problem, updating the files doesn't tell you where/if they were moved
# Dec 7th 2019, 23:59 challgren Best to do like ROOT . ’/locales/ IMHO
# Dec 7th 2019, 23:59 niel45 oops, I do see them. tired eyes at the end of the day :-(
# Dec 7th 2019, 23:58 challgren No they do exist if they didn’t we be discussion other issues right now :P
# Dec 7th 2019, 23:58 niel45 and if those entries do not exists then I'm fine?
# Dec 7th 2019, 23:58 challgren so /home/otherapp/config/app.php
# Dec 7th 2019, 23:57 challgren yes
# Dec 7th 2019, 23:57 niel45 does "Once you’ve renamed your template and locale files, make sure you update App.paths.locales and App.paths.templates paths to be correct." refer to .../config/app.php entries?
# Dec 7th 2019, 23:57 niel45 yup
# Dec 7th 2019, 23:55 challgren ok cool if you like bow and arrows I found you :P
# Dec 7th 2019, 23:53 niel45 ok. it's plain niel
# Dec 7th 2019, 23:53 challgren Was going to tag you in the pull for the docs
# Dec 7th 2019, 23:53 niel45 yeah, why?
# Dec 7th 2019, 23:53 challgren niel45 you got a github name?
# Dec 7th 2019, 23:51 niel45 getting ready for final release
# Dec 7th 2019, 23:50 niel45 glad to find it for you ;-) I'm just trying it out on a test repo before I let it near active code :-)
# Dec 7th 2019, 23:50 corey.taylor.fl I wonder if console can print out the name of the first argument it can't find so people know it means 'file_name' that didn't match.
# Dec 7th 2019, 23:49 challgren But I’ll fix that cd /code/upgrade that is confusing