# |
May 21st 2019, 10:20 |
neon1024 |
https://github.com/FriendsOfCake/search/tree/master/docs |
# |
May 21st 2019, 10:20 |
neon1024 |
It’s now `$this->request->getQueryParams()` |
# |
May 21st 2019, 10:20 |
neon1024 |
@welo.lamacchia Did you update your controller code? |
# |
May 21st 2019, 10:06 |
welo.lamacchia |
i use it with Crud plugin with Crud.Search listener |
# |
May 21st 2019, 10:06 |
welo.lamacchia |
i compared all my tables but no differences found |
# |
May 21st 2019, 10:05 |
welo.lamacchia |
after update FriendsOfCake Search plugin, in only one of my tables i saw this error: Warning (2): call_user_func_array() expects parameter 1 to be a valid callback, class 'Search\Model\Behavior\SearchBehavior' does not have a method 'searchParams' [CORE/src/ORM/BehaviorRegistry.php, line 253] |
# |
May 21st 2019, 10:00 |
neon1024 |
Silly, I can abstract the condition out to a class method :face_palm: |
# |
May 21st 2019, 09:48 |
neon1024 |
I’ve only managed the validation methods from the controller before |
# |
May 21st 2019, 09:47 |
neon1024 |
If you have more than one validation rule which relies on the same condition is that a good opportunity to add a new validation method, but where would you bind the condition ? |
# |
May 21st 2019, 09:36 |
dereuromark |
I have to also add that case into my CastTrait i just saw. Should gracefully return null. |
# |
May 21st 2019, 09:31 |
neon1024 |
Well spotted! |
# |
May 21st 2019, 09:31 |
dereuromark |
empty string is not null. |
# |
May 21st 2019, 09:31 |
neon1024 |
Although this does feel more like correct behaviour, and an incorrect assumption on my behalf |
# |
May 21st 2019, 09:30 |
slackebot |
<neon1024> |
# |
May 21st 2019, 09:29 |
neon1024 |
Seems there is a bug in Hash::get or it looks like it to me |
# |
May 21st 2019, 09:29 |
neon1024 |
My mistake, my test was wrong |
# |
May 21st 2019, 09:28 |
neon1024 |
Test-case passes, so it’s just my code. I wonder what I’ve done wrong |
# |
May 21st 2019, 09:23 |
neon1024 |
See if I can replicate it |
# |
May 21st 2019, 09:23 |
neon1024 |
I’m going to add a test-case |
# |
May 21st 2019, 09:21 |
dereuromark |
keep ?? or use my CastTrait. i use it for phpstan level 7 code. |
# |
May 21st 2019, 09:20 |
admad |
> If the posted value was missing, you’d expect `0` right? Yes I would |
# |
May 21st 2019, 09:08 |
neon1024 |
Which doesn’t feel right at all |
# |
May 21st 2019, 09:08 |
neon1024 |
`empty($this->getRequest()->getData('payment_charge_amount')) ? 0 : $this->getRequest()->getData('payment_charge_amount'),` |
# |
May 21st 2019, 09:08 |
neon1024 |
THen you end up with |
# |
May 21st 2019, 09:06 |
neon1024 |
Which leads to `$this->getRequest()->getData('payment_charge_amount') ?? 0` which defeats the point of the default value right? |
# |
May 21st 2019, 09:05 |
neon1024 |
:thinking_face: |
# |
May 21st 2019, 09:05 |
neon1024 |
`CallsController.php:203:null` |
# |
May 21st 2019, 09:05 |
neon1024 |
If the posted value was missing, you’d expect `0` right? |
# |
May 21st 2019, 09:05 |
neon1024 |
`$this->getRequest()->getData('payment_charge_amount', 0)` |
# |
May 21st 2019, 09:05 |
neon1024 |
So |
# |
May 21st 2019, 08:53 |
neon1024 |
Perhaps it’s a hasMany, and is generating an extra query, and the order has been moved to the other query |
# |
May 21st 2019, 08:14 |
willem |
what could be the reason this order by is removed from the resulting query? ``` ->contain( [ 'CompanyBookBalances.CompanyBooks' => function ($q) { return $q->order(['CompanyBooks.name' => 'ASC']); } ] ) ``` |
# |
May 21st 2019, 07:50 |
welo.lamacchia |
is there a way to make work custom filter from My Own Plugin ? |
# |
May 21st 2019, 07:48 |
welo.lamacchia |
i found it, sorry!! :slightly_smiling_face: |
# |
May 21st 2019, 07:47 |
admad |
@welo.lamacchia you will have the answer to that if you read it's documentation |
# |
May 21st 2019, 07:44 |
welo.lamacchia |
hello, in FriendsOfCake Search is there a way to create custom Filter like value, boolean, compare etc ? |
# |
May 21st 2019, 07:40 |
k4t |
hello |
# |
May 21st 2019, 07:38 |
neon1024 |
Morning all :wave: |
# |
May 21st 2019, 07:08 |
admad |
@waspinator patching requires entity for the associations to be already present in entity you are patching |
# |
May 21st 2019, 02:38 |
waspinator |
it has a belongsToMany('Editors') and belongsToMany('Writers'), both of which are of `->setClassName('Users')` |
# |
May 21st 2019, 02:37 |
waspinator |
``` object(App\Model\Entity\Group) { 'name' => 'test group', '[new]' => true, '[accessible]' => [ 'name' => true, 'editors_groups' => true, 'groups_writers' => true ], '[dirty]' => [ 'name' => true ], '[original]' => [], '[virtual]' => [], '[hasErrors]' => false, '[errors]' => [], '[invalid]' => [], '[repository]' => 'Groups' } ``` |